[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-08-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923

Pierre-YvesChibon pin...@pingoured.fr changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2014-08-25 06:02:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-06-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923



--- Comment #6 from Pierre-YvesChibon pin...@pingoured.fr ---
built? Should we close this one?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923

Pierre-YvesChibon pin...@pingoured.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||pin...@pingoured.fr
   Assignee|nob...@fedoraproject.org|pin...@pingoured.fr
  Flags||fedora-review?



--- Comment #1 from Pierre-YvesChibon pin...@pingoured.fr ---
* Spec is clean
* License is GPLv2+
! In the sources, three files (src/expm.c, src/logm-eigen.c and
src/expm-eigen.c) have the following header:

 *  The functions therein use LAPACK and BLAS routines. Nicely
 *  formatted man pages for these can be found at
 *
 *http://www.mathkeisan.com/UsersGuide/E/
 *
 *  AUTHORS: Christophe Dutang, based on code eigen,
 *
 *  i.e., function 'modLa_rg' and 'modLa_dgesv' in R's
 *  Rsource/src/modules/lapack/lapack.c, used in eigen()

Could these be bundled? I did not check if they have been changed or not

* Builds errors on F20:

Warning: Nonexistent include directory /usr/lib64/gfortran/modules
gcc -m64 -std=gnu99 -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -m64 -mtune=generic -flto -fpic -Wl,-z,relro -o expm.so
R_dgebal.o expm-eigen.o expm.o init.o logm-eigen.o matexp.o matpow.o matrexp.o
matrexpO.o mexp-common.o -llapack -lblas -lgfortran -lm -lquadmath -lgfortran
-lm -lquadmath -L/usr/lib64/R/lib -lR
/usr/bin/ld: cannot find -llapack
/usr/bin/ld: cannot find -lblas
collect2: error: ld returned 1 exit status
make: *** [expm.so] Error 1
ERROR: compilation failed for package 'expm'

* rpmlint:
rpmlint R-expm-0.99.1.1-1.fc20.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

* sha512sum expm_0.99-1.1.tar.gz (upstream)
89c7728abb6ce8ec9fa86519e35be2c90f1381f4a5421e9e959c0900bb9a41805145059eb6fd175eb22d5510ecee7ad35b9abb4937c0f406c6acef82db3270c5
 expm_0.99-1.1.tar.gz
sha512sum R-expm-0.99.1.1-1.fc20.src/expm_0.99-1.1.tar.gz  (src.rpm)
89c7728abb6ce8ec9fa86519e35be2c90f1381f4a5421e9e959c0900bb9a41805145059eb6fd175eb22d5510ecee7ad35b9abb4937c0f406c6acef82db3270c5
 R-expm-0.99.1.1-1.fc20.src/expm_0.99-1.1.tar.gz


So we have to see about the headers and whether you want the F20 branch or not
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923



--- Comment #2 from Tom spot Callaway tcall...@redhat.com ---
The linking errors are because the latest R update which has Requires:
lapack-devel, blas-devel on R-devel hasn't hit stable yet.

src/expm.c uses a modified version of expm from Matrix, and calls out to
LAPACK/BLAS. That's pretty much the point of R-expm. ;) It would not be
possible to use the expm from Matrix here.

src/logm-eigen.c and src/expm-eigen.c have no bundling at all, just callouts to
LAPACK/BLAS functions.

I conclude there is no bundling concern here, but if you want me to get in the
FPC queue, I shall. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923

Pierre-YvesChibon pin...@pingoured.fr changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Pierre-YvesChibon pin...@pingoured.fr ---
 The linking errors are because the latest R update which has Requires: lapack-
 devel, blas-devel on R-devel hasn't hit stable yet.

Should we add a minimal version required then?

I trust we can do that before import into git.

Thanks for checking the sources, I will spare you adding it to the FPC queue :)


This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Tom spot Callaway tcall...@redhat.com ---
New Package SCM Request
===
Package Name: R-expm
Short Description: Computation of the matrix exponential and related quantities
Owners: spot
Branches: f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923



--- Comment #5 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095923] Review Request: R-expm - Computation of the matrix exponential and related quantities

2014-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095923

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review