[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-sprintf-0.1.3-3.fc20 |nodejs-sprintf-0.1.4-1.el7 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-sprintf-0.1.4-1.el7 |nodejs-sprintf-0.1.4-1.el6 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.4-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-sprintf-0.1.4-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-sprintf-0.1.4-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #11 from anish apa...@redhat.com --- Package Change Request == Package Name: nodejs-sprintf New Branches: el6 epel7 Owners: anishpatil InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 anish apa...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-sprintf-0.1.3-3.fc20 Resolution|--- |ERRATA Last Closed||2014-08-08 04:40:32 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.3-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.3-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-sprintf-0.1.3-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-sprintf-0.1.3-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #5 from anish apa...@redhat.com --- Thanks Parag for review New Package SCM Request === Package Name: nodejs-sprintf Short Description: JavaScript sprintf implementation Upstream URL: https://github.com/maritz/node-sprintf Owners: anishoatik Branches: f20 f21 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 anish apa...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #6 from anish apa...@redhat.com --- Correct owners name in earlier comment New Package SCM Request === Package Name: nodejs-sprintf Short Description: JavaScript sprintf implementation Upstream URL: https://github.com/maritz/node-sprintf Owners: anishpatil Branches: f20 f21 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #3 from anish apa...@redhat.com --- Hi Parag thank you for your help Please find updated spec and SRPM on Spec URL: http://anishpatil.fedorapeople.org/nodejs-sprintf.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-sprintf-0.1.3-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Parag AN(पराग) panem...@gmail.com --- Looks good now. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #2 from anish apa...@redhat.com --- Hi Parag Thank you for your review comments, I have incorporated first comment. However i can't incorporate comment 2 and 3 because package.json is not updated in released tarball by upstream. Updated https://github.com/maritz/node-sprintf/blob/master/package.json is in git repo but not on tarball Spec URL: http://anishpatil.fedorapeople.org/nodejs-sprintf.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-sprintf-0.1.3-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? --- Comment #1 from Parag AN(पराग) panem...@gmail.com --- Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-sprintf.noarch: W: spelling-error %description -l en_US js - dis, ks, j nodejs-sprintf.noarch: W: only-non-binary-in-usr-lib nodejs-sprintf.src: W: spelling-error %description -l en_US js - dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball :d77c7808d66a10a063eff55d36bb74ea383b84f219d42bb2378df031a2c89803 upstream tarball : d77c7808d66a10a063eff55d36bb74ea383b84f219d42bb2378df031a2c89803 + License MIT is valid and is included in its own file as %doc + rest looks following packaging guidelines Suggestions: 1) you can drop Group tag for Fedora releases. 2) Good to add following in %prep %nodejs_fixdep 3) Good to add following in %install %nodejs_symlink_deps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 anish apa...@redhat.com changed: What|Removed |Added Blocks||1096052 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1096052 [Bug 1096052] Review Request: - nodejs-i18n - lightweight translation module -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
