[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-mikey179-vfsstream-1.2. |php-mikey179-vfsstream-1.2. |0-2.fc20|0-2.el6 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- php-mikey179-vfsstream-1.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-mikey179-vfsstream-1.2. ||0-2.fc20 Resolution|--- |ERRATA Last Closed||2014-06-23 21:58:15 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- php-mikey179-vfsstream-1.2.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- php-mikey179-vfsstream-1.2.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|pa...@hubbitus.info Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327
Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #16 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
---
Package in good shape. Just standard note: please cleanup it on import.
Formal review:
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 55 files have unknown license. Detailed output of
licensecheck in /home/pasha/SOFT/Review/php-mikey179-vfsstream/1097327
-php-mikey179-vfsstream/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x!]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x!]: Buildroot is not present
Note: Buildroot: present but not needed
[x!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Remi Collet fed...@famillecollet.com --- Thanks! New Package SCM Request === Package Name: php-mikey179-vfsstream Short Description: PHP stream wrapper for a virtual file system Upstream URL: https://github.com/mikey179/vfsStream Owners: remi Branches: f19 f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- php-mikey179-vfsstream-1.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-mikey179-vfsstream-1.2.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- php-mikey179-vfsstream-1.2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-mikey179-vfsstream-1.2.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #14 from Remi Collet fed...@famillecollet.com --- https://fedorahosted.org/fpc/ticket/434 have been approved (will be announce soon, just need to write it) So the name php-mikey179-vfsstream complies with the PHP Guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #15 from Remi Collet fed...@famillecollet.com --- Provides php-composer(...) per new PHP Guidelines https://github.com/remicollet/remirepo/commit/e5ebae6502904d936479e4455d991bf805042cbc Spec: https://raw.githubusercontent.com/remicollet/remirepo/e5ebae6502904d936479e4455d991bf805042cbc/php/php-mikey179-vfsstream/php-mikey179-vfsstream.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-mikey179-vfsstream-1.2.0-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added CC||pa...@hubbitus.info --- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- # ['/usr/bin/yum-builddep', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '21', '/var/lib/mock/fedora-rawhide-x86_64/root///builddir/build/SRPMS/php-bartlett-PHP-Reflect-2.0.0-1.fc21.src.rpm'] Getting requirements for php-bartlett-PHP-Reflect-2.0.0-1.fc21.src -- php-common-5.5.12-1.fc21.x86_64 -- php-phpunit-PHPUnit-4.1.0-2.fc21.noarch -- php-phpunit-PHP-Timer-1.0.5-3.fc21.noarch -- php-symfony-classloader-2.4.4-1.fc21.noarch -- php-symfony-eventdispatcher-2.4.4-1.fc21.noarch -- php-symfony-finder-2.4.4-1.fc21.noarch -- php-symfony-console-2.4.4-1.fc21.noarch Error: No Package found for php-PHPParser = 1.0.0 Even in rawhide 0.9.4-1.fc21 available only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327
--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
If it is not intended for EL-5 BuildRoot, rm -rf %{buildroot},
%defattr(-,root,root,-) and similar legacy stuff should be dropped.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Depends On||1096697 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1096697 [Bug 1096697] Please update to 1.0.0bet1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Depends On|1096697 | --- Comment #3 from Remi Collet fed...@famillecollet.com --- Sorry, bad Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1096697 [Bug 1096697] Please update to 1.0.0bet1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #4 from Remi Collet fed...@famillecollet.com --- Correct URL for the SRPM Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/520df27b2cc6c62353c8e70f43da8790d4e9b378/php/php-mikey179-vfsstream/php-mikey179-vfsstream.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-mikey179-vfsstream-1.2.0-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327
--- Comment #5 from Remi Collet fed...@famillecollet.com ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #2)
If it is not intended for EL-5 BuildRoot, rm -rf %{buildroot},
%defattr(-,root,root,-) and similar legacy stuff should be dropped.
Yes, I usually does this after import (I'm used to build them for EL-5 in my
backport repo, so I need this, and Guidelines doesn't state this is forbidden,
just that this is unneeded).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- It seems package in good shape on first glance. Only php-PHPParser = 1.0.0 required to do full review. Why you add and then remove dependency from bz#1096697? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #7 from Remi Collet fed...@famillecollet.com --- There is no dependency on php-PHPParser (this hit you because previous srpm link was for another package, php-bartlett-PHP-Reflect, which need it). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- And project called vfsStream, for what you are include git username into package? Shouldn't it be just php-vfsStream or just php-vfsstream? Wiki (https://github.com/mikey179/vfsStream/wiki) also name it vfs://Stream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #9 from Remi Collet fed...@famillecollet.com --- Because there is no naming Guidelines yet for composer package. This project is known as mikey179/vfsStream See: https://github.com/mikey179/vfsStream/blob/master/composer.json At some point we really need some Guidelines (some already proposed on php-de...@lists.fedoraproject.org), but nothing yet usable. Of course, as there is no Guidelines, name can be discussed. I think the php-composer-known-name (or php-vendor-project) is correct as it avoid name conflicts. I have think to use: - php-vfsstream (only project name, but conflict risk) - php-org-bovigo-vfs (namespace) - php-vfs-stream etc... I don't think there is a really best choice... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327
--- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
---
Introduce new naming scheme for composer packages may have worth, but untill
it did not happened we have only
https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme for PEAR, Pecl,
Channel, and Other: Other packages should be named
php-PackageName-%{version}-%{release}.%{arch}.rpm; %{arch} can be noarch
where appropriate..
I think we must use last until.
Furthermore not it name is not conflicted with anything and hopefully will not.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #11 from Remi Collet fed...@famillecollet.com --- This package is not urgent (only required for a test suite, which is disabled for now) I will draft the Guidelines proposal for composer libraries, propose it to the PHP SIG and then to the FPC. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #12 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- It seems as proper way. So you suggest wait until it happened? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097327] Review Request: php-mikey179-vfsstream - PHP stream wrapper for a virtual file system
https://bugzilla.redhat.com/show_bug.cgi?id=1097327 --- Comment #13 from Remi Collet fed...@famillecollet.com --- Yes, we can wait. I think my proposal will include the vendor part, this will be consistent with lot of existing packages, php-symfony-*, php-phunit-*, php-horde-*... But this will be discussed (and approved) with other packagers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
