[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(lti...@redhat.com | |) | --- Comment #4 from Lukáš Tinkl lti...@redhat.com --- Good to go from me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Rex Dieter rdie...@math.unl.edu --- Thanks. New Package SCM Request === Package Name: baloo-kcmadv Short Description: Baloo Desktop Search Advanced configuration module Upstream URL: https://gitorious.org/baloo-kcmadv Owners: rdieter Branches: f20 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-07-15 18:23:22 --- Comment #7 from Rex Dieter rdie...@math.unl.edu --- Imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||needinfo?(lti...@redhat.com ||) --- Comment #3 from Rex Dieter rdie...@math.unl.edu --- ping, do you see anything else that needs fixing? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lti...@redhat.com Assignee|nob...@fedoraproject.org|lti...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384
--- Comment #1 from Lukáš Tinkl lti...@redhat.com ---
The package has wrong license (GPLv2 stated, LGPLv2 actual) and no LICENSE or
COPYING file. Otherwise looks good, full report below.
--
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2), Unknown or generated. 3 files have unknown license.
Detailed output of licensecheck in /home/ltinkl/tmp/1097384-baloo-
kcmadv/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 --- Comment #2 from Rex Dieter rdie...@math.unl.edu --- %changelog * Tue Jun 24 2014 Rex Dieter rdie...@fedoraproject.org 0-0.2.20140427git0656135 - License: LGPLv2 Spec URL: http://rdieter.fedorapeople.org/rpms/baloo-kcmadv/baloo-kcmadv.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/baloo-kcmadv/baloo-kcmadv-0-0.2.20140427git0656135.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097384] Review Request: baloo-kcmadv - Baloo Desktop Search Advanced configuration module
https://bugzilla.redhat.com/show_bug.cgi?id=1097384 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||656997 (kde-reviews), ||1090615 (kde-4.13) Alias||baloo-kcmadv Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1090615 [Bug 1090615] kde-4.13 Tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
