[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||imaptest-20140711-1.fc19
 Resolution|--- |ERRATA
Last Closed||2014-08-01 02:00:46



--- Comment #17 from Fedora Update System upda...@fedoraproject.org ---
imaptest-20140711-1.fc19 has been pushed to the Fedora 19 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|imaptest-20140711-1.fc19|imaptest-20140711-1.fc20



--- Comment #18 from Fedora Update System upda...@fedoraproject.org ---
imaptest-20140711-1.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #13 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #14 from Fedora Update System upda...@fedoraproject.org ---
imaptest-20140528-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/imaptest-20140528-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #15 from Fedora Update System upda...@fedoraproject.org ---
imaptest-20140528-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/imaptest-20140528-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System upda...@fedoraproject.org ---
imaptest-20140711-1.fc20 has been pushed to the Fedora 20 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Christopher Meng i...@cicku.me ---
PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Robert Scheck red...@linuxnetz.de changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #12 from Robert Scheck red...@linuxnetz.de ---
New Package SCM Request
===
Package Name: imaptest
Short Description: A generic IMAP server compliancy tester
Upstream URL: http://www.imapwiki.org/ImapTest
Owners: robert
Branches: f19 f20 f21 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags|needinfo?(i...@cicku.me)   |



--- Comment #10 from Christopher Meng i...@cicku.me ---
I want to test it against some real service... As I was sloppy on this review.

I will approve tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Robert Scheck redhat-bugzi...@linuxnetz.de changed:

   What|Removed |Added

  Flags||needinfo?(i...@cicku.me)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-07-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #9 from Robert Scheck redhat-bugzi...@linuxnetz.de ---
Christopher, anything new here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Robert Scheck red...@linuxnetz.de changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #3 from Robert Scheck red...@linuxnetz.de ---
New Package SCM Request
===
Package Name: imaptest
Short Description: A generic IMAP server compliancy tester
Upstream URL: http://www.imapwiki.org/ImapTest
Owners: robert
Branches: f20 f19 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Dominic Hopf dma...@fedoraproject.org changed:

   What|Removed |Added

 CC||dma...@fedoraproject.org



--- Comment #4 from Dominic Hopf dma...@fedoraproject.org ---
I'm having issues running this on an x86_64 system:

% imaptest
imaptest: error while loading shared libraries: libdovecot-lda.so.0: cannot
open shared object file: No such file or directory

% yum provides libdovecot-lda.so.0 
   
   
Loaded plugins: changelog, etckeeper, langpacks, remove-with-leaves,
show-leaves
1:dovecot-2.2.7-2.fc20.i686 : Secure imap and pop3 server
Repo: fedora
Matched from:
Provides: libdovecot-lda.so.0



1:dovecot-2.2.13-1.fc20.i686 : Secure imap and pop3 server
Repo: updates
Matched from:
Provides: libdovecot-lda.so.0


% rpm -q dovecot
dovecot-2.2.13-1.fc20.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags|fedora-review+ fedora-cvs?  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #5 from Christopher Meng i...@cicku.me ---
Confirmed, 32bits doesn't work as well...

I first thought it was caused by some rpath issues, but seems that's not the
right clue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Robert Scheck redhat-bugzi...@linuxnetz.de changed:

   What|Removed |Added

 CC||mhlav...@redhat.com



--- Comment #6 from Robert Scheck redhat-bugzi...@linuxnetz.de ---
Dominic, thank you very much for catching this. After some analysis and if
I am not mistaken this is a bug in the dovecot RPM package where *.la files
are removed (these contain the necessary -rpath call):

 
http://dovecot.2317879.n4.nabble.com/dovecot-2-0-pigeonhole-0-2-1-installation-in-wrong-lib-dir-td34760.html

Instead of keeping the *.la files some -rpath patching should be likely added
to /usr/lib/dovecot/dovecot-config (which can happen downstream only, IIRC).
Adding dovecot package maintainer on Cc to get this proper solved in Fedora
and RHEL 7.

For the time being I would like use the following workaround:

--- snipp ---
--- imaptest.spec   2014-06-03 00:05:11.0 +0200
+++ imaptest.spec.rsc   2014-06-20 19:58:45.0 +0200
@@ -23,6 +23,9 @@
 %prep
 %setup -q

+# Workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1103927#c4 (and
later)
+sed -e 's@\(^LIBDOVECOT .*\)@\1 -Wl,-rpath -Wl,%{_libdir}/dovecot@' -i
src/Makefile.in
+
 %build
 %configure --with-dovecot=%{_libdir}/dovecot
 make %{?_smp_mflags}
--- snapp ---

Spec URL: http://labs.linuxnetz.de/bugzilla/imaptest.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/imaptest-20140528-2.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #7 from Christopher Meng i...@cicku.me ---
I thought it's caused by rpath, but failed on 32bits made me change my opinion
;) I was wrong ;)

I will finish the review tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927



--- Comment #8 from Dominic Hopf dma...@fedoraproject.org ---
Works for me now, thanks for the prompt fix. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Christopher Meng i...@cicku.me ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Unknown or generated. 32 files have unknown license. Detailed output of
 licensecheck:

Unknown or generated

imaptest-20140528/ltmain.sh
imaptest-20140528/src/checkpoint.c
imaptest-20140528/src/checkpoint.h
imaptest-20140528/src/client-state.c
imaptest-20140528/src/client-state.h
imaptest-20140528/src/client.c
imaptest-20140528/src/client.h
imaptest-20140528/src/commands.c
imaptest-20140528/src/commands.h
imaptest-20140528/src/imaptest-lmtp.c
imaptest-20140528/src/imaptest-lmtp.h
imaptest-20140528/src/imaptest.c
imaptest-20140528/src/imapurl.c
imaptest-20140528/src/imapurl.h
imaptest-20140528/src/mailbox-source.c
imaptest-20140528/src/mailbox-source.h
imaptest-20140528/src/mailbox-state.c
imaptest-20140528/src/mailbox-state.h
imaptest-20140528/src/mailbox.c
imaptest-20140528/src/mailbox.h
imaptest-20140528/src/profile-parse.c
imaptest-20140528/src/profile.c
imaptest-20140528/src/profile.h
imaptest-20140528/src/search.c
imaptest-20140528/src/search.h
imaptest-20140528/src/settings.h
imaptest-20140528/src/test-exec.c
imaptest-20140528/src/test-exec.h
imaptest-20140528/src/test-parser.c
imaptest-20140528/src/test-parser.h
imaptest-20140528/src/user.c
imaptest-20140528/src/user.h

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm  4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.

[Bug 1103927] Review Request: imaptest - A generic IMAP server compliancy tester

2014-06-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1103927

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||i...@cicku.me
   Assignee|nob...@fedoraproject.org|i...@cicku.me
  Flags||fedora-review?



--- Comment #1 from Christopher Meng i...@cicku.me ---
Fine to swap with bug 1096138?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review