[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||erlang-sd_notify-0.1-1.fc19 Resolution|--- |ERRATA Last Closed||2014-07-01 19:27:41 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- erlang-sd_notify-0.1-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|erlang-sd_notify-0.1-1.fc19 |erlang-sd_notify-0.1-1.fc20 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- erlang-sd_notify-0.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- erlang-sd_notify-0.1-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 --- Comment #3 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- erlang-sd_notify-0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/erlang-sd_notify-0.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- erlang-sd_notify-0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/erlang-sd_notify-0.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 John Eckersberg jecke...@redhat.com changed: What|Removed |Added Blocks|1104193 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1104193 [Bug 1104193] rabbitmqctl doesn't work -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 John Eckersberg jecke...@redhat.com changed: What|Removed |Added Blocks||1104193 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1104193 [Bug 1104193] rabbitmqctl doesn't work -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Peter Lemenkov lemen...@gmail.com --- John, thanks for the reviewing this! I'll address both the issues you've mentioned before upload. Next step will be RabbitMQ server with Type=notify. New Package SCM Request === Package Name: erlang-sd_notify Short Description: Erlang interface to systemd notify subsystem Upstream URL: https://github.com/lemenkov/erlang-sd_notify Owners: peter Branches: f19 f20 epel7 InitialCC: erlang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 John Eckersberg jecke...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from John Eckersberg jecke...@redhat.com --- This looks pretty good, the only nits are: - Include LICENSE in %doc - Use install -p to preserve timestamps I'm going to go ahead and flag this as approved, just make sure to correct those before you build for real. Also I sanity checked that the systemd notify works as expected: [fedora@jeckersb-rawhide 1104604-erlang-sd_notify]$ cat /etc/systemd/system/notify-test.service [Unit] Description=Notify Test [Service] Type=notify Environment=HOME=/root ExecStart=/usr/bin/erl -noshell -eval 'sd_notify:sd_notify(0, READY=1)' [Install] WantedBy=multi-user.target [fedora@jeckersb-rawhide 1104604-erlang-sd_notify]$ sudo service notify-test start Redirecting to /bin/systemctl start notify-test.service [fedora@jeckersb-rawhide 1104604-erlang-sd_notify]$ sudo service notify-test status Redirecting to /bin/systemctl status notify-test.service ● notify-test.service - Notify Test Loaded: loaded (/etc/systemd/system/notify-test.service; disabled) Active: active (running) since Fri 2014-06-13 20:28:30 UTC; 7s ago Main PID: 16473 (beam.smp) CGroup: /system.slice/notify-test.service └─16473 /usr/lib64/erlang/erts-5.10.4/bin/beam.smp -- -root /usr/lib64/erlang -progname erl -- -home /root -- -noshell -eval sd_notify:sd_notify(0, READY=1) Jun 13 20:28:30 jeckersb-rawhide.novalocal systemd[1]: Started Notify Test. [fedora@jeckersb-rawhide 1104604-erlang-sd_notify]$ Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: MIT/X11 (BSD like). Detailed output of licensecheck in /home/fedora/1104604-erlang-sd_notify/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]:
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 John Eckersberg jecke...@redhat.com changed: What|Removed |Added CC||jecke...@redhat.com Assignee|nob...@fedoraproject.org|jecke...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1104604] Review Request: erlang-sd_notify - Erlang interface to systemd notify subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1104604 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||1103524 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1103524 [Bug 1103524] Change rabbitmq-server systemd service to Type=notify -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review