[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added Blocks||1026118 CC||tchollingswo...@gmail.com --- Comment #11 from Kevin Kofler ke...@tigcc.ticalc.org --- *** Bug 1026117 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1026118 [Bug 1026118] enable AppStream in apper -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Richard Hughes rhug...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Richard Hughes rhug...@redhat.com --- New Package SCM Request === Package Name: appstream-data Short Description: Fedora AppStream metadata Upstream URL: https://github.com/hughsie/createrepo_as Owners: rhughes Branches: f20 InitialCC: rhughes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Richard Hughes rhug...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||appstream-data-21-2.fc21 Resolution|--- |RAWHIDE Last Closed||2014-06-12 09:11:49 --- Comment #10 from Richard Hughes rhug...@redhat.com --- Great, thanks all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Flags||fedora-review? --- Comment #3 from Lukáš Tinkl lti...@redhat.com --- - The description contains a double article: This package provides a the ... - The koji URL points to some other package's build -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 --- Comment #4 from Richard Hughes rhug...@redhat.com --- (In reply to Lukáš Tinkl from comment #3) - The description contains a double article: This package provides a the Fixed, sorry. - The koji URL points to some other package's build Oops, that was supposed to be: http://koji.fedoraproject.org/koji/taskinfo?taskID=7035138 -- sorry! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802
--- Comment #5 from Lukáš Tinkl lti...@redhat.com ---
The review fails in these points:
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/app-info/icons, /usr/share/app-
info/xmls, /usr/share/app-info/icons/fedora-21, /usr/share/app-info
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/app-info/icons,
/usr/share/app-info, /usr/share/app-info/xmls, /usr/share/app-
info/icons/fedora-21
Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[-]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/app-info/icons, /usr/share/app-
info/xmls, /usr/share/app-info/icons/fedora-21, /usr/share/app-info
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/app-info/icons,
/usr/share/app-info, /usr/share/app-info/xmls, /usr/share/app-
info/icons/fedora-21
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 --- Comment #6 from Richard Hughes rhug...@redhat.com --- * Wed Jun 11 2014 Richard Hughes rich...@hughsie.com 21-2 - Own the correct directories - Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1107802#c5 New spec updated and new srpm available at http://people.freedesktop.org/~hughsient/temp/appstream-data-21-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Lukáš Tinkl lti...@redhat.com --- All seems good to go (excerpt from the updated review run below)! ... [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. ... Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -n appstream-data-21-2.fc20.src.rpm -r -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Lukáš Tinkl lti...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lti...@redhat.com Assignee|nob...@fedoraproject.org|lti...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 --- Comment #1 from Lukáš Tinkl lti...@redhat.com --- BuildRequires: libappstream-glib That shouldn't be there, the package doesn't build anything -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107802] Review Request: appstream-data - Fedora AppStream metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1107802 Kalev Lember kalevlem...@gmail.com changed: What|Removed |Added CC||kalevlem...@gmail.com --- Comment #2 from Kalev Lember kalevlem...@gmail.com --- (In reply to Lukáš Tinkl from comment #1) BuildRequires: libappstream-glib That shouldn't be there, the package doesn't build anything It's for /usr/bin/appstream-util that's used in %install. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
