[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Fedora Update System changed: What|Removed |Added Fixed In Version|dSFMT-2.2.3-4.fc19 |dSFMT-2.2.3-4.el7 --- Comment #26 from Fedora Update System --- dSFMT-2.2.3-4.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Fedora Update System changed: What|Removed |Added Fixed In Version|dSFMT-2.2.3-4.fc20 |dSFMT-2.2.3-4.fc19 --- Comment #25 from Fedora Update System --- dSFMT-2.2.3-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Fedora Update System changed: What|Removed |Added Fixed In Version|dSFMT-2.2.3-4.fc21 |dSFMT-2.2.3-4.fc20 --- Comment #24 from Fedora Update System --- dSFMT-2.2.3-4.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||dSFMT-2.2.3-4.fc21 Resolution|--- |ERRATA Last Closed||2014-09-23 00:44:44 --- Comment #23 from Fedora Update System --- dSFMT-2.2.3-4.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- dSFMT-2.2.3-4.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #21 from Fedora Update System --- dSFMT-2.2.3-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/dSFMT-2.2.3-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #20 from Fedora Update System --- dSFMT-2.2.3-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dSFMT-2.2.3-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #19 from Fedora Update System --- dSFMT-2.2.3-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/dSFMT-2.2.3-4.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #18 from Fedora Update System --- dSFMT-2.2.3-4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/dSFMT-2.2.3-4.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Milan Bouchet-Valat changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #16 from Milan Bouchet-Valat --- I just saw Paulo's mail on fedora-devel. Funny how I checked all fields, but not the header. So here we are: New Package SCM Request === Package Name: dSFMT Upstream URL: http://www.math.sci.hiroshima-u.ac.jp/~%20m-mat/MT/SFMT/index.html Short Description: Double precision SIMD-oriented Fast Mersenne Twister Owners: laxathom nalimilan Branches: f19 f20 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #15 from Milan Bouchet-Valat --- > NOTE: Misformatted request; using 'Branches' instead. Not sure what this means: I followed the syntax from https://fedoraproject.org/wiki/Package_SCM_admin_requests Package Change Request == Package Name: dSFMT Short Description: Double precision SIMD-oriented Fast Mersenne Twister Upstream URL: http://www.math.sci.hiroshima-u.ac.jp/~%20m-mat/MT/SFMT/index.html New Branches: f19 f20 f21 epel7 Owners: laxathom nalimilan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Milan Bouchet-Valat changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Milan Bouchet-Valat changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #14 from Milan Bouchet-Valat --- > WARNING: Package does not appear to exist in pkgdb currently. I guess this happened because I forgot to assign the bug to myself when reviewing? Retrying. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #13 from Jon Ciesla --- WARNING: Package does not appear to exist in pkgdb currently. NOTE: Misformatted request; using 'Branches' instead. WARNING: SCM request was not the last comment. WARNING: No new branches requested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Paulo Andrade changed: What|Removed |Added CC||paulo.cesar.pereira.de.andr ||a...@gmail.com --- Comment #12 from Paulo Andrade --- Adding myself to CC to know when it is in the git repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Milan Bouchet-Valat changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Milan Bouchet-Valat --- Package Change Request == Package Name: dSFMT Short Description: Double precision SIMD-oriented Fast Mersenne Twister Upstream URL: http://www.math.sci.hiroshima-u.ac.jp/~%20m-mat/MT/SFMT/index.html Branches: f20 f19 epel7 Owners: laxathom nalimilan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Orion Poplawski changed: What|Removed |Added CC||or...@cora.nwra.com Assignee|nob...@fedoraproject.org|nalimi...@club.fr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765
Milan Bouchet-Valat changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Milan Bouchet-Valat ---
OK, I have done the final review even if I have also modified the package
myself. The new version adds %check and moves docs to a -devel-doc package.
Everything looks good.
Xavier, are you still interested in this package? Can you handle the SCM
request?
Spec URL: http://nalimilan.perso.neuf.fr/transfert/dSFMT.spec
SRPM URL: http://nalimilan.perso.neuf.fr/transfert/dSFMT-2.2.3-4.fc20.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7516831
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 28 files have unknown license. Detailed output of
licensecheck in
/home/milan/Dev/rpmbuild/review/koji/dSFMT/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 12 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
> Done via Koji (see above link).
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upst
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #9 from Milan Bouchet-Valat --- Would someone do the final review? Spec URL: http://nalimilan.perso.neuf.fr/transfert/dSFMT-2.2.3-3.fc20.src.rpm SRPM URL: http://nalimilan.perso.neuf.fr/transfert/dSFMT-2.2.3-3.fc20.src.rpm Copr build: http://copr.fedoraproject.org/coprs/nalimilan/julia/build/21562/ I've been using this package for Julia builds in Copr for a few months without any issue. Regarding my Comment 8 above, I was actually mistaken: dSFMT never works without SSE anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #8 from Milan Bouchet-Valat --- I just noticed you kept this line in sharedlib.patch: ``` +SSE2FLAGS = -msse2 -DHAVE_SSE2 ``` If you keep it even on 32-bit, then dSFMT will effectively require Pentium 4 and above. I've no problem with that, but I'm not sure that's OK with regard to Fedora policies (I have the same problem for Julia...). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #7 from Milan Bouchet-Valat --- I've made a SRPM with the two patches merged into one (since they are highly related). It works for me with Julia: http://nalimilan.perso.neuf.fr/transfert/dSFMT-2.2.3-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #6 from Milan Bouchet-Valat --- Apparently, the second patch is needed simply because dSFMT is originally supposed to be compiled with the calling code instead of as a separate library. So I think you should include it in your dSFMT-2.2.3_sharedlib.patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #5 from Milan Bouchet-Valat --- Cool! Though you don't seem to have changed DESTDIR. Is this voluntary? To use your package to build Julia, I'd need you to apply two patches Julia is using. The first one is fairly trivial, but the second may be more controversial as it also makes public a few private functions: https://github.com/JuliaLang/julia/blob/master/deps/dSFMT.c.patch https://github.com/JuliaLang/julia/blob/master/deps/dSFMT.h.patch I've asked more information about the patches on the Julia development list: https://groups.google.com/d/msg/julia-dev/oh_p5DeXzaQ/MU7d92O3Z7AJ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #4 from Xavier Lamien --- Here we go! Spec URL: http://laxathom.fedorapeople.org/infra-fp/fpc/dSFMT/dSFMT.spec SRPM URL: http://laxathom.fedorapeople.org/infra-fp/fpc/dSFMT/dSFMT-2.2.3-2.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7051053 Lemme know if I miss something. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #3 from Xavier Lamien --- Good catch on value path. I'll make the change. >> Finally, have you tried contacting the author? He might be interesting I >> applying your patch to make a real shared library upstream. Not yet. However, I'd prefer to add a configure step upstream. I've something downstream already. Will let you know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 --- Comment #2 from Milan Bouchet-Valat --- Thanks for taking care of this! I have spotted a few things: >+LIBDIR = $(PREFIX)/lib64 Maybe 'lib' would be better, since it does not depend on the architecture. >+SSE2_LIBDIR = $(LIBDIR)/ss2 Looks like a typo, shouldn't it be '$(LIBDIR)/sse2'? >+DESTDIR= . Shouldn't it be empty instead? The standard behavior is to install to $(PREFIX). Also, I think the names of variables should be lower case as standard GNU variables: http://www.gnu.org/software/make/manual/html_node/Directory-Variables.html DESTDIR is apparently uppercase, though. Finally, have you tried contacting the author? He might be interesting I applying your patch to make a real shared library upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Tom "spot" Callaway changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765
--- Comment #1 from Tom "spot" Callaway ---
Quick comments:
The license tag is wrong here, "Freely redistributable without restriction"
only is valid for Firmware.
http://www.math.sci.hiroshima-u.ac.jp/~%20m-mat/MT/SFMT/LICENSE.txt is BSD.
You do not need to delete the %{buildroot} at the beginning of %install.
Outside of that, the rpmlint is mostly safe to ignore:
dSFMT.src: W: spelling-error %description -l en_US pseudorandom -> pseudo
random, pseudo-random, pseudonymous
dSFMT.x86_64: W: spelling-error %description -l en_US pseudorandom -> pseudo
random, pseudo-random, pseudonymous
dSFMT.x86_64: W: shared-lib-calls-exit /usr/lib64/libdSFMT.so.2.2.3
exit@GLIBC_2.2.5
Show me a fixed spec and I'll finish a formal review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister
https://bugzilla.redhat.com/show_bug.cgi?id=1108765 Milan Bouchet-Valat changed: What|Removed |Added Blocks||1040517 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1040517 [Bug 1040517] Review Request: julia - High-level, high-performance dynamic language for technical computing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
