[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Fedora Update System changed: What|Removed |Added Fixed In Version|liblbfgs-1.10-3.el7 |liblbfgs-1.10-3.el6 --- Comment #22 from Fedora Update System --- liblbfgs-1.10-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Fedora Update System changed: What|Removed |Added Fixed In Version|liblbfgs-1.10-3.fc20|liblbfgs-1.10-3.el7 --- Comment #21 from Fedora Update System --- liblbfgs-1.10-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #20 from Fedora Update System --- liblbfgs-1.10-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/liblbfgs-1.10-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #19 from Fedora Update System --- liblbfgs-1.10-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/liblbfgs-1.10-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||liblbfgs-1.10-3.fc20 Resolution|--- |ERRATA Last Closed||2014-06-30 19:26:50 --- Comment #18 from Fedora Update System --- liblbfgs-1.10-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- liblbfgs-1.10-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #16 from Fedora Update System --- liblbfgs-1.10-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/liblbfgs-1.10-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #15 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Sandro Mani changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Sandro Mani --- Yeah, looks like mmg3d is the last missing piece, and possibly also a reworked freefem++ package might be nice to avoid the bundling issue. Will also look into that ;) Thanks for the review! New Package SCM Request === Package Name: liblbfgs Short Description: Limited-memory Broyden-Fletcher-Goldfarb-Shanno library Owners: smani Branches: f20 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Mukundan Ragavan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #13 from Mukundan Ragavan --- Very nice. Package APPROVED. Looks like everything for gmsh is nicely falling into place. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #12 from Sandro Mani --- Spec URL: http://smani.fedorapeople.org/review/liblbfgs.spec SRPM URL: http://smani.fedorapeople.org/review/liblbfgs-1.10-3.fc21.src.rpm %changelog * Fri Jun 20 2014 Sandro Mani - 1.10-3 - Add -Wl,--as-needed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #11 from Mukundan Ragavan --- * Patch looks fine and fixes the indicated issues. * Package builds fine - http://koji.fedoraproject.org/koji/taskinfo?taskID=7060213 ** Only one remaining issue - The rpmlint warning could also be fixed - http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491
--- Comment #10 from Sandro Mani ---
Spec URL: http://smani.fedorapeople.org/review/liblbfgs.spec
SRPM URL: http://smani.fedorapeople.org/review/liblbfgs-1.10-2.fc21.src.rpm
%changelog
* Fri Jun 20 2014 Sandro Mani - 1.10-2
- $RPM_BUILD_ROOT -> %%{buildroot}
- Add liblbfgs_build.patch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #9 from Mukundan Ragavan --- Forgot to add this - Koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=7060156 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #8 from Mukundan Ragavan --- (In reply to Sandro Mani from comment #7) > Guess it would probably best to just use the conventional so versioning. That might avoid any confusions I think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491
--- Comment #7 from Sandro Mani ---
I'm not sure what the policy regarding the kind of shared library versioning
used here is... basically we have
%{_libdir}/liblbfgs-1.10.so
and
%{_libdir}/liblbfgs.so -> %{_libdir}/liblbfgs-1.10.so
Guess it would probably best to just use the conventional so versioning.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491
--- Comment #6 from Mukundan Ragavan ---
The -O3 is defined here, as far as I can tell -
dnl --
dnl Checks for debugging mode
dnl --
AC_ARG_ENABLE(
debug,
[AS_HELP_STRING(
[--enable-debug],
[build for debugging]
)],
[CFLAGS="-DDEBUG -O -g ${CFLAGS}"],
[CFLAGS="-O3 -ffast-math ${CFLAGS}"]
)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Mukundan Ragavan changed: What|Removed |Added Blocks|753577 |388 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=753577 [Bug 753577] Review Request: gmsh - finite element grid generator https://bugzilla.redhat.com/show_bug.cgi?id=388 [Bug 388] Review Request: gmsh - A three-dimensional finite element mesh generator -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #5 from Mukundan Ragavan --- Mid air collission -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491
Mukundan Ragavan changed:
What|Removed |Added
Blocks|388 |
--- Comment #4 from Mukundan Ragavan ---
There are a few issues to be taken care of here -
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
---> Please use one style consistently.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[?]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
> ??
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown
license. Detailed output of licensecheck in
/home/mukundan/personal/pkgs/reviews/1109491-liblbfgs/licensecheck.txt
---> This is fine.
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
I see -O3 being used
/bin/sh ../libtool --mode=compile --tag=CC gcc -DHAVE_CONFIG_H -I. -I. -I..
-I.. -I../include -O3 -ffast-math -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -Wall -O3
-ffast-math -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -m64 -mtune=generic -Wall -c -o lbfgs.lo lbfgs.c
mkdir .libs
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I../include -O3 -ffast-math -O2 -g
-pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64
-mtune=generic -Wall -O3 -ffast-math -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -Wall -c
lbfgs.c -fPIC -DPIC -o .libs/lbfgs.o
and others
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[?]: Development files must be in a -devel package.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{bui
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Sandro Mani changed: What|Removed |Added Blocks||388 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=388 [Bug 388] Review Request: gmsh - A three-dimensional finite element mesh generator -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #3 from Sandro Mani --- I'd say go for it. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 --- Comment #2 from Mukundan Ragavan --- Should I review this now or should we wait for a couple of more days? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Mukundan Ragavan changed: What|Removed |Added CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #1 from Mukundan Ragavan --- Taking this for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109491] Review Request: liblbfgs - Limited-memory Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491 Sandro Mani changed: What|Removed |Added Blocks||753577 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=753577 [Bug 753577] Review Request: gmsh - finite element grid generator -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
