[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Nathaniel McCallum nathan...@natemccallum.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Nathaniel McCallum nathan...@natemccallum.com --- Package Change Request == Package Name: python-yubico New Branches: f20 Owners: npmccallum -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #15 from Dennis Gilmore den...@ausil.us --- (In reply to Nathaniel McCallum from comment #12) Strangely, I don't see the fedora-cvs flag. Anyone know how to set it? if you don't see them your not in the right groups and can not review and approve packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #16 from Nathaniel McCallum nathan...@natemccallum.com --- Dennis, that issue was resolved. I am just needing a new branch now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #17 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Nathaniel McCallum nathan...@natemccallum.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-06-23 13:17:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #13 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334
--- Comment #8 from Christopher Meng i...@cicku.me ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (2 clause), Unknown or generated. 17 files have unknown license.
Detailed output of licensecheck:
BSD (2 clause)
--
python-yubico-python-yubico-1.2.1/release.py
Unknown or generated
python-yubico-python-yubico-1.2.1/doc/ykdef.h
python-yubico-python-yubico-1.2.1/setup.py
python-yubico-python-yubico-1.2.1/test/run.sh
python-yubico-python-yubico-1.2.1/test/test_yubico.py
python-yubico-python-yubico-1.2.1/test/test_yubikey_config.py
python-yubico-python-yubico-1.2.1/test/test_yubikey_frame.py
python-yubico-python-yubico-1.2.1/test/test_yubikey_usb_hid.py
python-yubico-python-yubico-1.2.1/yubico/__init__.py
python-yubico-python-yubico-1.2.1/yubico/yubico_exception.py
python-yubico-python-yubico-1.2.1/yubico/yubico_util.py
python-yubico-python-yubico-1.2.1/yubico/yubikey.py
python-yubico-python-yubico-1.2.1/yubico/yubikey_config.py
python-yubico-python-yubico-1.2.1/yubico/yubikey_config_util.py
python-yubico-python-yubico-1.2.1/yubico/yubikey_defs.py
python-yubico-python-yubico-1.2.1/yubico/yubikey_frame.py
python-yubico-python-yubico-1.2.1/yubico/yubikey_neo_usb_hid.py
python-yubico-python-yubico-1.2.1/yubico/yubikey_usb_hid.py
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]:
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #9 from Nathaniel McCallum npmccal...@redhat.com --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Christopher Meng i...@cicku.me --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #11 from Nathaniel McCallum npmccal...@redhat.com --- New Package SCM Request === Package Name: python-yubico Short Description: Pure-python library for interacting with Yubikeys Upstream URL: https://github.com/Yubico/python-yubico Owners: npmccallum Branches: f21 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #12 from Nathaniel McCallum npmccal...@redhat.com --- Strangely, I don't see the fedora-cvs flag. Anyone know how to set it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Nathaniel McCallum nathan...@natemccallum.com changed: What|Removed |Added CC||nathan...@natemccallum.com Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #1 from Nathaniel McCallum npmccal...@redhat.com --- $ rpmlint ../SRPMS/python-yubico-1.2.1-1.fc21.src.rpm ../RPMS/noarch/python-yubico-1.2.1-1.fc21.noarch.rpm ./python-yubico.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me Flags||fedora-review? --- Comment #2 from Christopher Meng i...@cicku.me --- http://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #3 from Nathaniel McCallum npmccal...@redhat.com --- Fixed (but I didn't bump release for such a small change). Same URL. FYI, my erronious value is the default value of rpmdev-newspec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #4 from Christopher Meng i...@cicku.me --- Missing setuptools BR. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #5 from Nathaniel McCallum npmccal...@redhat.com --- Why is setuptools required? The package builds fine on my system and I don't have setuptools installed... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #6 from Christopher Meng i...@cicku.me --- Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.dBOArs + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf python-yubico-python-yubico-1.2.1 + /usr/bin/tar -xf - + /usr/bin/gzip -dc /builddir/build/SOURCES/python-yubico-1.2.1.tar.gz + STATUS=0 + '[' 0 -ne 0 ']' + cd python-yubico-python-yubico-1.2.1 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.nAeT4H + umask 022 + cd /builddir/build/BUILD + cd python-yubico-python-yubico-1.2.1 + /usr/bin/python2 setup.py build Traceback (most recent call last): File setup.py, line 3, in module from setuptools import setup ImportError: No module named setuptools error: Bad exit status from /var/tmp/rpm-tmp.nAeT4H (%build) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111334] Review Request: python-yubico - Pure-python library for interacting with Yubikeys
https://bugzilla.redhat.com/show_bug.cgi?id=334 --- Comment #7 from Nathaniel McCallum npmccal...@redhat.com --- Argh! I did have it installed after all... Sorry! Fixed. Same URL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
