[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-08-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version||gmsh-2.8.5-2.fc20
 Resolution|RAWHIDE |ERRATA



--- Comment #22 from Fedora Update System  ---
gmsh-2.8.5-2.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #21 from Fedora Update System  ---
gmsh-2.8.5-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gmsh-2.8.5-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-07-23 16:39:59



--- Comment #20 from Sandro Mani  ---
Built for rawhide and F21, rest pending due to scotch issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #19 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #18 from Sandro Mani  ---
Oh, forgot that there is now f21...

Package Change Request
==
Package Name: gmsh
New Branches: f21
Owners: smani
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #17 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #16 from Sandro Mani  ---
Many thanks for the review!

New Package SCM Request
===
Package Name: gmsh
Short Description: A three-dimensional finite element mesh generator
Owners: smani
Branches: f20 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Mukundan Ragavan  ---
(In reply to Sandro Mani from comment #14)
> >  Is it a legal issue to even download the tarball and then get rid of mpeg 
> > in %prep instead of manual creation of the tarball?
> 
> See
> http://fedoraproject.org/wiki/Packaging:
> SourceURL#When_Upstream_uses_Prohibited_Code
> 

I should not have asked this question based on my memory! :(

> 
> Spec URL: http://smani.fedorapeople.org/review/gmsh.spec
> SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-4.fc22.src.rpm
> 
> %changelog
> * Tue Jul 22 2014 Sandro Mani  - 2.8.4-4
> - Rename gmsh-demos to gmsh-doc
> - Fix scriptlets for gmsh-common
> - Install license file with *-libs subpackages

Others are fine. I have no further issues. Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #14 from Sandro Mani  ---
>  Is it a legal issue to even download the tarball and then get rid of mpeg in 
> %prep instead of manual creation of the tarball?

See
http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code


Rpmlint: The output of the build below should be as follows:
> gmsh.src: W: patch-not-applied PatchX: [...]
False positive (autosetup)
> gmsh.src: W: invalid-url Source0: gmsh-2.8.4-source-fedora.tar.gz
As documented

> gmsh.x86_64: W: no-documentation
non-issue, docs are in -common which gets pulled in
> gmsh.x86_64: W: no-manual-page-for-binary gmsh
non-issue, manpage is in -common which gets pulled in

> gmsh-common.noarch: W: desktopfile-without-binary 
> /usr/share/applications/gmsh.desktop gmsh
The desktop file is common to all gmsh executables, to which gmsh executable it
points to depends on the environment (i.e. if an mpi env is loaded)

> gmsh-libs.x86_64: W: unused-direct-shlib-dependency [...]
Adding -Wl,--as-needed removed one of these, but not the others. Should not be
a blocker though.
> gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 
> exit@GLIBC_2.2.5
Needs to be considered upstream

> gmsh-devel.x86_64: W: only-non-binary-in-usr-lib
False positive (lib is a symlink)
> gmsh-devel.x86_64: W: no-documentation
License is in -libs, which is a dependency
> gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against 
> openmpi
Non-issue

-> Same for gmsh-openmpi* and gmsh-mpich*



Spec URL: http://smani.fedorapeople.org/review/gmsh.spec
SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-4.fc22.src.rpm

%changelog
* Tue Jul 22 2014 Sandro Mani  - 2.8.4-4
- Rename gmsh-demos to gmsh-doc
- Fix scriptlets for gmsh-common
- Install license file with *-libs subpackages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #13 from Mukundan Ragavan  ---
Alright. I have one question - 

[?]: SourceX tarball generation or download is documented.
 Note: Package contains tarball without URL, check comments

---> Generation of tarball is documented sure. Is it a legal issue to even
download the tarball and then get rid of mpeg in %prep instead of manual
creation of the tarball?


* There are lot of rpmlint errors but I am not sure how many of those can be
addressed. Most of the potential "solutions" are already incorporated in the
spec file (Would prefer to check again).


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in gmsh-common
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 1392640 bytes in 64 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "GPL", "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "LGPL (with incorrect FSF address)",
 "LGPL (v2.1 or later)", "*No copyright* LGPL (v2.1 or later)", "GPL
 (v2)", "BSD (3 clause) LGPL (v2.1 or later)". 1480 files have unknown
 license. Detailed output of licensecheck in
 /home/mukundan/personal/pkgs/reviews/gmsh/388-gmsh/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/gmsh
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/gmsh
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
 file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #12 from Sandro Mani  ---
Ah, copy paste issue >.< (forgot f21 -> f22), sorry. No worries for the delay.

Spec URL: http://smani.fedorapeople.org/review/gmsh.spec
SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-3.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #11 from Mukundan Ragavan  ---
Sandro, 404 on the source rpm. :( Have you already uploaded the src.rpm?

Also, Sorry for the delay - had to take care of something.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388
Bug 388 depends on bug 1109490, which changed state.

Bug 1109490 Summary: Review Request: alglib - A numerical analysis and data 
processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #10 from Sandro Mani  ---
@Christopher:
cgnslib BR added
fftw: see [1] "the FourierModel library is not publicly available."

[1] http://geuz.org/pipermail/gmsh/2009/004007.html

@Mukundan: All relevant rpmlint (fixable) rpmlint issues fixed. These

gmsh.x86_64: W: no-documentation
gmsh.x86_64: W: no-manual-page-for-binary gmsh
gmsh-common.noarch: W: desktopfile-without-binary
/usr/share/applications/gmsh.desktop gmsh
gmsh-devel.x86_64: W: only-non-binary-in-usr-lib
gmsh-devel.x86_64: W: no-documentation
gmsh-libs.x86_64: W: no-documentation
[etc for -openmpi, -mpich]

are non-issues (documentation gets pulled in via dependencies, desktop file is
common for all binaries, only-non-binary-in-usr-lib is probably because %lib
contains only a symlink to the so).

gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4
exit@GLIBC_2.2.5

needs to be considered upstream.

Some unused-direct-shlib-dependency remain despite -Wl,--as-needed.


Spec URL: http://smani.fedorapeople.org/review/gmsh.spec
SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-3.fc21.src.rpm

%changelog
* Thu Jul 17 2014 Sandro Mani  - 2.8.4-3
- Fix encoding of file tutorial/t12.geo
- Fix line endings of demos/component8.step
- Fix incorrect changelog
- Add -Wl,--as-needed
- Add BRs: cgnslib-devel med-devel
- Pass -DENABLE_CGNS=YES -DENABLE_MED=YES to cmake
- Install onelab.py in %%{python2_sitelib}
- Add missing Requires: gmsh-common

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #9 from Christopher Meng  ---
I haven't seen:

fftw
cgnslib.

Sandro, comment?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #8 from Mukundan Ragavan  ---
(In reply to Christopher Meng from comment #7)
> Well, if so many rpmlints are considered as good, I have no idea...

Well, saying "good" is not a certification in any sense.

As far as I am concerned, package is good because

* it builds succesfully
* it does not bundle libraries
* spec is easy to follow
and so on.

Clearly the package is not approved and the packager is certainly going to work
towards addressing the issues.

I do not understand what your issue is here considering this is an ongoing
review process. Perhaps, you have noticed something that I am not at all seeing
(which I would not be surprised since this is a learning process for me)? 

I think it would be very helpful (speaking for myself) if you could clarify
what you are trying to convey by your comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #7 from Christopher Meng  ---
Well, if so many rpmlints are considered as good, I have no idea...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #6 from Mukundan Ragavan  ---
This is pending completion of the koji scratch build.

[ ]: Package should compile and build into binary rpms on all supported
 architectures.

---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7154865

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #5 from Mukundan Ragavan  ---
The package mostly looks good. I have a few questions (below).

Also, some of the rpmlint warnings are easy fixes, unused-shlib warnings, may
be ...

Please do take a look. I think it should be done next round. cheers!


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in gmsh-common
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 1392640 bytes in 64 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "GPL", "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "LGPL (with incorrect FSF address)",
 "LGPL (v2.1 or later)", "*No copyright* LGPL (v2.1 or later)", "GPL
 (v2)", "BSD (3 clause) LGPL (v2.1 or later)". 1480 files have unknown
 license. Detailed output of licensecheck in
 /home/mukundan/personal/pkgs/reviews/388-gmsh/licensecheck.txt

---> This looks fine to me. The files I checked refer to license.txt which is
GPL2.

[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/gmsh

---> Please verify - just to be sure.

[?]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/gmsh
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
 file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: S

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #4 from Mukundan Ragavan  ---
Oh yes. I did forget about this. Will review tonight.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388



--- Comment #3 from Sandro Mani  ---
Just a note: all dependencies for this are now built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388
Bug 388 depends on bug 1109444, which changed state.

Bug 1109444 Summary: Review Request: mmg3d - Anisotropic Tetrahedral Remesher / 
Moving Mesh Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1109444

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388
Bug 388 depends on bug 483663, which changed state.

Bug 483663 Summary: Review Request: tetgen - A tetrahedral mesh generator
https://bugzilla.redhat.com/show_bug.cgi?id=483663

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388
Bug 388 depends on bug 1109491, which changed state.

Bug 1109491 Summary: Review Request: liblbfgs - Limited-memory 
Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388
Bug 388 depends on bug 1110945, which changed state.

Bug 1110945 Summary: Review Request: voro++ - Library for 3D computations of 
the Voronoi tessellation
https://bugzilla.redhat.com/show_bug.cgi?id=1110945

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388
Bug 388 depends on bug 1109496, which changed state.

Bug 1109496 Summary: Review Request: mathex - C++ library to parse/evaluate 
mathematical expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1109496

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Blocks|483663  |
 Depends On||483663




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=483663
[Bug 483663] Review Request: tetgen - A tetrahedral mesh generator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

 Blocks||483663




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=483663
[Bug 483663] Review Request: tetgen - A tetrahedral mesh generator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Mukundan Ragavan  changed:

   What|Removed |Added

 Depends On||1109491




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1109491
[Bug 1109491] Review Request: liblbfgs - Limited-memory
Broyden-Fletcher-Goldfarb-Shanno library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Mukundan Ragavan  changed:

   What|Removed |Added

 Depends On|1109491 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1109491
[Bug 1109491] Review Request: liblbfgs - Limited-memory
Broyden-Fletcher-Goldfarb-Shanno library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

 Depends On||1109444, 1109490, 1109491,
   ||1109496, 1110945




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1109444
[Bug 1109444] Review Request: mmg3d - Anisotropic Tetrahedral Remesher /
Moving Mesh Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1109490
[Bug 1109490] Review Request: alglib - A numerical analysis and data
processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1109491
[Bug 1109491] Review Request: liblbfgs - Limited-memory
Broyden-Fletcher-Goldfarb-Shanno library
https://bugzilla.redhat.com/show_bug.cgi?id=1109496
[Bug 1109496] Review Request: mathex - C++ library to parse/evaluate
mathematical expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1110945
[Bug 1110945] Review Request: voro++ - Library for 3D computations of the
Voronoi tessellation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR),|
   |182235 (FE-Legal)   |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Sandro Mani  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR),
   ||182235 (FE-Legal)
 CC||vasyu...@gmail.com



--- Comment #2 from Sandro Mani  ---
*** Bug 753577 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111388] Review Request: gmsh - A three-dimensional finite element mesh generator

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=388

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||nonamed...@gmail.com
   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Mukundan Ragavan  ---
Taken.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review