[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 --- Comment #16 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Ken Dreyer changed: What|Removed |Added Status|ON_QA |CLOSED CC||ktdre...@ktdreyer.com Resolution|--- |CURRENTRELEASE Flags|fedora-cvs+ |fedora-cvs? Last Closed||2014-12-11 12:36:21 --- Comment #15 from Ken Dreyer --- Package Change Request == Package Name: python-remoto New Branches: f19 f20 el6 epel7 Owners: ktdreyer fsimonce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Federico Simoncelli changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #14 from Federico Simoncelli --- First build here: http://koji.fedoraproject.org/koji/buildinfo?buildID=542616 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Christopher Meng --- Wrong flag cleared. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Richard W.M. Jones changed: What|Removed |Added Flags||fedora-review+ --- Comment #11 from Richard W.M. Jones --- Fixing the flags. I should have set fedora-review + when I approved the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 --- Comment #10 from Federico Simoncelli --- New Package SCM Request === Package Name: python-remoto Short Description: Execute remote commands or processes Upstream URL: http://github.com/alfredodeza/remoto Owners: fsimonce Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Federico Simoncelli changed: What|Removed |Added Blocks||1115299 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1115299 [Bug 1115299] Review Request: ceph-deploy - Admin and deploy tool for Ceph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 --- Comment #9 from Federico Simoncelli --- Updated spec/srpm: Spec URL: http://fsimonce.fedorapeople.org//python-remoto.spec SRPM URL: http://fsimonce.fedorapeople.org//python-remoto-0.0.17-2.fc21.src.rpm Description: Execute remote commands or processes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Richard W.M. Jones changed: What|Removed |Added Flags|needinfo?(rjo...@redhat.com |fedora-cvs+ |) | --- Comment #8 from Richard W.M. Jones --- With the additional changes (comment 7), this package now meets the Fedora packaging guidelines. Therefore: APPROVED by rjones -- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916
Federico Simoncelli changed:
What|Removed |Added
Flags||needinfo?(rjo...@redhat.com
||)
--- Comment #7 from Federico Simoncelli ---
Are these changes enough?
--- python-remoto.spec.12014-06-27 10:29:19.0 +0200
+++ python-remoto.spec.22014-06-27 12:46:08.521116160 +0200
@@ -4,14 +4,14 @@
Name: python-%{pkgname}
Version:0.0.17
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Execute remote commands or processes
-Group: Development/Libraries
License:MIT
URL:http://github.com/alfredodeza/remoto
+
+# http://github.com/alfredodeza/%{pkgname}/archive/%{version}.tar.gz
Source0:%{pkgname}-%{version}.tar.xz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
BuildRequires: python-devel
@@ -32,20 +32,17 @@
%install
-rm -rf $RPM_BUILD_ROOT
REMOTO_NO_VENDOR=1 %{__python} setup.py install -O1 --skip-build --root
$RPM_BUILD_ROOT
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
%files
-%defattr(-,root,root,-)
%doc LICENSE README.rst
%{python_sitelib}/*
%changelog
+* Fri Jun 27 2014 Federico Simoncelli 0.0.17-2
+- specfile cleanups
+
* Sun Jun 22 2014 Federico Simoncelli 0.0.17-1
- initial build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916
--- Comment #6 from Richard W.M. Jones ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 15 files have unknown license. Detailed output of
licensecheck in /home/rjones/1113916-python-remoto/licensecheck.txt
Could get upstream to add licenses to the individual source files,
but the LICENSE file at the top level is pretty clear about the
intended license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: Buildroot is not present
Note: Buildroot: present but not needed
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
See comment 4
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all suppo
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 --- Comment #5 from Richard W.M. Jones --- As a stylistic note (not required to be fixed), you can remove all of the following lines from the spec file: - Group: - BuildRoot: - The `rm -rf $RPM_BUILD_ROOT' in %install - The entire %clean section - %defattr(-,root,root,-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 --- Comment #4 from Richard W.M. Jones --- rpmlint on Rawhide: python-remoto.src: W: invalid-url Source0: remoto-0.0.17.tar.xz 2 packages and 0 specfiles checked; 0 errors, 1 warnings. The Source0 URL is wrong. It should be something like: Source0: https://github.com/alfredodeza/remoto/archive/0.0.17.tar.gz (See: https://github.com/alfredodeza/remoto/releases) If that is not possible, then you should have a comment in the spec file explaining briefly how to get/make the source tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 Richard W.M. Jones changed: What|Removed |Added CC||rjo...@redhat.com Assignee|nob...@fedoraproject.org|rjo...@redhat.com --- Comment #3 from Richard W.M. Jones --- Taking for review ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916
--- Comment #2 from Federico Simoncelli ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 15 files have unknown license. Detailed output of
licensecheck in /home/simon/pkg/python-remoto/1113916-python-
remoto/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Python:
[x]: Binary eggs must be removed in %prep
Note: Test run failed
[x]: Python eggs must not download any dependencies during the build process.
Note: Test run failed
[x]: A package which is used by another package via an egg interface should
provide egg info.
Note: Test run failed
[x]: Package meets the Packaging Guidelines::Python
Note: Test run failed
= SHOULD items =
Generic:
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should
[Bug 1113916] Review Request: python-remoto - Execute remote commands or processes
https://bugzilla.redhat.com/show_bug.cgi?id=1113916 --- Comment #1 from Federico Simoncelli --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7082207 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
