[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-banner-0.2.3-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-banner-0.2.3-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-banner-0.2.3-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-banner-0.2.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-grunt-banner-0.2.3-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-banner-0.2.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-grunt-banner-0.2.3-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-grunt-banner-0.2.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-grunt-banner-0.2.3-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-10-24 09:39:37 --- Comment #11 from Ralph Bean rb...@redhat.com --- Built and buildroot overrides submitted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #4 from Ralph Bean rb...@redhat.com --- Here's a release that adds the noarch declaration, but it doesn't yet try to take on the tests and it leaves the npm module requirements in place. Spec URL: http://threebean.org/rpm/SPECS/nodejs-grunt-banner.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-grunt-banner-0.2.3-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Tom Hughes t...@compton.nu --- With the noarch fixed this can be approved. I'll leave the other things to your discretion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: nodejs-grunt-banner Short Description: Adds a simple banner to files Upstream URL: https://npmjs.org/package/grunt-banner Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes t...@compton.nu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/tom/1115669-nodejs-grunt-banner/licensecheck.txt
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #2 from Tom Hughes t...@compton.nu --- Couple of things: * This should build as noarch * You may want to package from github (or pull in the tests as a separate source) so that the tests can be run -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 --- Comment #3 from Tom Hughes t...@compton.nu --- Oh, and there is no need to add requires for npm modules to the spec - they will be added automatically. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 T.C. Hollingsworth tchollingswo...@gmail.com changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115669] Review Request: nodejs-grunt-banner - Adds a simple banner to files
https://bugzilla.redhat.com/show_bug.cgi?id=1115669 Ralph Bean rb...@redhat.com changed: What|Removed |Added Blocks||1115659 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1115659 [Bug 1115659] Review Request: bootstrap - A front-end framework for developing projects on the web -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
