[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Mikolaj Izdebski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-07-15 04:52:53 --- Comment #15 from Mikolaj Izdebski --- Built for rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=542903 Closing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 --- Comment #14 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Christopher Tubbs changed: What|Removed |Added Blocks||1010003 (bigdata-review) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1010003 [Bug 1010003] bigdata-sig review-tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Christopher Tubbs changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Christopher Tubbs --- New Package SCM Request === Package Name: accumulo Short Description: A software platform for processing vast amounts of data Upstream URL: http://accumulo.apache.org Owners: ctubbsii mizdebsk Branches: f20 f21 epel7 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Mikolaj Izdebski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Mikolaj Izdebski --- All issues have been resolved. Package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 --- Comment #11 from Christopher Tubbs --- (In reply to Mikolaj Izdebski from comment #10) I uploaded updated spec and srpm to same location with the changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077
--- Comment #10 from Mikolaj Izdebski ---
Package Review
==
Legend:
[x] = Pass, [-] = Not applicable
Issues:
===
- Package must own all directories that it creates.
Directories without owner:
/usr/share/maven-poms/accumulo (should be owned by core)
/usr/lib/java/accumulo (should be owned by tserver)
- These BR are not needed: make gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Scriplets calling ldconfig should be removed because the installed .so
file is not in default linker searth path
- Description lines must be limited to 80 characters, see rpmlint output
below (there is one lite that is too long)
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Permissions on files are set properly.
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds i
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 --- Comment #9 from Christopher Tubbs --- (In reply to Mikolaj Izdebski from comment #8) I've updated the SPEC and SRPM linked above to address the above issues. I disabled the optional monitor module for now, until the flot/jquery libraries can be addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 --- Comment #8 from Mikolaj Izdebski --- I did partial review, the problems I found so far are below. I will continue the review once these problems are fixed. 1) Invalid license tags for some subpackages. If unspecified, license tags are inherited from the previous package, so they need to be explicitly reset in a few packages. 2) Prebuilt bundled binaries in server/monitor/src/main/resources/web. There are 2 problems with some code in the above location: * Bundled libraries are not allowed in Fedora. Bundled files must be removed and packaged separately. * Prebuilt binaries are not allowed in Fedora - everything must be built from source. Obfuscated or "minified" code is not "real" source code in terms of neither The Free Software Definition [1] nor The Open Source Definition [2]. Prebuild code must not be installed. 3) accumulo-native should respect Fedora default compiler flags ($RPM_OPT_FLAGS and $RPM_LD_FLAGS). 4) IMO fedora-integration.patch should be split into separate parts for better readability (one for different version of commons-math, one for skipping some tests and so on), but this is not a blocker. 5) Reason for skipping tests should be documented. Also, some tests are skipped with a patch, which seems redundant. 6) Config files should probably be marked as %config(noreplace) to prevent RPM from overwriting user config during update. [1] http://www.gnu.org/philosophy/free-sw.html [2] http://opensource.org/osd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Mikolaj Izdebski changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Christopher Tubbs changed: What|Removed |Added Whiteboard|NotReady| --- Comment #7 from Christopher Tubbs --- Okay, I'm removing NotReady for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117077] Review Request: accumulo - A software platform for processing vast amounts of data
https://bugzilla.redhat.com/show_bug.cgi?id=1117077 Mikolaj Izdebski changed: What|Removed |Added Summary|Review Request: accumulo - |Review Request: accumulo - |1.6.0 packaging |A software platform for ||processing vast amounts of ||data --- Comment #6 from Mikolaj Izdebski --- (In reply to Christopher Tubbs from comment #5) > (In reply to Christopher Meng from comment #1) > > What is "1.6.0 packaging"? > > Sorry for the confusing subject. I was trying to find an appropriate > description for the subject and couldn't think of a better one. I just meant > that this package is from the upstream version 1.6.0. Fixed. The subject was supposed to match package summary (aka short description). Let me know when the package is ready for review. It doesn't need to be perfect, I'll go through it and point any blocker problems and add some suggestions if needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
