[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sscep-0.5.0-6.20140820git56 ||69006.fc20 Resolution|--- |ERRATA Last Closed||2014-10-28 02:43:40 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- sscep-0.5.0-6.20140820git5669006.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|sscep-0.5.0-6.20140820git56 |sscep-0.5.0-6.20140820git56 |69006.fc20 |69006.el6 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- sscep-0.5.0-6.20140820git5669006.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- sscep-0.5.0-6.20140820git5669006.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- sscep-0.5.0-6.20140820git5669006.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/sscep-0.5.0-6.20140820git5669006.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- sscep-0.5.0-6.20140820git5669006.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sscep-0.5.0-6.20140820git5669006.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #29 from Jon Ciesla limburg...@gmail.com --- Please use your FAS account name, not your real name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Thorsten Scherf tsch...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #30 from Thorsten Scherf tsch...@redhat.com --- New Package SCM Request === Package Name: sscep Short Description: Simple SCEP client with modifications for engine support more Upstream URL: https://github.com/certnanny/sscep Owners: tscherf Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #31 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209
--- Comment #19 from Thorsten Scherf tsch...@redhat.com ---
1. SourceURL MUST be fixed
Source: %{name}.tar.gz
Has been fixed.
2. $RPM_OPT_FLAGS MUST be used (or rationale given why not),
Has been fixed.
3. SHOULD drop unused
BuildRequires: automake
Requirement removed.
4. SHOULD use 'install -p' flag to preserve timestamps
Has been fixed.
5. COPYRIGHT file mentions a bunch of different licenses, none of which is GPL
the source files themselves only say See the file COPYRIGHT for licensing
information. ugh, without clarification, we may have to conclude *all*
mentioned licenses apply, including: BSD, OpenSSL, and 2 others not mentioned
in
https://fedoraproject.org/wiki/Licensing
SSLeay and OpenOSP, may need to ask fedora legal mailing list for help here,
https://admin.fedoraproject.org/mailman/listinfo/legal
(Do you want to, or would you rather I do it?)
Go ahead. Thanks.
the OpenSDP variant looks close to BSD with attribution variant. so, maybe
we can go with that for now, and use:
5. License: (BSD with attribution) and OpenSSL
License has been replaced.
Find the new package and spec here:
http://people.redhat.com/tscherf/fedora/rpms/sscep-0.5.0-3.fc20.src.rpm
http://people.redhat.com/tscherf/fedora/rpms/sscep.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #20 from Rex Dieter rdie...@math.unl.edu --- SourceURL seems not correct yet. spectool -g *.spec Getting https://github.com/certnanny/sscep/b914f33fdb6479c9d87d4cab6edce0b0e06a370c/sscep-b914f33fdb6479c9d87d4cab6edce0b0e06a370c.tar.gz to ./sscep-b914f33fdb6479c9d87d4cab6edce0b0e06a370c.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209
--- Comment #21 from Rex Dieter rdie...@math.unl.edu ---
One other suggestion:
6. SHOULD handle docs with %doc macro instead of
%install
...
install -pm 644 COPYRIGHT HISTORY TODO README draft-nourse-scep-06.txt
draft-nourse-scep-11.txt %{buildroot}%{_defaultdocdir}/%{name}
and
%files
%doc %{_defaultdocdir}/%{name}/
do this instead:
%files
%doc COPYRIGHT HISTORY TODO README draft-nourse-scep-06.txt
draft-nourse-scep-11.txt
(feel free to include multiple %doc lines if you prefer better readability)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #22 from Thorsten Scherf tsch...@redhat.com --- SourceURL seems not correct yet. SourceURL fixed. 6. SHOULD handle docs with %doc macro instead of doc tag added and install removed. http://people.redhat.com/tscherf/fedora/rpms/sscep-0.5.0-4.fc20.src.rpm http://people.redhat.com/tscherf/fedora/rpms/sscep.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #23 from Rex Dieter rdie...@math.unl.edu --- Sources: NOT ok. checksums do not match. copy inside your src.rpm: $ md5sum *.gz c732104a77335b6a32ff4ce0c236cc8f v0.5.0.tar.gz $ rm *.gz $ spectool -g *.spec Getting https://github.com/certnanny/sscep/archive/v0.5.0.tar.gz to ./v0.5.0.tar.gz % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 129k 100 129k0 0 115k 0 0:00:01 0:00:01 --:--:-- 3086k $ md5sum *.gz ecb381f180ce09b8d4f550a6cc9d2006 v0.5.0.tar.gz Please verify. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #24 from Thorsten Scherf tsch...@redhat.com --- Added github archive as SourceURL: http://people.redhat.com/tscherf/fedora/rpms/sscep-0.5.0-5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209
--- Comment #25 from Rex Dieter rdie...@math.unl.edu ---
Sources: OK
md5sum verified:
44a60e9867949de06b7add230cb946ce
sscep-56690068c795a1c8a4616c98814cf3244ad6cb91.tar.gz
But now we need to adjust Version/Release to account for this being a snapshot
build, see:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
where you'll likely want to use the %{short_commit} macro
referenced on:
https://fedoraproject.org/wiki/Packaging:SourceURL#Github
and use something like:
Release: 6.20140820git%{short_commit}%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #26 from Thorsten Scherf tsch...@redhat.com --- snapshot based release tag added. http://people.redhat.com/tscherf/fedora/rpms/sscep-0.5.0-6.20140820git5669006.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #27 from Rex Dieter rdie...@math.unl.edu --- $ rpmlint *.src */*.rpm (none): E: no installed packages by name *.src sscep.x86_64: W: no-manual-page-for-binary sscep sscep.x86_64: W: no-manual-page-for-binary mkrequest 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Looks good now, thanks. APPROVED (and sponsored). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #28 from Thorsten Scherf tsch...@redhat.com --- New Package SCM Request === Package Name: sscep Short Description: Simple SCEP client with modifications for engine support more Upstream URL: https://github.com/certnanny/sscep Owners: Thorsten Scherf Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Thorsten Scherf tsch...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com --- Comment #12 from Parag AN(पराग) panem...@gmail.com --- Thorsten, If you are in need of sponsorship then have you reviewed any other packages un-officially? Sponsorer need to know how many packages you have un-officially reviewed and the quality of those reviews like you have suggested correctly for the issues you found in those reviews. Also, I have not seen every time you made a change you posted new links of SPEC and SRPM. Please follow the packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #13 from Parag AN(पराग) panem...@gmail.com --- Ah you did update the package once. I missed that comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #14 from Rex Dieter rdie...@math.unl.edu --- I'll take another closer look shortly... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209
--- Comment #15 from Rex Dieter rdie...@math.unl.edu ---
Initially,
1. SourceURL MUST be fixed
Source: %{name}.tar.gz
MUST be a full URL, or instructions provided on how to reproducibly create the
source tarball, see also:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #16 from Rex Dieter rdie...@math.unl.edu --- and trying an initial build, I see ... gcc -Wall -O-c -o sscep.o sscep.c ... 2. $RPM_OPT_FLAGS MUST be used (or rationale given why not), https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #17 from Rex Dieter rdie...@math.unl.edu --- 3. SHOULD drop unused BuildRequires: automake I don't see this actually needed or used anywhere. If you're going to be installing stuff by hand... 4. SHOULD use 'install -p' flag to preserve timestamps Licensing: NOT ok 5. COPYRIGHT file mentions a bunch of different licenses, none of which is GPL the source files themselves only say See the file COPYRIGHT for licensing information. ugh, without clarification, we may have to conclude *all* mentioned licenses apply, including: BSD, OpenSSL, and 2 others not mentioned in https://fedoraproject.org/wiki/Licensing SSLeay and OpenOSP, may need to ask fedora legal mailing list for help here, https://admin.fedoraproject.org/mailman/listinfo/legal (Do you want to, or would you rather I do it?) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #18 from Rex Dieter rdie...@math.unl.edu --- the OpenSDP variant looks close to BSD with attribution variant. so, maybe we can go with that for now, and use: 5. License: (BSD with attribution) and OpenSSL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #5 from Thorsten Scherf tsch...@redhat.com --- Uploaded a new package: Spec URL: https://people.redhat.com/tscherf/fedora/rpms/sscep.spec SRPM URL: https://people.redhat.com/tscherf/fedora/rpms/sscep-0.5.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #6 from Rex Dieter rdie...@math.unl.edu --- fyi, https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs Every time you make changes, that is, whenever you increment the E-V-R of a package, add a changelog entry. This is important not only to have an idea about the history of a package, but also to enable users, fellow packages, and QA people to easily spot the changes that you make. I see no changelog entry for what changed between 0.5.0-1 and 0.5.0-2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #7 from Rex Dieter rdie...@math.unl.edu --- and blocking FE-NEEDSPONSOR, per https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request (I don't see you in the packagers group yet, feel free to correct me if I'm wrong) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #8 from Thorsten Scherf tsch...@redhat.com --- (In reply to Rex Dieter from comment #6) fyi, https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ Guidelines#Changelogs Every time you make changes, that is, whenever you increment the E-V-R of a package, add a changelog entry. This is important not only to have an idea about the history of a package, but also to enable users, fellow packages, and QA people to easily spot the changes that you make. I see no changelog entry for what changed between 0.5.0-1 and 0.5.0-2 Ack. I didn't add a changelog entry since it's the initial package and it was only a minor change. I think that's ok in this case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #9 from Thorsten Scherf tsch...@redhat.com --- (In reply to Rex Dieter from comment #7) and blocking FE-NEEDSPONSOR, per https://fedoraproject.org/wiki/ Join_the_package_collection_maintainers#Create_Your_Review_Request (I don't see you in the packagers group yet, feel free to correct me if I'm wrong) This is not my first package. I already owned prelude-* and the Democracy packages. I gave away ownership after some time. Don't know if the packages are still around. Anyway, setting FE-NEEDSPONSOR is fine for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #10 from Rex Dieter rdie...@math.unl.edu --- Re: comment #8 The guideline about changelogs are fairly unambiguous here. *Every* time you make changes... add a changelog entry (emphasis mine). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #11 from Thorsten Scherf tsch...@redhat.com --- (In reply to Rex Dieter from comment #10) Re: comment #8 The guideline about changelogs are fairly unambiguous here. *Every* time you make changes... add a changelog entry (emphasis mine). SPEC file has been changed and uploaded along with an updated SRPM. Last links are still valid. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #1 from Christopher Meng i...@cicku.me --- Would you like to do a review swap? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #2 from Thorsten Scherf tsch...@redhat.com --- What kind of review swap? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 Christopher Meng i...@cicku.me changed: What|Removed |Added CC||i...@cicku.me --- Comment #3 from Christopher Meng i...@cicku.me --- bug 957715. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117209] Review Request: sscep - Simple SCEP client with modifications for engine support more
https://bugzilla.redhat.com/show_bug.cgi?id=1117209 --- Comment #4 from Thorsten Scherf tsch...@redhat.com --- set it NEEDINFO for Volker Fröhlich -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
