[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-service-identity-14. ||0.0-1.fc21 Resolution|--- |ERRATA Last Closed||2015-02-12 21:24:00 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-service-identity-14.0.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-service-identity-14.0.0-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-service-identity-14.0.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-service-identity-14.0.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Matěj Cepl mc...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mc...@redhat.com --- Comment #10 from Matěj Cepl mc...@redhat.com --- Should be ASSIGNED to nobody jumps on it (like me). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 --- Comment #6 from Tom Prince tom.pri...@ualberta.net --- Any doubts from your side? No. That looks sane. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Tom Prince tom.pri...@ualberta.net changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Robert Mayr robyd...@gmail.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #7 from Robert Mayr robyd...@gmail.com --- Nice, then please go ahead. Approved! I guess you can drop FE-NEEDSPONSOR, as you're already a packager. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Tom Prince tom.pri...@ualberta.net changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Tom Prince tom.pri...@ualberta.net --- New Package SCM Request === Package Name: python-service-identity Short Description: Service identity verification for pyOpenSSL Upstream URL: https://github.com/pyca/service_identity Owners: tomprince Branches: f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 --- Comment #5 from Robert Mayr robyd...@gmail.com --- I've rebuilt the package with your SPEC to the last version, here the links and a successful koji build. Looks good to me. Spec URL: https://robyduck.fedorapeople.org/packages/SPECS/python-service-identity.spec SRPM URL: https://robyduck.fedorapeople.org/packages/SRPMS/python-service-identity-14.0.0-1.fc21.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=8703767 Any doubts from your side? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 --- Comment #4 from Robert Mayr robyd...@gmail.com --- Hi, are you still interested in packaging this? There are some other packages depending on it and they can't be fixed without it. Please update the package to the last upstream version ASAP, if not I'll close the bug according to the guidelines. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Bug 1119063 depends on bug 1119004, which changed state. Bug 1119004 Summary: Review Request: python-characteristic - Say 'yes' to types but 'no' to typing! https://bugzilla.redhat.com/show_bug.cgi?id=1119004 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Bug 1119063 depends on bug 1119056, which changed state. Bug 1119056 Summary: Review Request: python-idna - Internationalized Domain Names in Applications (IDNA) https://bugzilla.redhat.com/show_bug.cgi?id=1119056 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063
--- Comment #3 from Robert Mayr robyd...@gmail.com ---
The package is ok, but please package it with the latest version available
(14.0.0).
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 18 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3
-service-identity
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]:
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Robert Mayr robyd...@gmail.com changed: What|Removed |Added CC||robyd...@gmail.com Assignee|nob...@fedoraproject.org|robyd...@gmail.com --- Comment #2 from Robert Mayr robyd...@gmail.com --- The spec looks good to me, I will review it and hopefully approve once the dependencies python-idna and python-characteristic (both still in testing) are in stable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 --- Comment #1 from Mohammed Arafa bugzi...@in-egypt.net --- bug 1177388 is dependent on this package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Tom Prince tom.pri...@ualberta.net changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Depends On||1119004, 1119056 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1119004 [Bug 1119004] Review Request: python-characteristic - Say 'yes' to types but 'no' to typing! https://bugzilla.redhat.com/show_bug.cgi?id=1119056 [Bug 1119056] Review Request: python-idna - Internationalized Domain Names in Applications (IDNA) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119063] Review Request: python-service-identity - Service identity verification for pyOpenSSL
https://bugzilla.redhat.com/show_bug.cgi?id=1119063 Tom Prince tom.pri...@ualberta.net changed: What|Removed |Added Blocks||1119067 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1119067 [Bug 1119067] python-twisted should depend on python-service-identity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
