[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1127720 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1127720 [Bug 1127720] Review Request: perl-MooX-ConfigFromFile - Moo eXtension for initializing objects from config file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 David Dick dd...@cpan.org changed: What|Removed |Added Blocks|1127720 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1127720 [Bug 1127720] Review Request: perl-MooX-ConfigFromFile - Moo eXtension for initializing objects from config file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1128145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1128145 [Bug 1128145] Review Request: perl-MooX-HasEnv - Making attributes based on ENV variables -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Test-LoadAllModules-0. |perl-Test-LoadAllModules-0. |022-1.fc20 |022-1.el6 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- perl-Test-LoadAllModules-0.022-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Test-LoadAllModules-0. ||022-1.fc20 Resolution|--- |ERRATA Last Closed||2014-07-27 23:26:47 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-Test-LoadAllModules-0.022-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Test-LoadAllModules-0.022-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Christopher Meng i...@cicku.me --- Friendly note: perl Makefile.PL NO_PACKLIST=1 -8-- Since 6.75_01 (F21), it's possible to disable creating packlist files by passing NO_PACKLIST=1 argument to Makefile.PL. ---8 PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 David Dick dd...@cpan.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from David Dick dd...@cpan.org --- New Package SCM Request === Package Name: perl-Test-LoadAllModules Short Description: Do use_ok for modules in search path Upstream URL: http://search.cpan.org/dist/Test-LoadAllModules/ Owners: ddick Branches: el6, epel7, f20, f21 InitialCC: perl-sig Thanks Christopher! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- perl-Test-LoadAllModules-0.022-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Test-LoadAllModules-0.022-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- perl-Test-LoadAllModules-0.022-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Test-LoadAllModules-0.022-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #5 from David Dick dd...@cpan.org --- Ok, understood. I couldn't find where perl(YAML) or perl(Data::Dumper) are used. Patched and uploaded again. Spec URL: http://ddick.fedorapeople.org/packages/perl-Test-LoadAllModules.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-Test-LoadAllModules-0.022-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #3 from David Dick dd...@cpan.org --- (In reply to Christopher Meng from comment #2) -- Found some bundled libs in the inc/, idea? -- I'm not quite sure what you mean. The bundled libraries are only there for build/test purposes, as can be seen from the rpm below, none of 'inc/' libraries are included in the final rpm for distribution to users. $ rpm -qp rpmbuild/RPMS/noarch/perl-Test-LoadAllModules-0.022-1.fc20.noarch.rpm -l /usr/share/doc/perl-Test-LoadAllModules /usr/share/doc/perl-Test-LoadAllModules/Changes /usr/share/doc/perl-Test-LoadAllModules/README /usr/share/man/man3/Test::LoadAllModules.3pm.gz /usr/share/perl5/vendor_perl/Test /usr/share/perl5/vendor_perl/Test/LoadAllModules.pm Hint: Pass NO_PACKLIST=1 to make on f21 onwards will not generate the redundant packlist file. -- Okay. Thanks for that. I'll remember that for f21 only rpms. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #4 from Christopher Meng i...@cicku.me --- (In reply to David Dick from comment #3) (In reply to Christopher Meng from comment #2) -- Found some bundled libs in the inc/, idea? -- I'm not quite sure what you mean. The bundled libraries are only there for build/test purposes, as can be seen from the rpm below, none of 'inc/' libraries are included in the final rpm for distribution to users. $ rpm -qp rpmbuild/RPMS/noarch/perl-Test-LoadAllModules-0.022-1.fc20.noarch.rpm -l /usr/share/doc/perl-Test-LoadAllModules /usr/share/doc/perl-Test-LoadAllModules/Changes /usr/share/doc/perl-Test-LoadAllModules/README /usr/share/man/man3/Test::LoadAllModules.3pm.gz /usr/share/perl5/vendor_perl/Test /usr/share/perl5/vendor_perl/Test/LoadAllModules.pm No, I didn't care about the generated RPMs, it's ok. I care about the building process. If the bundled modules like Test::More must be preserved in the tarball, these BRs need to be added(some by spiffy some by the others): perl(Carp) perl(threads::shared) perl(Data::Dumper) perl(overload) perl(YAML) perl(PerlIO) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 --- Comment #1 from David Dick dd...@cpan.org --- koji builds el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7136549 rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7136551 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119243] Review Request: perl-Test-LoadAllModules - Do use_ok for modules in search path
https://bugzilla.redhat.com/show_bug.cgi?id=1119243
--- Comment #2 from Christopher Meng i...@cicku.me ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 24 files have unknown license. Detailed output of
licensecheck:
Unknown or generated
Test-LoadAllModules-0.022/inc/File/Spec.pm
Test-LoadAllModules-0.022/inc/Module/Install.pm
Test-LoadAllModules-0.022/inc/Module/Install/AuthorTests.pm
Test-LoadAllModules-0.022/inc/Module/Install/Base.pm
Test-LoadAllModules-0.022/inc/Module/Install/Can.pm
Test-LoadAllModules-0.022/inc/Module/Install/Fetch.pm
Test-LoadAllModules-0.022/inc/Module/Install/Include.pm
Test-LoadAllModules-0.022/inc/Module/Install/Makefile.pm
Test-LoadAllModules-0.022/inc/Module/Install/Metadata.pm
Test-LoadAllModules-0.022/inc/Module/Install/TestBase.pm
Test-LoadAllModules-0.022/inc/Module/Install/Win32.pm
Test-LoadAllModules-0.022/inc/Module/Install/WriteAll.pm
Test-LoadAllModules-0.022/inc/Spiffy.pm
Test-LoadAllModules-0.022/inc/Test/Base.pm
Test-LoadAllModules-0.022/inc/Test/Base/Filter.pm
Test-LoadAllModules-0.022/inc/Test/Builder.pm
Test-LoadAllModules-0.022/inc/Test/Builder/Module.pm
Test-LoadAllModules-0.022/inc/Test/More.pm
Test-LoadAllModules-0.022/lib/Test/LoadAllModules.pm
Test-LoadAllModules-0.022/t/lib/MyApp.pm
Test-LoadAllModules-0.022/t/lib/MyApp/RegExp/Test.pm
Test-LoadAllModules-0.022/t/lib/MyApp/Test.pm
Test-LoadAllModules-0.022/t/lib2/MyApp2.pm
Test-LoadAllModules-0.022/t/lib2/MyApp2/Test.pm
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/perl5/vendor_perl/Test(perl-Test-Exception, perl-Test-Harness,
perl-Test-Requires, perl-Test-Pod, perl-Test-SharedFork, perl-Test-Deep,
perl-Test-MockObject, perl-Test-Version, perl-Test-TCP, perl-SQL-
Translator, perl-CPAN-Changes, perl-Test-Fatal, perl-Test-Pod-Coverage,
perl-Test-Simple)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the
