[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||speedtest-cli-0.3.0-1.fc20 Resolution|--- |ERRATA Last Closed||2014-10-10 12:09:49 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- speedtest-cli-0.3.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- speedtest-cli-0.3.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- speedtest-cli-0.3.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/speedtest-cli-0.3.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Matías Kreder mkre...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Matías Kreder mkre...@gmail.com --- New Package SCM Request === Package Name: speedtest-cli Short Description: Command line interface for testing internet bandwidth Upstream URL: https://github.com/sivel/speedtest-cli Owners: delete Branches: f19 f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Parag AN(पराग) panem...@gmail.com --- oh. I am so sorry. I missed this review from my tracker. Thank you for reminding me. The above package looks good. APPROVED. also note we are probably moving to using python3 in F22 so ask upstream if they have/can provide python3 compatible code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 --- Comment #6 from Matías Kreder mkre...@gmail.com --- I have updated the spec file as you requested. Let me know if you have any other advice -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 --- Comment #7 from Matías Kreder mkre...@gmail.com --- Spec URL: http://delete.fedorapeople.org/speedtest-cli/speedtest-cli.spec SRPM URL: http://delete.fedorapeople.org/speedtest-cli/speedtest-cli-0.3.0-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369
--- Comment #5 from Parag AN(पराग) panem...@gmail.com ---
Sorry for being late.
Only 2 issues are remaining now
1) rpmlint on binary rpm is showing
speedtest-cli.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/speedtest_cli.py 0644L /usr/bin/env
= this can be fixed by adding following in %prep, below setup line
sed -i -e '/^#!\//, 1d' *.py
2) You have written in %files
%{python2_sitelib}/speedtest_cli.*
%{python2_sitelib}/speedtest_cli-0.3.0-py2.7.egg-info/*
we need this to be changed to have directory
%{python2_sitelib}/speedtest_cli-0.3.0-py2.7.egg-info owned by this package.
which should be written as
%{python2_sitelib}/speedtest_cli.py*
%{python2_sitelib}/speedtest_cli-0.3.0-py2.7.egg-info
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 --- Comment #4 from Parag AN(पराग) panem...@gmail.com --- sorry I am at the Flock conference so could not get time to review this. Will check above update by coming Monday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Matías Kreder mkre...@gmail.com changed: What|Removed |Added Flags|needinfo?(mkre...@gmail.com | |) | --- Comment #3 from Matías Kreder mkre...@gmail.com --- Hi, I'm sorry for the delay and the spec, this is my first python related package and I tried to grab some parts of code of the package guidelines for Python but looks like I went the wrong way with they python3 stuff. Anyway, I have updated the spec to meet your requirements. Spec URL: http://delete.fedorapeople.org/speedtest-cli/speedtest-cli.spec SRPM URL: http://delete.fedorapeople.org/speedtest-cli/speedtest-cli-0.3.0-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Christopher Meng i...@cicku.me changed: What|Removed |Added CC||mkre...@gmail.com Flags||needinfo?(mkre...@gmail.com ||) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Christopher Meng i...@cicku.me changed: What|Removed |Added CC||i...@cicku.me --- Comment #1 from Christopher Meng i...@cicku.me --- How did you package it??? No python3 BR, but lots of python3 stuffs. Actually it supports python3, but if we haven't received the notice to switch to python3 as default, don't build based on py3. (f22 might be py3 as default, but f21 hasn't been released yet, no need to care about it so early) What's the rationale of including MANIFEST.in as %doc? This package mustn't be a arch-sepcific package, why do I see many optflags and sitelib? And where is noarch? You'd better use pypi tarball: https://pypi.python.org/pypi/speedtest-cli -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369
--- Comment #2 from Parag AN(पराग) panem...@gmail.com ---
first I will suggest some changes here
1) This package does not do any compilations. This is a noarch package so just
add
BuildArch: noarch
2) Then you will not needed any compilation flags to be set so remove
CFLAGS=$RPM_OPT_FLAGS from both the lines
3) For Fedora and EPEL6/EPEL7 you will not need to remove buildroot in %install
drop following line
rm -rf %{buildroot}
See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
4) another thing I found Pypi already hosts this package source but did not
include man page or modified the upstream tarball so don't use that keep the
github source only.
5) I see both the binaries are same speedtest and speedtest-cli. Check with
upstream to fix this and provide only speedtest-cli. In the spec file you can
add to %install
rm -f $RPM_BUILD_ROOT%{_bindir}/speedtest
6) Decide first if you want python3 package as well or not?
7) you may want to install man page manually as by adding to %install
gzip speedtest-cli.1
mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
install -p -m 644 speedtest-cli.1.gz
$RPM_BUILD_ROOT%{_mandir}/man1/speedtest-cli.1.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
