[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947 Miroslav Suchý changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) | Resolution|--- |NOTABUG Last Closed||2016-08-03 10:42:57 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947 Julian Stecklina changed: What|Removed |Added Flags|needinfo?(j...@alien8.de) | --- Comment #5 from Julian Stecklina --- Please close. Unfortunately, I don't have the time to pursue this further. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947 Miroslav Suchý changed: What|Removed |Added CC||j...@alien8.de, ||msu...@redhat.com Flags||needinfo?(j...@alien8.de) --- Comment #4 from Miroslav Suchý --- Julian, are you still interrested in? You provided no response to Michael comment. If there will be no response, then this review will be closed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947
--- Comment #3 from Michael Schwendt ---
A quick look at the spec file:
> %doc
To be deleted. An empty %doc line makes no sense. It's a no-op.
> %{_bindir}/*
Sort of sloppy packaging, because this would include anything in the package
and would even accept a missing %{_bindir}/%{name} executable. Please be a
little more explicit about which files to include, also to increase
clearness/comprehensibility of the spec file. A compromise would be to do
%{_bindir}/%{name}*
%{_bindir}/mpp*
with the caveat that it would also not fail for an absent %{_bindir}/%{name}
file (or other files people expect to be available). Ideal would be to either
spell out all files you never want to be missing, or to add a guard that
verifies whether e.g. %{buildroot}%{_bindir}/%{name} is available. The %install
or %check section is suitable for that.
> %{_mandir}/*
Here the brevity leads to including too many subdirs of %{_mandir}, which
belong into the "filesystem" package already and must not be included in your
package:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
> %{_datadir}/makepp/*
> %{_defaultdocdir}/makepp/*
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947 Robin Lee changed: What|Removed |Added CC||robinlee.s...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947 --- Comment #2 from Christopher Meng --- *** Bug 1001452 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119947] Review Request: makepp - Compatible but reliable and improved replacement for make
https://bugzilla.redhat.com/show_bug.cgi?id=1119947 Christopher Meng changed: What|Removed |Added CC||i...@cicku.me --- Comment #1 from Christopher Meng --- Thanks for packaging it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
