[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Inline-Filters-0.14-1. ||fc21 Resolution|--- |RAWHIDE Last Closed||2014-08-12 05:05:33 --- Comment #12 from Petr Šabata psab...@redhat.com --- Thank you both. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #13 from Petr Pisar ppi...@redhat.com --- Package Change Request == Package Name: perl-Inline-Filters Branches: f21 master Owners: InitialCC: perl-sig The package database is missing the InialCC records again. Please add them and fix your tool. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Petr Šabata psab...@redhat.com --- New Package SCM Request === Package Name: perl-Inline-Filters Short Description: Common source code filters for Inline modules Upstream URL: http://search.cpan.org/dist/Inline-Filters/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Pisar ppi...@redhat.com changed: What|Removed |Added External Bug ID||CPAN 97755 --- Comment #6 from Petr Pisar ppi...@redhat.com --- Thanks for clarification. I reported the link botch as https://rt.cpan.org/Public/Bug/Display.html?id=97755 to the upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 --- Comment #7 from Petr Pisar ppi...@redhat.com --- License verified from LICENSE and Filters.pod. Ok. Summary verified from Filters.pod. Ok. Description verified from Filters.pod. Ok. No XS code, noarch BuildArch is Ok. All BuildRequires are specified. Ok. FIX: Tests do not pass because Inline::C optionally requires Parse::RecDescent: PERL_DL_NONLAZY=1 /usr/bin/perl -MExtUtils::Command::MM -MTest::Harness -e undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch') t/*.t t/Preprocess.t .. This innvocation of Inline requires the Parse::RecDescent module. Can't locate Parse/RecDescent.pm in @INC (you may need to install the Parse::RecDescent module) (@INC contains: /home/test/rpmbuild/BUILD/Inline-Filters-0.14/_Inline/lib /home/test/rpmbuild/BUILD/Inline-Filters-0.14/blib/lib /home/test/rpmbuild/BUILD/Inline-Filters-0.14/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /usr/share/perl5/vendor_perl/Inline/C/ParseRecDescent.pm line 16. at /usr/share/perl5/vendor_perl/Inline/C.pm line 389. BEGIN failed--compilation aborted at t/Preprocess.t line 2. t/Preprocess.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 1/1 subtests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 --- Comment #8 from Petr Šabata psab...@redhat.com --- Added the dependency with a comment. Links updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Pisar ppi...@redhat.com --- Spec file changes: --- perl-Inline-Filters.spec.old2014-07-17 16:26:37.0 +0200 +++ perl-Inline-Filters.spec2014-08-05 14:44:17.0 +0200 @@ -14,10 +14,13 @@ BuildRequires: perl(File::Spec) BuildRequires: perl(Inline) BuildRequires: perl(Inline::C) +# Required indirectly, optional Inline dependency +BuildRequires: perl(Parse::RecDescent) BuildRequires: perl(strict) BuildRequires: perl(Test::More) BuildRequires: perl(warnings) Requires: perl(:MODULE_COMPAT_%(eval $(perl -V:version); echo $version)) +Requires: perl(Parse::RecDescent) %description Inline::Filters provide common source code filters to Inline language FIX: Tests do not pass because Inline::C optionally requires Parse::RecDescent +# Required indirectly, optional Inline dependency +BuildRequires: perl(Parse::RecDescent) Ok. All tests pass. Ok. $ rpmlint perl-Inline-Filters.spec ../SRPMS/perl-Inline-Filters-0.14-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm drwxr-xr-x2 rootroot0 Aug 5 16:24 /usr/share/doc/perl-Inline-Filters -rw-r--r--1 rootroot 749 Apr 1 23:20 /usr/share/doc/perl-Inline-Filters/Changes -rw-r--r--1 rootroot18236 Jan 6 2014 /usr/share/doc/perl-Inline-Filters/LICENSE -rw-r--r--1 rootroot 1752 Jan 6 2014 /usr/share/doc/perl-Inline-Filters/README -rw-r--r--1 rootroot 4131 Aug 5 16:24 /usr/share/man/man3/Inline::Filters.3pm.gz drwxr-xr-x2 rootroot0 Aug 5 16:24 /usr/share/perl5/vendor_perl/Inline -rw-r--r--1 rootroot 4261 Apr 1 23:15 /usr/share/perl5/vendor_perl/Inline/Filters.pm -rw-r--r--1 rootroot 5063 Mar 28 16:29 /usr/share/perl5/vendor_perl/Inline/Filters.pod File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Config) 1 perl(File::Spec) 1 perl(Parse::RecDescent) 1 perl(strict) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Inline::Filters) = 0.14 1 perl-Inline-Filters = 0.14-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Inline-Filters-0.14-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7243865). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #4 from Petr Pisar ppi...@redhat.com --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: cb7af9300a851afaf3c8e1d871248d53eb02106b0d9d838350e43ce14b4e7b09). Ok. FATAL: The license statements contradict. LICENSE states (Artistic or GPL+), Filters.pod stated as Perl but links to (Artistic) only, and README states All Rights Reserved.. While I believe upstream wants (Artistic or GPL+), this is highly confusing and you have to clarify it with upstream anr/or Fedora legal departement. Hint: Upstream has released 0.15 version where the changelog promises improvements in the legal texts. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | --- Comment #5 from Tom spot Callaway tcall...@redhat.com --- All Rights Reserved is a legal no-op. It means nothing, just ignore it. Despite being a bit confusing, this is clearly meant to be under the same terms as Perl itself, which is Artistic or GPL+ and is fine for Fedora. Lifting FE-Legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Bug 1120297 depends on bug 1120293, which changed state. Bug 1120293 Summary: Review Request: perl-Inline-C - Write Perl subroutines in C https://bugzilla.redhat.com/show_bug.cgi?id=1120293 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 David Dick dd...@cpan.org changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|dd...@cpan.org |nob...@fedoraproject.org Flags|fedora-review? | --- Comment #3 from David Dick dd...@cpan.org --- I'm going to jump out of this review for the time being. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 --- Comment #2 from David Dick dd...@cpan.org --- Disregard my last. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 Petr Šabata psab...@redhat.com changed: What|Removed |Added Depends On||1120293 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1120293 [Bug 1120293] Review Request: perl-Inline-C - Write Perl subroutines in C -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
