[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Susi Lehtola changed: What|Removed |Added Blocks|505154 (FE-SCITECH) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||freesteam-2.1-3.20140724svn ||753.fc20 Resolution|--- |ERRATA Last Closed||2014-08-07 11:31:46 --- Comment #13 from Fedora Update System --- freesteam-2.1-3.20140724svn753.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- freesteam-2.1-3.20140724svn753.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #11 from Fedora Update System --- freesteam-2.1-3.20140724svn753.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/freesteam-2.1-3.20140724svn753.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). Added f21. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Antonio Trande changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Antonio Trande --- Thank you Christopher. New Package SCM Request === Package Name: freesteam Short Description: Calculate the properties of water and steam Upstream URL: http://freesteam.sourceforge.net/ Owners: sagitter Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Christopher Meng --- (In reply to Antonio Trande from comment #7) > (In reply to Christopher Meng from comment #6) > > 2. Final question here, main pkg has %doc LICENSE.txt README.txt > > CHANGELOG.txt. And somehow I think it's better to put README and CHANGELOG > > to the -devel. > > Why? -devel requires main package... Yes, I mean those README and CHANGELOG are useless for the _use_, so it's better to put them into the -devel. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #7 from Antonio Trande --- (In reply to Christopher Meng from comment #6) > 2. Final question here, main pkg has %doc LICENSE.txt README.txt > CHANGELOG.txt. And somehow I think it's better to put README and CHANGELOG > to the -devel. Why? -devel requires main package... > > 3. Does it support python3? No, I think. Spec URL: http://sagitter.fedorapeople.org/freesteam/freesteam.spec SRPM URL: http://sagitter.fedorapeople.org/freesteam/freesteam-2.1-3.20140724svn753.fc20.src.rpm - New svn release - Fixed unused-direct-shlib-dependency warnings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791
--- Comment #6 from Christopher Meng ---
1. Drop this line as well: mkdir -p %{buildroot}%{_datadir}/applications
2. Final question here, main pkg has %doc LICENSE.txt README.txt CHANGELOG.txt.
And somehow I think it's better to put README and CHANGELOG to the -devel.
3. Does it support python3?
Nonetheless, PACKAGE APPROVED.
Once above are checked, I will set + here.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #5 from Antonio Trande --- Spec URL: http://sagitter.fedorapeople.org/freesteam/freesteam.spec SRPM URL: http://sagitter.fedorapeople.org/freesteam/freesteam-2.1-2.fc20.src.rpm - Fixed Icon Cache scriptlets only for gtk sub-package - Some manual installation fixes - Fix instances of #!/usr/bin/env python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #4 from Christopher Meng --- env may bring confusion if one deployed serveral virtualenvs there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791
--- Comment #3 from Antonio Trande ---
> 3. Please explicitly set @PYTHON@ to %{__python2}, do not leave /usr/bin/env
> there.
What do you mean?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #2 from Christopher Meng --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in freesteam-gtk See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 26 files have unknown license. Detailed output of licensecheck: GPL (v2 or later) - freesteam-2.1/ascend/freesteam_ascend.c freesteam-2.1/b23.c freesteam-2.1/b23.h freesteam-2.1/backwards.c freesteam-2.1/backwards.h freesteam-2.1/backwards_impl.h freesteam-2.1/bounds.c freesteam-2.1/bounds.h freesteam-2.1/common.c freesteam-2.1/common.h freesteam-2.1/compat.h freesteam-2.1/derivs.c freesteam-2.1/derivs.h freesteam-2.1/gtk/callbacks.c freesteam-2.1/gtk/freesteam-gtk.c freesteam-2.1/gtk/freesteam-gtk.h freesteam-2.1/python/tables.py freesteam-2.1/region1.c freesteam-2.1/region1.h freesteam-2.1/region2.c freesteam-2.1/region2.h freesteam-2.1/region3.c freesteam-2.1/region3.h freesteam-2.1/region4.c freesteam-2.1/region4.h freesteam-2.1/solver2.c freesteam-2.1/solver2.h freesteam-2.1/steam.c freesteam-2.1/steam.h freesteam-2.1/steam_Ts.c freesteam-2.1/steam_Ts.h freesteam-2.1/steam_Tx.c freesteam-2.1/steam_Tx.h freesteam-2.1/steam_pT.c freesteam-2.1/steam_pT.h freesteam-2.1/steam_ph.c freesteam-2.1/steam_ph.h freesteam-2.1/steam_ps.c freesteam-2.1/steam_ps.h freesteam-2.1/steam_pu.c freesteam-2.1/steam_pu.h freesteam-2.1/steam_pv.c freesteam-2.1/steam_pv.h freesteam-2.1/steam_uv.c freesteam-2.1/steam_uv.h freesteam-2.1/surftens.c freesteam-2.1/surftens.h freesteam-2.1/test.c freesteam-2.1/thcond.c freesteam-2.1/thcond.h freesteam-2.1/thcond.py freesteam-2.1/viscosity.c freesteam-2.1/viscosity.h freesteam-2.1/zeroin.c freesteam-2.1/zeroin.h GPL (v3 or later) - freesteam-2.1/python/hsdiagram.py LGPL (v2.1) --- freesteam-2.1/scons/disttar.py Unknown or generated freesteam-2.1/config.h freesteam-2.1/examples/isentropic.c freesteam-2.1/labview/fsteam.c freesteam-2.1/labview/fsteam.h freesteam-2.1/pyqt/UI_steamTables.py freesteam-2.1/pyqt/images/images_rc.py freesteam-2.1/pyqt/units/UI.py freesteam-2.1/pyqt/units/__init__.py freesteam-2.1/pyqt/units/config.py freesteam-2.1/pyqt/units/unidades.py freesteam-2.1/python/Thdiagram.py freesteam-2.1/python/defunct/Tsdiagram.py freesteam-2.1/python/defunct/phdiagram.py freesteam-2.1/python/defunct/pudiagram.py freesteam-2.1/python/pTdiagram.py freesteam-2.1/python/rhoTdiagram.py freesteam-2.1/python/satcurve.py freesteam-2.1/python/test.py freesteam-2.1/python/tsp3d.py freesteam-2.1/qt/stgui.cpp freesteam-2.1/qt/stgui.h freesteam-2.1/scons/ascend.py freesteam-2.1/scons/gsl.py freesteam-2.1/scons/gtk.py freesteam-2.1/scons/nsis.py freesteam-2.1/scons/substinfile.py [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Antonio Trande changed: What|Removed |Added Blocks||505154 (FE-SCITECH) --- Comment #1 from Antonio Trande --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7128364 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
