[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Lubomir Rintel changed: What|Removed |Added Blocks||1123399 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1123399 [Bug 1123399] Review Request: python-botocore - The low-level, core functionality of boto 3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Lubomir Rintel changed: What|Removed |Added Blocks||1123402 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1123402 [Bug 1123402] Review Request: awscli - AWS Command Line Interface -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 --- Comment #1 from Lubomir Rintel --- SPEC: http://v3.sk/~lkundrak/SPECS/python-jmespath.spec SRPM: http://v3.sk/~lkundrak/SRPMS/python-jmespath-0.4.1-2.fc21.src.rpm Added Python 3 support. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398
Haïkel Guémar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Haïkel Guémar ---
Since this package complies with Fedora packaging guidelines, and works as
expected, I hereby approve it. Formal review is below.
Please submit a scm request.
I'll finish the reviews blocked by this one as soon as python{,3}-jmespath is
imported in rawhide.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 22 files have unknown license. Detailed output of
licensecheck in /home/haikel/1123398-python-jmespath/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-jmespath
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-En
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Lubomir Rintel changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Lubomir Rintel --- New Package SCM Request === Package Name: python-jmespath Short Description: JSON Matching Expressions Upstream URL: https://github.com/boto/jmespath Owners: lkundrak jtaylor Branches: f19 f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Lubomir Rintel changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-07-30 08:59:35 --- Comment #5 from Lubomir Rintel --- Imported and built. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
