[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Ismael Olea changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-08-21 12:09:52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Ismael Olea changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Ismael Olea --- New Package SCM Request === Package Name: jsap Short Description: A Java-based Simple Argument Parser Upstream URL: http://www.martiansoftware.com/jsap/ Owners: olea Branches: f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 --- Comment #7 from gil cattaneo --- Spec file history should be not interesting, exclude jpp comment in changelog [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven-metadata [?]: Requires correct, justified where necessary. Requires: javapackages-tools should be removed [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) IGNORE Not relevant Set free to resolve these problems @ import time Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894
gil cattaneo changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|punto...@libero.it
Flags||fedora-review+
--- Comment #6 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 94 files have unknown license. Detailed output of
licensecheck in /home/gil/1127894-jsap/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-metadata
[?]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/maven-metadata
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
Requires: javapackages-tools should be removed
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jsap-
javadoc , jsap-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all t
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894
--- Comment #5 from Ismael Olea ---
(In reply to gil cattaneo from comment #4)
> (In reply to gil cattaneo from comment #2)
> > please,remove
> > #%pom_add_dep com.martiansoftware.snip %{name}.pom
> > #%pom_add_dep com.martiansoftware.rundoc %{name}.pom
> not have sense add these libraries as build deps.
I'll remove this pom references but snip and rundoc are required for building
the documentation (manual ant task)
> javac target andsource MUST be changed in 1.5 or major (in ant build
> script/s)
Ok
(In reply to gil cattaneo from comment #2)
> please,remove
> #%pom_add_dep com.martiansoftware.snip %{name}.pom
> #%pom_add_dep com.martiansoftware.rundoc %{name}.pom
done
> there are unneeded BR:
done
> unnecessary Requires (XMvn handled by XMvn - javapackages-*)
> [...]
done
> use:
> find . -name "*.jar" -delete
> find . -name "*.class" -delete
I choose to explicit remove existing files in order to easy detect changes in
future releases.
Here is the last revision:
http://olea.org/tmp/jsap-2.1-5.3.fc22.src.rpm
http://olea.org/tmp/jsap.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Bug 1127894 depends on bug 1130755, which changed state. Bug 1130755 Summary: Review Request: rundoc https://bugzilla.redhat.com/show_bug.cgi?id=1130755 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Bug 1127894 depends on bug 1130756, which changed state. Bug 1130756 Summary: Review Request: snip https://bugzilla.redhat.com/show_bug.cgi?id=1130756 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894
--- Comment #4 from gil cattaneo ---
(In reply to gil cattaneo from comment #2)
> please,remove
> #%pom_add_dep com.martiansoftware.snip %{name}.pom
> #%pom_add_dep com.martiansoftware.rundoc %{name}.pom
not have sense add these libraries as build deps.
the only dependencies required by jsap should be ant and xstream
used only for testing?
javac target andsource MUST be changed in 1.5 or major (in ant build script/s)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 --- Comment #3 from gil cattaneo --- for remove some rpmlint warning exclude jpp comment in changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894
gil cattaneo changed:
What|Removed |Added
CC||punto...@libero.it
--- Comment #2 from gil cattaneo ---
please,remove
#%pom_add_dep com.martiansoftware.snip %{name}.pom
#%pom_add_dep com.martiansoftware.rundoc %{name}.pom
or create some template pom for both packages
e.g.
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
com.martiansoftware.@PROJECT@
@PROJECT@
@VERSION@
jar
there are unneeded BR:
BuildRequires: java-devel >= 1:1.6.0
BuildRequires: maven-local
you can use only
BuildRequires: javapackages-tools
or better
BuildRequires: javapackages-local
unnecessary Requires (XMvn handled by XMvn - javapackages-*)
Requires: java-headless >= 1:1.6.0
Requires: javapackages-tools
also for sub package javadoc
Requires: %{name} = %{version}-%{release}
Requires: javapackages-tools
this should be a bug in XMvn, please contact mizde...@redhat.com for more info
%dir /usr/share/maven-poms/%{name}/
please fix unowner %dir /usr/share/java/%{name}/
please use %dir %{_javadir}/%{name}/ instead of %dir /usr/share/java/%{name}/
"Group:" tag is no longer necessary.
please, cleanup spec file:
remove %define * (unused)
use:
find . -name "*.jar" -delete
find . -name "*.class" -delete
You can make maven install the javadocs by passing -J to mvn_install
%mvn_install -J javadoc
And then in the files section, you can have:
%files javadoc -f .mfiles-javadoc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Ismael Olea changed: What|Removed |Added Depends On||1130756 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1130756 [Bug 1130756] Review Request: snip -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Ismael Olea changed: What|Removed |Added Depends On||1130755 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1130755 [Bug 1130755] Review Request: rundoc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 --- Comment #1 from Ismael Olea --- http://olea.org/tmp/jsap.spec http://copr-be.cloud.fedoraproject.org/results/olea/OmegaT/fedora-rawhide-x86_64/jsap-2.1-5.2.fc22/jsap-2.1-5.2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127894] Review Request: jsap
https://bugzilla.redhat.com/show_bug.cgi?id=1127894 Ismael Olea changed: What|Removed |Added Blocks||919550 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=919550 [Bug 919550] OmegaT-2.6.3 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
