[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Nikos Roussos changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2016-01-16 18:16:16 --- Comment #19 from Nikos Roussos --- This has already been packaged in the meantime on #1169493 *** This bug has been marked as a duplicate of bug 1169493 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Volker Fröhlich changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|volke...@gmx.at |nob...@fedoraproject.org --- Comment #18 from Volker Fröhlich --- Sorry, I'm constantly overworked. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #17 from Nikos Roussos --- Thanks, I somehow missed this bug. @Volker could you finalize the review process? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Christopher Meng changed: What|Removed |Added CC||i...@cicku.me --- Comment #16 from Christopher Meng --- *** Bug 1119007 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #15 from Christopher Meng --- I will mark my bug as duplicate of this one, although I'm the first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100
--- Comment #14 from Christopher Meng ---
Ok so the issue I found solved.
Hint: rm -rf %{srcname}-%{version}/Markups.egg-info is redundant, just rm -rf
Markups.egg-info is enough I think(unless you really prefer old schools.)
As Volker hasn't posted any full review text, I won't set + here, Volker if you
think this is OK, then let it go.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #13 from Nikos Roussos --- Thanks for the clarification. I think I get it now. SPEC: https://comzeradd.fedorapeople.org/specs/python-markups.spec SRPM: https://comzeradd.fedorapeople.org/srpms/python-markups-0.5.0-4.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #12 from Christopher Meng --- (In reply to Nikos Roussos from comment #11) > http://pkgs.fedoraproject.org/cgit/python-markdown.git/tree/python-markdown. > spec > http://pkgs.fedoraproject.org/cgit/python-docutils.git/tree/python-docutils. > spec These 2 are correct, because they only put BuildRequires in the conditional blocks, not like this one from you, putting BuildRequires and Requires to wrong place exactly. Your initial spec will give python-markups dependencies hereunder: Requires: python3-markdown Requires: python3-docutils Requires: python3-textile And python2 packages shouldn't pull in any python3 deps, I think you should be able to understand this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100
--- Comment #11 from Nikos Roussos ---
I have package several python packages before, but none so far with python3
subpackage. Can you elaborate on the dependency thing?
> Yeah yeah, when you enable python3 build the python-markup will have python3
> dependencies in itself whereas python3-markup has no python3 deps.
>
> Please, move the %if 0%{?with_python3}...%endif to underneath the python3
> %package.
Why is that? I followed examples from other packages currently at Fedora that
have the python3 dependencies along with python2 ones. For instance:
http://pkgs.fedoraproject.org/cgit/python-markdown.git/tree/python-markdown.spec
http://pkgs.fedoraproject.org/cgit/python-docutils.git/tree/python-docutils.spec
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #10 from Christopher Meng --- s/to underneath/beneath/, sorry for the typo as I'm on iPad. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100
Christopher Meng changed:
What|Removed |Added
Flags|fedora-review+ |
--- Comment #9 from Christopher Meng ---
I'm sorry, you all didn't realize the essential issues:
1. %global with_python3 1
%global srcname Markups
Name: python-markups
Version:0.5.0
Release:3%{?dist}
Summary:A wrapper around various text markups
License:BSD
URL:https://pypi.python.org/pypi/Markups
Source0:
https://pypi.python.org/packages/source/M/%{srcname}/%{srcname}-%{version}.tar.gz
BuildArch: noarch
BuildRequires: python2-devel
BuildRequires: python-setuptools
BuildRequires: python-markdown
BuildRequires: python-docutils
BuildRequires: python-textile
Requires: python-markdown
Requires: python-docutils
Requires: python-textile
%if 0%{?with_python3}
BuildRequires: python3-devel
BuildRequires: python3-setuptools
BuildRequires: python3-markdown
BuildRequires: python3-docutils
BuildRequires: python3-textile
Requires: python3-markdown
Requires: python3-docutils
Requires: python3-textile
%endif
Yeah yeah, when you enable python3 build the python-markup will have python3
dependencies in itself whereas python3-markup has no python3 deps.
Please, move the %if 0%{?with_python3}...%endif to underneath the python3
%package.
2. rm -rf %{buildroot}/%{python3_sitelib}/*.egg-info
Please, I don't know what you are doing here, doing this will cause FTBFS of
other packages. Volker is right, he told you to
(In reply to Volker Fröhlich from comment #2)
> Please delete the egg-info directory in the prep section.
Which means the python eggs shipped in the tarball should be deleted _before_
%build, not to let you delete those generated by %build.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Volker Fröhlich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Volker Fröhlich --- Thank you, Mayorga! You didn't say which branches you want to create, but just in case you don't know: F20 has no python3-textile. I was wondering whether the description is accurate and not misleading, in regards to "(these two are supported by default)." However, APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Nikos Roussos changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #7 from Nikos Roussos --- Good catch SPEC: https://comzeradd.fedorapeople.org/specs/python-markups.spec SRPMS: https://comzeradd.fedorapeople.org/srpms/python-markups-0.5.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Eduardo Mayorga changed: What|Removed |Added CC||e...@mayorgalinux.com --- Comment #6 from Eduardo Mayorga --- - You can drop Requires: python, it's not necessary. - Documentation must be included in Python 3 subpackage as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #5 from Nikos Roussos --- I just followed what seems to be the current trend at python packages, to be all lowercase. For instance Markdown is packaged as python-markdown. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #4 from Christopher Meng --- I packaged it month ago. IMO this package should be named python-Markups. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Nikos Roussos changed: What|Removed |Added Assignee|volke...@gmx.at |nob...@fedoraproject.org --- Comment #3 from Nikos Roussos --- Thanks for looking into this. I think I fixed most of the issues. SPEC: https://comzeradd.fedorapeople.org/specs/python-markups.spec SRPM: https://comzeradd.fedorapeople.org/srpms/python-markups-0.5.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Nikos Roussos changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Volker Fröhlich changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #2 from Volker Fröhlich --- Please delete the egg-info directory in the prep section. It should only be included if it's generated by the build script. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 --- Comment #1 from Volker Fröhlich --- The tests are failing in at least F20 and Rawhide: == FAIL: test_api (tests.test_public_api.APITest) -- Traceback (most recent call last): File "/home/makerpm/rpmbuild/BUILD/Markups-0.5.0/tests/test_public_api.py", line 18, in test_api self.assertTrue(isinstance(markup, markups.MarkdownMarkup)) AssertionError: False is not true Remove the version constraints from the BRs. They are fulfilled in every release of Fedora. Use %global instead of %define. Use a wildcard for the Python version for the egg-info in the files section, otherwise you'd have to adapt it on branches and new releases! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128100] Review Request: python-markups - A wrapper around various text markups
https://bugzilla.redhat.com/show_bug.cgi?id=1128100 Nikos Roussos changed: What|Removed |Added Blocks||1128101 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1128101 [Bug 1128101] Review Request: ReText - A simple markdown editor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
