[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.1.2-1.fc21|0.1.2-1.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- libnsbmp-0.1.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- libnsbmp-0.1.2-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libnsbmp-0.1.2-1.fc24 |0.1.2-1.fc22 Resolution|RAWHIDE |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|0.1.2-1.fc22|0.1.2-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- libnsbmp-0.1.2-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||libnsbmp-0.1.2-1.fc24 Resolution|--- |RAWHIDE Last Closed||2015-08-14 05:08:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- libnsbmp-0.1.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/libnsbmp-0.1.2-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- libnsbmp-0.1.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/libnsbmp-0.1.2-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- libnsbmp-0.1.2-1.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/libnsbmp-0.1.2-1.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|ASSIGNED|POST Flags|needinfo?(i...@cicku.me) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #5 from Miro Hrončok mhron...@redhat.com --- Still no builds in Koji. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added CC||i...@cicku.me Flags||needinfo?(i...@cicku.me) --- Comment #4 from Miro Hrončok mhron...@redhat.com --- What's the status? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Christopher Meng i...@cicku.me --- Sure, I will add a note about the hack. New Package SCM Request === Package Name: libnsbmp Short Description: Decoding library for BMP and ICO image file formats Upstream URL: http://www.netsurf-browser.org/projects/libnsbmp/ Owners: cicku Branches: f19 f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336
Miro Hrončok mhron...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Miro Hrončok mhron...@redhat.com ---
Notes:
* What about including examples in devel doc?
* Drop a note/comment about -Werror sedding
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded
[Bug 1128336] Review Request: libnsbmp - Decoding library for BMP and ICO image file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1128336 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
