[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 jiri vanek changed: What|Removed |Added CC||jva...@redhat.com --- Comment #7 from jiri vanek --- Just for possible followers: there is bug in launcher - missing sunflow on classapth and typo inmain class - should be lowercase "f". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2016-06-24 08:14:54 --- Comment #6 from Dominik 'Rathann' Mierzejewski --- No longer interested in this package. Thanks for the review effort anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 gil cattaneo changed: What|Removed |Added CC|punto...@libero.it | Assignee|punto...@libero.it |nob...@fedoraproject.org Flags|fedora-review? | --- Comment #5 from gil cattaneo --- Leave this review to other -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 gil cattaneo changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343
gil cattaneo changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|punto...@libero.it
Flags||fedora-review?
--- Comment #4 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/java/sunflow
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* GPL (v2 or later) (with incorrect FSF address)", "GPL (v2
or later)", "Unknown or generated". 244 files have unknown license.
Detailed output of licensecheck in
/home/gil/1128343-sunflow/licensecheck.txt
NOTE: Incorrect FSF address found in license file and headers in source code.
Upstream should be informed about this.
sunflow-4f5017fd7c7140296188b3d63ee844762a70b3f7/exporters/blender/sunflow_export.py
[?]: License file installed when any subpackage combination is installed.
Original GPL license is available @ http://www.gnu.org/licenses/gpl.txt
the file installed is not a valid license file
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/java/sunflow
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/java/sunflow
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
Please, remove all Requires (managed by XMvn)
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in sunflow
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 --- Comment #3 from Dominik 'Rathann' Mierzejewski --- Spec URL: https://rathann.fedorapeople.org/review/sunflow/sunflow.spec SRPM URL: https://rathann.fedorapeople.org/review/sunflow/sunflow-0.07.3-0.1.20140412git4f5017f.fc20.src.rpm * Tue Aug 12 2014 Dominik Mierzejewski 0.07.3-0.1.20140412git4f5017f - switch to new upstream https://github.com/skrat/sunflow - use pom file There are no pre-built .class files and the only .jar is the bundled janino.jar, which is removed in %prep already. Thanks for the info about new upstream, Gil. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 --- Comment #2 from gil cattaneo --- Ops... forgot ... use find . -name '*.jar' -delete find . -name '*.class' -delete for must be sure there aren't pre-built libraries or classes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343
gil cattaneo changed:
What|Removed |Added
CC||punto...@libero.it
--- Comment #1 from gil cattaneo ---
available a new release (0.07.3) @ https://github.com/skrat/sunflow/
Other issues:
- please, remove versioned JAR
http://fedoraproject.org/wiki/Packaging:Java#JAR_file_installation
- please, provides maven depmap and pom file
pom file is available @
https://github.com/psiegman/mvn-repo/blob/master/snapshots/org/sunflow/sunflow/0.07.3/sunflow-0.07.3.pom
use BuildRequires: javapackages-local instead
and use for e.g.
%prep
in this case
%mvn_file org.sunflow:sunflow %{name}
%build
ant -Dsunflow.libs=$(build-classpath janino) jars
ant -Dsunflow.libs=$(build-classpath janino) javadoc
assuming that the pom file corresponds to S:3
%mvn_artifact %{SOURCE3} release/%{name}.jar
%install
%mvn_install -J release/javadoc
%files -f .mfiles
%doc CHANGELOG LICENSE README
%{_bindir}/sunflow
%{_datadir}/icons/hicolor/128x128/apps/sunflow.png
%{_datadir}/applications/sunflow.desktop
%files javadoc -f .mfiles-javadoc
all references and samples available @
https://fedorahosted.org/released/javapackages/doc/#helper_macros
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128343] Review Request: sunflow - A rendering system for photo-realistic image synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=1128343 Mikolaj Izdebski changed: What|Removed |Added CC||mizde...@redhat.com Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
