[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #18 from Fedora Update System  ---
ccnet-5.0.0-1.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #17 from Fedora Update System  ---
ccnet-5.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-19 18:30:06



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #16 from Fedora Update System  ---
ccnet-5.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update ccnet'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-13bf0049d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
ccnet-5.0.0-1.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update ccnet'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-82b600d637

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Julien Enselme  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Julien Enselme  ---
Looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #13 from Fedora Update System  ---
ccnet-5.0.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-13bf0049d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #14 from Fedora Update System  ---
ccnet-5.0.0-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-82b600d637

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/ccnet

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #10 from Nikos Roussos  ---
Sorry for the long delay.

I updated the spec with fixes based on the review above. Package also updated
to latest upstream version.
SPEC: https://comzeradd.fedorapeople.org/specs/ccnet.spec
SRPM: https://comzeradd.fedorapeople.org/srpms/ccnet-5.0.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #9 from Julien Enselme  ---
Any progress on that package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Julien Enselme  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #8 from Julien Enselme  ---
(In reply to Ralf Corsepius from comment #7)
> (In reply to Julien Enselme from comment #6)
> > Some remarks:
> > 
> > - Version of so files looks incorrect: /usr/lib64/libccnet.so.0.0.0,
> > /usr/lib64/libccnet.so.0 Shouldn't this be /usr/lib64/libccnet.so.4.3.4 and
> > /usr/lib64/libccnet.so.4?
> 
> No. Library version numbers and package version numbers actually are not
> connected at all (cf. info libtool). 
> 
> So, even though using "0.0.0" is likely to bug upstream and Fedora at some
> time in future (e.g. when upstream changes the API/ABI), using "0.0.0" is
> technically correct.
>

Thanks for you explainations. This point looks good then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de



--- Comment #7 from Ralf Corsepius  ---
(In reply to Julien Enselme from comment #6)
> Some remarks:
> 
> - Version of so files looks incorrect: /usr/lib64/libccnet.so.0.0.0,
> /usr/lib64/libccnet.so.0 Shouldn't this be /usr/lib64/libccnet.so.4.3.4 and
> /usr/lib64/libccnet.so.4?

No. Library version numbers and package version numbers actually are not
connected at all (cf. info libtool). 

So, even though using "0.0.0" is likely to bug upstream and Fedora at some time
in future (e.g. when upstream changes the API/ABI), using "0.0.0" is
technically correct.


Additional remark:
I'd recommend to change Source0 into this:
Source0:   
https://github.com/haiwen/%{name}/archive/v%{version}.tar.gz#/ccnet-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429
Bug 1129429 depends on bug 1129224, which changed state.

Bug 1129224 Summary: Review Request: libsearpc - A simple and easy-to-use C 
language RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1129224

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #6 from Julien Enselme  ---
Some remarks:

- Version of so files looks incorrect: /usr/lib64/libccnet.so.0.0.0,
/usr/lib64/libccnet.so.0 Shouldn't this be /usr/lib64/libccnet.so.4.3.4 and
/usr/lib64/libccnet.so.4?


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel


= MUST items =

C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "ISC", "Unknown or generated". 200 files have
 unknown license. Detailed output of licensecheck in
 /tmp/1129429-ccnet/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
- %license in devel is missing

[!]: %build honors applicable compiler flags or justifies otherwise.
Your are missing the  %{optflags} macro (you should add it to libsearpc, I
missed that while reviewing). See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags. I think you
should add %{?_smp_mflags} too.

[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[X]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
According to the readme, libzdb >= 2.10.2 is needed to build this package.

[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
 process.
[X]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
- I belive that BR: python2-devel is required
- In 

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Julien Enselme  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|juj...@jujens.eu
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #5 from Nikos Roussos  ---
Update to 4.3.4

SPEC: https://comzeradd.fedorapeople.org/specs/ccnet.spec
SRPM: https://comzeradd.fedorapeople.org/seafile/ccnet-4.3.4-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #3 from Nikos Roussos comzer...@fedoraproject.org ---
Update to 4.1.4

SPEC: https://comzeradd.fedorapeople.org/specs/ccnet.spec
SRPM: https://comzeradd.fedorapeople.org/srpms/ccnet-4.1.4-1.fc21.src.rpm

Also address some things from above comment:

2. Use release tag instead of commit
3. Packaging guidelines discourage use of %makeinstall
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
4. Enabled hardened build
5. Use %license for the LICENSE text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #4 from Nikos Roussos comzer...@fedoraproject.org ---
(In reply to Vladimir Stackov from comment #2)
 Your packages (seafile and ccnet) both introduces build time requirements
 (cross-package BuildRequires) so you should setup boostraping properly:
 https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping

I'm not familiar with Bootsrapping. Both seafile and ccnet depend on libsearpc.
How this is a circular dependency?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Vladimir Stackov amigo.el...@gmail.com changed:

   What|Removed |Added

 CC||amigo.el...@gmail.com



--- Comment #2 from Vladimir Stackov amigo.el...@gmail.com ---
Greetings,

a few comments on this review request:

1. Your packages (seafile and ccnet) both introduces build time requirements
(cross-package BuildRequires) so you should setup boostraping properly:
https://fedoraproject.org/wiki/Packaging:Guidelines#Bootstrapping

2. As you are packaging snapshot, you should use another name for the package:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github

3. You should consider using %makeinstall macros instead of make install
DESTDIR=%{buildroot}:
# rpm -E %makeinstall

4. You should consider enabling hardened builds:
https://fedoraproject.org/wiki/Packaging:Guidelines#PIE

5. You should use %license for license information instead of %doc.

Please note that this is informal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429



--- Comment #1 from Nikos Roussos comzer...@fedoraproject.org ---
Updated to latest to build seafile 3.1.8

SPEC: https://comzeradd.fedorapeople.org/specs/ccnet.spec
SRPM: https://comzeradd.fedorapeople.org/srpms/ccnet-3.1.8-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Nikos Roussos comzer...@fedoraproject.org changed:

   What|Removed |Added

 Blocks||1160671




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1160671
[Bug 1160671] Review Request: seafile - Cloud storage system
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129429] Review Request: ccnet - A framework for writing networked applications in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129429

Nikos Roussos comzer...@fedoraproject.org changed:

   What|Removed |Added

 Depends On||1129224




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1129224
[Bug 1129224] Review Request: libsearpc - A simple and easy-to-use C
language RPC framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review