[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 David King changed: What|Removed |Added Status|NEW |ASSIGNED CC||amigad...@amigadave.com Assignee|nob...@fedoraproject.org|amigad...@amigadave.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484
--- Comment #1 from David King ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
Easy to fix, the packaging guidelines have some hints:
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
- directory ownership
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
The package should own the /usr/share/bustle-0.4.7 directory, which is also
easy to fix.
- preserve timestamps on install
This is easily done by adding 'INSTALL="install -p"' to the make install
invocation (but is optional).
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "Unknown or generated". 10 files have unknown
license. Detailed output of licensecheck in
/home/david/checkout/rpms/1129484-bustle/licensecheck.txt
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/bustle-0.4.7
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/bustle-0.4.7
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in bustle
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Haskell:
[x]: This should never happen
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: P
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 --- Comment #2 from Philip Withnall --- Thanks for the fast review! Updated spec and SRPM with those issues fixed, I think: • http://people.collabora.co.uk/~pwith/packaging/bustle.spec • http://people.collabora.co.uk/~pwith/packaging/bustle-0.4.7-1.fc19.src.rpm Updated Koji builds: • F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=7305460 • F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=7305463 • F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=7305467 • F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=7305473 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 David King changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from David King --- Looks good! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Philip Withnall changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Philip Withnall --- New Package SCM Request === Package Name: bustle Short Description: Draw pretty sequence diagrams of D-Bus traffic Upstream URL: http://willthompson.co.uk/bustle/ Owners: pwithnall Branches: f19 f20 f21 f22 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 --- Comment #5 from Kevin Fenzi --- Git done (by process-git-requests). There's no f22 branches yet, thats just master. ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 --- Comment #6 from Fedora Update System --- bustle-0.4.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/bustle-0.4.7-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 --- Comment #7 from Fedora Update System --- bustle-0.4.7-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/bustle-0.4.7-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- bustle-0.4.7-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Philip Withnall changed: What|Removed |Added Depends On||1131892 --- Comment #9 from Philip Withnall --- The builds for F21 and F22 are failing at the moment due to a crash in rpmdeps on the build machines: bug #1131892. http://koji.fedoraproject.org/koji/taskinfo?taskID=7407823 http://koji.fedoraproject.org/koji/taskinfo?taskID=7407826 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1131892 [Bug 1131892] rpmdeps --provides crashes when building bustle-0.4.7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Bug 1129484 depends on bug 1131892, which changed state. Bug 1131892 Summary: rpmdeps --provides crashes when building bustle-0.4.7 https://bugzilla.redhat.com/show_bug.cgi?id=1131892 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Jens Petersen changed: What|Removed |Added Depends On||1132275 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1132275 [Bug 1132275] ghc-rpm-macros should run ghc-deps.sh using a fileattrs file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Jens Petersen changed: What|Removed |Added Depends On|1132275 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1132275 [Bug 1132275] ghc-rpm-macros should run ghc-deps.sh using a fileattrs file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||bustle-0.4.7-1.fc19 Resolution|--- |ERRATA Last Closed||2014-08-26 21:30:42 --- Comment #10 from Fedora Update System --- bustle-0.4.7-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129484] Review Request: bustle - Draw pretty sequence diagrams of D-Bus traffic
https://bugzilla.redhat.com/show_bug.cgi?id=1129484 Fedora Update System changed: What|Removed |Added Fixed In Version|bustle-0.4.7-1.fc19 |bustle-0.4.7-1.fc20 --- Comment #11 from Fedora Update System --- bustle-0.4.7-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
