[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #16 from Carl George --- Pushed to EPEL 7 stable on 2016-03-04. https://bodhi.fedoraproject.org/updates/bash-completion-extras-2.1-8.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Carl George changed: What|Removed |Added Status|NEW |CLOSED CC||carl@george.computer Resolution|--- |CURRENTRELEASE Last Closed||2017-07-07 16:52:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #15 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/bash-completion-extras -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Adam Miller changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from Adam Miller --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #13 from Jim Perrin --- Updated and release bumped. I cleaned up a couple instances of trailing whitespace as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505
--- Comment #12 from Adam Miller ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is marked as %doc instead of %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 5 files have unknown license. Detailed
output of licensecheck in /home/admiller/reviews/1129505-bash-
completion-extras/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/bash-
completion/completions(tig, cmake, bzr, rpmdevtools, mercurial,
createrepo, vagrant, python-django-bash-completion, bash-completion,
firewalld, subversion, rolekit, rpmlint, yum, libappstream-glib,
source-highlight, git, gvfs, glib2)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 112640 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define rhelname bash-
completion
[x]: Packager, Vendor, PreReq, Copyright
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #11 from Jens Lody --- Enabling epel-testing in mock config and recreating the mock-root makes fedora-review workagain for epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #10 from Jens Lody --- Looks like we are bitten by this bug; https://bugzilla.redhat.com/show_bug.cgi?id=1241655#c8 Should be fixed in update-testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #9 from Jens Lody --- Oh I just saw the bugs-title, so it seems to be related to the mock-configuration. I will test this review also. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Jens Lody changed: What|Removed |Added CC||fed...@jenslody.de --- Comment #8 from Jens Lody --- I got the same error after editing the spec-file of gedit-plugin-git. Before Igot an error about a bad %if-condition: https://bugzilla.redhat.com/show_bug.cgi?id=1256479#c5 . In my case the %dist-tag was expanded to someting like "Release: ...", I do not recall what comes after the colon (I added an %echo to debug}. Which mock-configuration did you use ? It happend for me with epel-7-x86_64, and it did not happen always. I ignored the error, because it happened after manually editing the spec-file and it did not happen all the time, so I thought I messed something up. Using the same spec-file with mock directly did not lead to such errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #7 from Adam Miller --- Either something is wrong with the encoding of the spec file, the web server is messed up, or we found a bug in fedora-review (or maybe python!) :) $ fedora-review -b 1129505 -m epel-7-x86_64 INFO: Processing bugzilla bug: 1129505 INFO: Getting .spec and .srpm Urls from : 1129505 INFO: --> SRPM url: http://people.centos.org/jperrin/srpms/bash-completion-extras-2.1-7.el7.centos.src.rpm INFO: --> Spec url: http://people.centos.org/jperrin/srpms/bash-completion-extras.spec INFO: Using review directory: /home/admiller/reviews/1129505-bash-completion-extras INFO: Downloading .spec and .srpm files error: line 9: Illegal char ':' in: Release:7error: ERROR: "Can't parse specfile: can't parse specfile\n" (logs in /home/admiller/.cache/fedora-review.log) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Till Maas changed: What|Removed |Added CC|opensou...@till.name| Adam Miller changed: What|Removed |Added CC||admil...@redhat.com Assignee|den...@ausil.us |admil...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #6 from Jim Perrin --- My fault. read the email incorrectly. Updated srpm: http://people.centos.org/jperrin/srpms/bash-completion-extras-2.1-7.el7.centos.src.rpm Updated spec: http://people.centos.org/jperrin/srpms/bash-completion-extras.spec These have the required epoch addition in the changelog now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #5 from Dennis Gilmore --- review is not yet complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Till Maas changed: What|Removed |Added CC||opensou...@till.name Flags|fedora-cvs? |fedora-cvs- --- Comment #4 from Till Maas --- (In reply to Jim Perrin from comment #3) > New Package SCM Request > === > Package Name: bash-completion-extras > Short Description: Additional completion scripts for bash > Upstream URL: http://bash-completion.alioth.debian.org/ > Owners: jperrin > Branches: epel7 > InitialCC: You need to wait for Dennis to finish the review before this package can be added to Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Jim Perrin changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jim Perrin --- New Package SCM Request === Package Name: bash-completion-extras Short Description: Additional completion scripts for bash Upstream URL: http://bash-completion.alioth.debian.org/ Owners: jperrin Branches: epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 --- Comment #2 from Jim Perrin --- Done. I added the epoch to the changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package
https://bugzilla.redhat.com/show_bug.cgi?id=1129505 Dennis Gilmore changed: What|Removed |Added Assignee|nob...@fedoraproject.org|den...@ausil.us Flags||fedora-review? --- Comment #1 from Dennis Gilmore --- from a quick review you need to either drop the epoch or add it to the changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
