[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||json-path-0.9.1-3.fc21 Resolution|--- |RAWHIDE Last Closed||2014-08-22 12:01:17 --- Comment #6 from gil cattaneo --- Thank for all! Task Info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7439354 Build Info: http://koji.fedoraproject.org/koji/buildinfo?buildID=570041 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/json-path.spec SRPM URL: https://gil.fedorapeople.org/json-path-0.9.1-2.fc19.src.rpm - fix license issues New Package SCM Request === Package Name: json-path Short Description: Java JsonPath implementation Owners: gil Branches: f21 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936
Michal Srb changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Michal Srb ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
See below.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languag
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 --- Comment #2 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/json-path.spec SRPM URL: https://gil.fedorapeople.org/json-path-0.9.1-2.fc19.src.rpm - disable failed tests on java 8 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7438898 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936
--- Comment #1 from Michal Srb ---
Hmm, the package doesn't build in Rawhide due to test failures:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7438760
expected:<[{"o[ccupation":"Farm boy","name":"Luke Skywalker","aliases":["Nerf
herder"],"offspring":null]}]>
but was: <[{"o[ffspring":null,"aliases":["Nerf herder"],"occupation":"Farm
boy","name":"Luke Skywalker"]}]>
I guess this is Java 8 related and tests probably rely on particular ordering
in set.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 Bug 1131936 depends on bug 1131935, which changed state. Bug 1131935 Summary: Review Request: json-smart - A small and very fast json parser/generator for java https://bugzilla.redhat.com/show_bug.cgi?id=1131935 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131936] Review Request: json-path - Java JsonPath implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1131936 gil cattaneo changed: What|Removed |Added Depends On||1131935 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1131935 [Bug 1131935] Review Request: json-smart - A small and very fast json parser/generator for java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
