[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Jan Grulich changed: What|Removed |Added Status|MODIFIED|CLOSED CC||jgrul...@redhat.com Resolution|--- |RAWHIDE Last Closed||2015-01-20 08:39:24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #10 from Rex Dieter --- Imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Daniel Vrátil changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 --- Comment #8 from Daniel Vrátil --- New Package SCM Request === Package Name: kwin Short Description: KDE Window Manager Upstream URL: https://projects.kde.org/projects/kde/workspace/kwin Owners: dvratil ltinkl jgrulich kkofler rdieter than Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 --- Comment #7 from Rex Dieter --- ...probably best to *wait* ... that is :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 --- Comment #6 from Rex Dieter --- maybe needless to say, but, probably best to way until all(most?) plasma5 pkgs are approved before actually doing any builds in rawhide (to minimize the window of pain involved in switching everything over). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Rex Dieter --- looks good, thanks. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Daniel Vrátil changed: What|Removed |Added Flags|needinfo?(dvra...@redhat.co | |m) | --- Comment #4 from Daniel Vrátil --- Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kwin.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kwin-5.1.1-3.fc20.src.rpm - Fixed license - Fixed scriptlets - Fixed Conflicts in -devel - -docs is noarch (note that this depends on kde-workspace-4.11.14-2 update (pending atm), which splits kwin from kde-workspace into "kwin" subpackage) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522
Rex Dieter changed:
What|Removed |Added
CC||dvra...@redhat.com
Flags||needinfo?(dvra...@redhat.co
||m)
--- Comment #3 from Rex Dieter ---
For the purpose of this review, I'll treat
%global wayland 0
(still missing kf5-kwayland on f21 too)
naming: ok
1. license: NOT OK, MUST use (something like):
close, but there's one file:
scripts/enforcedeco/contents/code/main.js
that is the variant where we need:
# all sources are effectively GPLv2+, except for:
# scripts/enforcedeco/contents/code/main.js
# KDE e.V. may determine that future GPL versions are accepted
License: GPLv2 or GPLv3
macros: ok, though I personally prefer
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
over
%make_install -C %{_target_platform}
sources: ok
85ec15e6ce29b1bb80f376bc6914bc7c kwin-5.1.1.tar.xz
2. scriptlets: NOT OK, MUST add icon scriptlets, since we have in %files:
%{_datadir}/icons/hicolor/*/apps/*
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
3. -doc subpkg SHOULD be noarch
4. SHOULD improve
Conflicts: kde-workspace-devel
Ideally, I'd like to avoid this altogether, but I suppose that may not be
possible. If so, please make this versioned, even if just
Conflicts: kde-workspace-devel < 5
I think the rest looks good, please address at least the MUST/blocker items...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Dan Vrátil changed: What|Removed |Added Blocks||1163440 (plasma-oxygen) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1163440 [Bug 1163440] Review Request: plasma-oxygen - KDE and Qt widget style and window decorations -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 --- Comment #2 from Dan Vrátil --- Added an optional Wayland build Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kwin.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kwin-5.1.1-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135522] Review Request: kwin - KDE window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1135522 --- Comment #1 from Dan Vrátil --- Updated specfile: Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kwin.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kwin-5.1.1-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
