[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Alan Pevec changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2014-10-15 06:52:26 --- Comment #14 from Alan Pevec --- According to comment 13 openstack-zaqar is >= f22 only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Alan Pevec changed: What|Removed |Added CC||ape...@redhat.com --- Comment #13 from Alan Pevec --- > Branches: f21 Please keep openstack-marconi in F21 that's Icehouse code and we're keeping fedora:openstack 1:1 https://fedoraproject.org/wiki/OpenStack#OpenStack Also Zaqar depends on python-oslo-utils which is Juno addition so it won't be pushed to F21. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- openstack-zaqar-2014.2-0.3.b3.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #11 from Fedora Update System --- openstack-zaqar-2014.2-0.3.b3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/openstack-zaqar-2014.2-0.3.b3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #9 from Eduardo Echeverria --- Thanks haikel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Eduardo Echeverria changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Eduardo Echeverria --- New Package SCM Request === Package Name: openstack-zaqar Short Description: Message queuing service for OpenStack Owners: echevemaster flaper87 Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850
Haïkel Guémar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Haïkel Guémar ---
My apologies, I put this review in my DONE pile by mistake. Feel free to ping
me when a review takes time.
I redid the review just to be sure, I haven't missed something and it's ok.
So I hereby approve this package into Fedora Packages Collections, please
submit a scm request.
You may include me in the CC.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)".
4 files have unknown license. Detailed output of licensecheck in
/home/haikel/1138850-openstack-zaqar/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/logrotate.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license t
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #6 from Eduardo Echeverria --- Sorry for not adding it before. I forget it add these requirements. Are did the changes: SPEC: https://echevemaster.fedorapeople.org/openstack-zaqar/openstack-zaqar.spec SRPM: https://echevemaster.fedorapeople.org/openstack-zaqar/openstack-zaqar-2014.2-0.3.b3.fc20.src.rpm Tested on rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7566155 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Eduardo Echeverria changed: What|Removed |Added Flags|needinfo?(echevemaster@gmai | |l.com) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 hgue...@redhat.com changed: What|Removed |Added CC||hgue...@redhat.com Flags||needinfo?(echevemaster@gmai ||l.com) --- Comment #5 from hgue...@redhat.com --- Sorry for the delay, I had to be able to test it on a fresh install. I was able to test the upgrade path: OK There are two missing requirements: python-oslo-utils and python-oslo-i18n, please add them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #4 from Haïkel Guémar --- I did receive the notification, but in the past, I had the same issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #3 from Eduardo Echeverria --- Hi, thanks for take this. I don't know why I'm not receiving bugzilla notifications in my inbox. weird... Are you receiving notifications from bugzilla, hguemar? I've fixed the obsoletes towards marconi. Here you go the changes. https://echevemaster.fedorapeople.org/openstack-zaqar/openstack-zaqar.spec https://echevemaster.fedorapeople.org/openstack-zaqar/openstack-zaqar-2014.2-0.2.b3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? --- Comment #2 from Haïkel Guémar --- Damned, this is the first time, that I'm reviewing a rename of a package that I have originally reviewed ! :o) One issue, it doesn't obsolete marconi at all, which may prove problematic for the upgrade-path. It may only affect few people using rawhide and the branched F21, nonetheless, the obsolete is harmless. http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138850] Review Request: openstack-zaqar - Message queuing service for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1138850 --- Comment #1 from Eduardo Echeverria --- BTW, this is renaming of an existent package in fedora, openstack-marconi, which will to be retired once time that this be approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
