[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-DBIx-RunSQL-0.12-2.el5 |perl-DBIx-RunSQL-0.12-2.fc2 ||1 --- Comment #22 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-DBIx-RunSQL-0.12-2.el7 |perl-DBIx-RunSQL-0.12-2.el5 --- Comment #21 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-DBIx-RunSQL-0.12-2.el6 |perl-DBIx-RunSQL-0.12-2.el7 --- Comment #20 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-DBIx-RunSQL-0.12-2.fc1 |perl-DBIx-RunSQL-0.12-2.el6 |9 | --- Comment #19 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-DBIx-RunSQL-0.12-2.fc2 |perl-DBIx-RunSQL-0.12-2.fc1 |0 |9 --- Comment #18 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-DBIx-RunSQL-0.12-2.fc2 ||0 Resolution|--- |ERRATA Last Closed||2014-10-20 05:55:57 --- Comment #17 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #15 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #14 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #13 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #12 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #11 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #10 from Fedora Update System --- perl-DBIx-RunSQL-0.12-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 Denis Fateyev changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Denis Fateyev --- New Package SCM Request === Package Name: perl-DBIx-RunSQL Short Description: Run SQL commands from a file Owners: dfateyev Branches: f19 f20 f21 el5 el6 epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 David Dick changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from David Dick --- Builds ok at http://koji.fedoraproject.org/koji/taskinfo?taskID=7798953 rpmlint is clean Package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #6 from Denis Fateyev --- Updated spec: http://www.fateyev.com/RPMS/Fedora20/testing/perl-DBIx-RunSQL.spec SRPM: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-DBIx-RunSQL-0.12-2.fc20.denf.src.rpm Koji Rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=7791613 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #5 from David Dick --- Okay, give me the new spec and SRPM file and i'll complete the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #4 from Denis Fateyev --- Yes, I think it would be okay here (with keeping Pod::Readme and dropping Pod::Markdown) since Pod::Readme will be available soon in all Fedora/RHEL scope. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #3 from David Dick --- Those modules are required in Makefile.PL, so BuildRequires should be put in place for them. Having Pod::Readme available allows the regeneration of the README file, which fixes the end-of-line issue noted by rpmlint. I think that BR can be added without causing you to miss out on anything? Pod-Markdown can be skipped as the resulting README.mkdn is not included in the RPM (correctly, as it is an exact copy of the README file) Is that ok? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 --- Comment #2 from Denis Fateyev --- I skipped Pod::Readme and Pod::Markdown dependencies intentionally because they didn't affect the build or core functionality, - and the first was missing in epel7 [1], the second was missing both in el5 and el6 [2]. $ rpmlint perl-DBIx-RunSQL-0.12-1.fc22.src.rpm perl-DBIx-RunSQL-0.12-1.fc22.noarch.rpm perl-DBIx-RunSQL.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-DBIx-RunSQL/README 2 packages and 0 specfiles checked; 0 errors, 1 warnings. I think they can be omitted but if it's important I can either add a conditional for el5,el6 or exclude them from build entirely (actually, I wouldn't do that.) [1] http://pkgs.fedoraproject.org/cgit/perl-Pod-Readme.git I've recently posted the update: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-2808/perl-Pod-Readme-0.110-11.el7 but it hasn't reached stable repo yet. [2] http://pkgs.fedoraproject.org/cgit/perl-Pod-Markdown.git -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390
--- Comment #1 from David Dick ---
Builds successfully at
http://koji.fedoraproject.org/koji/taskinfo?taskID=7739321
Licensing is correct
rpmlint contains a warning for DOS line endings in README which can be fixed by
including the following BRs.
Add the following BRs
BR: perl(Pod::Readme)
BR: perl(Pod::Markdown)
As before, i think that "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {}
2>/dev/null \;" can be removed even for EPEL5 builds.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141390] Review Request: perl-DBIx-RunSQL - Run SQL commands from a file
https://bugzilla.redhat.com/show_bug.cgi?id=1141390 David Dick changed: What|Removed |Added Status|NEW |ASSIGNED CC||dd...@cpan.org Assignee|nob...@fedoraproject.org|dd...@cpan.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
