[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #13 from Fedora Update System --- nodejs-es5-shim-4.0.3-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #12 from Fedora Update System --- nodejs-es5-shim-4.0.3-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #11 from Fedora Update System --- nodejs-es5-shim-4.0.3-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Ralph Bean changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-09-17 11:12:05 --- Comment #10 from Ralph Bean --- Buildroot overrides created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #8 from Fedora Update System --- nodejs-es5-shim-4.0.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-es5-shim-4.0.3-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #9 from Fedora Update System --- nodejs-es5-shim-4.0.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-es5-shim-4.0.3-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #7 from Fedora Update System --- nodejs-es5-shim-4.0.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-es5-shim-4.0.3-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #6 from Jens Petersen --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Jens Petersen changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Ralph Bean --- New Package SCM Request === Package Name: nodejs-es5-shim Short Description: ECMAScript 5 compatibility shims for legacy JavaScript engines Upstream URL: https://npmjs.org/package/es5-shim Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Tom Hughes changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Tom Hughes --- Looks good. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #3 from Ralph Bean --- Sounds good. Here it is updated to run the 'npm minify' step. Spec URL: http://threebean.org/rpm/SPECS/nodejs-es5-shim.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-es5-shim-4.0.3-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 --- Comment #2 from Tom Hughes --- You should run the uglifyjs build step (from package.json) in %build but other than that it looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Tom Hughes changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@compton.nu Assignee|nob...@fedoraproject.org|t...@compton.nu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877
--- Comment #1 from Tom Hughes ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
Checking: nodejs-es5-shim-4.0.3-1.fc22.noarch.rpm
nodejs-es5-shim-4.0.3-1.fc22.src.rpm
nodejs-es5-shim.noarch: W: spelling-error %description -l en_US js
[Bug 1141877] Review Request: nodejs-es5-shim - ECMAScript 5 compatibility shims for legacy JavaScript engines
https://bugzilla.redhat.com/show_bug.cgi?id=1141877 Ralph Bean changed: What|Removed |Added Blocks||1141878 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1141878 [Bug 1141878] Review Request: nodejs-es6-transpiler - es6 -> es5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
