[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Parag changed: What|Removed |Added Blocks||1142050 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1142050 [Bug 1142050] Review Request: nodejs-seq - An asynchronous flow control library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Parag changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #1 from Parag --- Moved to new location Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-chainsaw.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-chainsaw-0.1.0-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Tomas Hrcka changed: What|Removed |Added Status|NEW |ASSIGNED CC||thr...@redhat.com Assignee|nob...@fedoraproject.org|thr...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #2 from Tomas Hrcka --- can you please use License file included in upstream git repository? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #3 from Parag --- Tomas, you sure you are seeing it different. I just downloaded upstream license file as written in Source1 of spec $ wget https://raw.githubusercontent.com/substack/node-chainsaw/master/LICENSE --2014-10-22 10:47:47-- https://raw.githubusercontent.com/substack/node-chainsaw/master/LICENSE Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 23.235.43.133 Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|23.235.43.133|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 165 [text/plain] Saving to: ‘LICENSE’ 100%[==>] 165 --.-K/s in 0s 2014-10-22 10:47:51 (10.1 MB/s) - ‘LICENSE’ saved [165/165] $ sha256sum ./LICENSE 55bf9819f3d339140d1b363058254c6c75a03159fc7d875b72600e76ebd3f038 ./LICENSE sha256sum ../SOURCES/LICENSE 55bf9819f3d339140d1b363058254c6c75a03159fc7d875b72600e76ebd3f038 ../SOURCES/LICENSE I see both are same and the srpm already included it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #4 from Tomas Hrcka --- sorry wrong bz :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Tomas Hrcka changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Tomas Hrcka --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/thrcka/1142049-nodejs-chainsaw/licensecheck.txt [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. = EXTRA items = Generic: [x]: Rpmlint is run on all i
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Parag changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Parag --- Thank you for the above package review. New Package SCM Request === Package Name: nodejs-chainsaw Short Description: Build chainable fluent interfaces the easy way Upstream URL: https://github.com/substack/node-chainsaw Owners: pnemade Branches: f20 f21 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #8 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-chainsaw-0.1.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #9 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-chainsaw-0.1.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #10 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-chainsaw-0.1.0-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Parag changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Parag --- Package Change Request == Package Name: nodejs-chainsaw New Branches: f19 el6 Owners: pnemade -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #14 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-chainsaw-0.1.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #15 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-chainsaw-0.1.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 --- Comment #16 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-chainsaw-0.1.0-1.1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-chainsaw-0.1.0-1.fc2 ||0 Resolution|--- |ERRATA Last Closed||2014-10-31 21:31:40 --- Comment #17 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-chainsaw-0.1.0-1.fc2 |nodejs-chainsaw-0.1.0-1.fc2 |0 |1 --- Comment #18 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-chainsaw-0.1.0-1.fc2 |nodejs-chainsaw-0.1.0-1.fc1 |1 |9 --- Comment #19 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-chainsaw-0.1.0-1.fc1 |nodejs-chainsaw-0.1.0-1.el7 |9 | --- Comment #20 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142049] Review Request: nodejs-chainsaw - Build chainable fluent interfaces the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1142049 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-chainsaw-0.1.0-1.el7 |nodejs-chainsaw-0.1.0-1.1.e ||l6 --- Comment #21 from Fedora Update System --- nodejs-chainsaw-0.1.0-1.1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review