[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-pegjs-0.8.0-2.fc21 |nodejs-pegjs-0.8.0-2.2.el6 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-pegjs-0.8.0-2.2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-pegjs-0.8.0-2.fc20 |nodejs-pegjs-0.8.0-2.fc19 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-pegjs-0.8.0-2.fc19 |nodejs-pegjs-0.8.0-2.fc21 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-pegjs-0.8.0-2.fc20 Resolution|--- |ERRATA Last Closed||2014-11-06 21:33:54 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-pegjs-0.8.0-2.1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Parag pnem...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Parag pnem...@redhat.com --- Package Change Request == Package Name: nodejs-pegjs New Branches: f19 el6 Owners: pnemade -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-pegjs-0.8.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-pegjs-0.8.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #5 from Parag pnem...@redhat.com --- updated package Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-pegjs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-pegjs-0.8.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Tom Hughes t...@compton.nu --- Well you do actually need to add %tap test/*.js to the %check before it will run the tests ;-) It turns out that they need npm(falafel) though, which isn't packaged yet, so you probably don't want to do that just yet. I was looking at packaging that for something else last night, so hopefully it will be available soon... I confirmed by hand that they pass though, so that is good. With that I think we can approve this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Parag pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Parag pnem...@redhat.com --- Thank you Tom for the review. I will add it in %check as a comment. New Package SCM Request === Package Name: nodejs-pegjs Short Description: Parser generator for JavaScript Upstream URL: https://github.com/dmajda/pegjs Owners: pnemade Branches: f20 f21 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-pegjs-0.8.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-pegjs-0.8.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-pegjs-0.8.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Tom Hughes t...@compton.nu changed: What|Removed |Added Status|NEW |ASSIGNED CC||t...@compton.nu Assignee|nob...@fedoraproject.org|t...@compton.nu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658
--- Comment #3 from Tom Hughes t...@compton.nu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 11 files have unknown license. Detailed output of
licensecheck in /home/tom/1144658-nodejs-pegjs/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 143360 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
Checking: nodejs-pegjs-0.8.0-1.fc22.noarch.rpm
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #4 from Tom Hughes t...@compton.nu --- Couple of things... First, you're not including the command line interface (bin/pegjs) in the package, so you might want to think about adding that. Second, you may want to consider using github as the source so that you get the tests and can run them in %check. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 --- Comment #2 from Parag pnem...@redhat.com --- Moved to new location Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-pegjs.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-pegjs-0.8.0-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Parag pnem...@redhat.com changed: What|Removed |Added Summary|Review Request: - |Review Request: ||nodejs-pegjs - Parser ||generator for JavaScript --- Comment #1 from Parag pnem...@redhat.com --- Spec URL: https://paragn.fedorapeople.org/fedora-work/SPECS/nodejs-pegjs.spec SRPM URL: https://paragn.fedorapeople.org/fedora-work/SRPMS/nodejs-pegjs-0.8.0-1.fc21.src.rpm Description: PEG.js is a simple parser generator for JavaScript that produces fast parsers with excellent error reporting. You can use it to process complex data or computer languages and build transformers, interpreters, compilers and other tools easily. Fedora Account System Username: pnemade -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144658] Review Request: nodejs-pegjs - Parser generator for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1144658 Parag pnem...@redhat.com changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
