[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 --- Comment #6 from Thomas Spura toms...@fedoraproject.org --- (In reply to Robin Lee from comment #5) SRPM URL: http://tomspur.fedorapeople.org/review/zeromq2-2.2.0-12.fc20.src.rpm This URL returns 404. Should be working now. I scp'ed the wrong file there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Robin Lee robinlee.s...@gmail.com --- A typo 'obsolted' in the latest changelog. Package approved by cheeselee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 --- Comment #9 from Thomas Spura toms...@fedoraproject.org --- (In reply to Robin Lee from comment #7) A typo 'obsolted' in the latest changelog. Package approved by cheeselee Thanks again. I'll fix the typo, when importing to git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Thomas Spura toms...@fedoraproject.org --- New Package SCM Request === Package Name: zeromq2 Short Description: Software library for fast, message-based applications - Version 2 Upstream URL: http://www.zeromq.org Owners: tomspur Branches: f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-11-14 08:41:24 --- Comment #11 from Thomas Spura toms...@fedoraproject.org --- Building in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8142278 Will wait for the imports into other branches, when the exact transition of the depending packages is clear. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100
Robin Lee robinlee.s...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|robinlee.s...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robin Lee robinlee.s...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[-]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100
--- Comment #4 from Thomas Spura toms...@fedoraproject.org ---
Many thanks for the review.
(In reply to Robin Lee from comment #3)
[!]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
removed
= SHOULD items =
Generic:
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Still no %clean there, as it is not needed anymore.
= EXTRA items =
Generic:
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
sed'ed in %prep.
AutoTools: Obsoleted m4s found
--
AC_PROG_LIBTOOL found in: zeromq-2.2.0/configure.in:55
AM_CONFIG_HEADER found in: zeromq-2.2.0/configure.in:13
see above
= Extra items ==
[!] zeromq2-devel should also conflict zeromq3-devel
[!] Summary and description should reflect that this package is for ZeroMQ 2.
both fixed.
changelog:
- cleaning ups according to review (#1145100)
- remove %%defattr
- mention version 2 in summary and description
- remove obsolted autotools m4s
Spec URL: http://tomspur.fedorapeople.org/review/zeromq2.spec
SRPM URL: http://tomspur.fedorapeople.org/review/zeromq2-2.2.0-12.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 --- Comment #5 from Robin Lee robinlee.s...@gmail.com --- SRPM URL: http://tomspur.fedorapeople.org/review/zeromq2-2.2.0-12.fc20.src.rpm This URL returns 404. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 --- Comment #2 from Thomas Spura toms...@fedoraproject.org --- I think both approaches are possible in principle. Yet, in my opinion adding compat packages to the same spec is not as legible as two different packages, and you always rebuild all packages, if you change anything in your spec file as you need to bump your globrelease... I cannot find a guideline, that explicitly forbids your approach, but I would have thought so... So in summary: Yes I need this :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications
https://bugzilla.redhat.com/show_bug.cgi?id=1145100 Steve Traylen steve.tray...@cern.ch changed: What|Removed |Added CC||steve.tray...@cern.ch --- Comment #1 from Steve Traylen steve.tray...@cern.ch --- Do you actually need this? In the past I have rolled the compat package into the normal package. See http://pkgs.fedoraproject.org/cgit/activemq-cpp.git/tree/activemq-cpp.spec?h=el6 for example. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
