[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-flask-rstpages-0.3-3 ||.fc20 Resolution|--- |ERRATA Last Closed||2014-12-04 01:25:10 --- Comment #10 from Fedora Update System --- python-flask-rstpages-0.3-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- python-flask-rstpages-0.3-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 --- Comment #8 from Fedora Update System --- python-flask-rstpages-0.3-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-flask-rstpages-0.3-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Richard Marko changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Richard Marko --- New Package SCM Request === Package Name: python-flask-rstpages Short Description: Adds support for reStructuredText to a Flask application Upstream URL: https://github.com/saimn/flask-rstpages/ Owners: rmarko Branches: f20 f21 el6 epel7 InitialCC: rmarko -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Marek Bryša changed: What|Removed |Added CC||mbr...@redhat.com Assignee|karlthe...@gmail.com|mbr...@redhat.com Flags||fedora-review+ --- Comment #5 from Marek Bryša --- Apparently, all the issues pointed out have been fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 --- Comment #4 from Richard Marko --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Richard Marko changed: What|Removed |Added CC||rma...@redhat.com --- Comment #3 from Richard Marko --- Thank you both. Updated: Spec URL: https://rmarko.fedorapeople.org/packages/python-flask-rstpages.spec SRPM URL: https://rmarko.fedorapeople.org/packages/python-flask-rstpages-0.3-2.fc20.src.rpm Diff of the spec files: https://rmarko.fedorapeople.org/packages/python-flask-rstpages.diff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529
hgue...@redhat.com changed:
What|Removed |Added
CC||hgue...@redhat.com
--- Comment #2 from hgue...@redhat.com ---
ACK, thanks Dmitry, this was a good review.
I would consider the "0%{?with_python3}" as mandatory as i
@Richard: please do the changes requested.
The Provide: Flask-RSTPages is not mandatory, but that's a good idea
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529
Dmitry Tantsur changed:
What|Removed |Added
CC||divius.ins...@gmail.com
--- Comment #1 from Dmitry Tantsur ---
Hi! Some comments to this package:
1. Inconsistent python2 and python3 packages naming (note case):
python-flask-rstpages-0.3-1.fc20.noarch.rpm
python3-Flask-RSTPages-0.3-1.fc20.noarch.rpm
2. sphinx-build-3.3 docs html
I suggest using just sphinx-build-3 (it's also present). There's no point in
assuming specific version of Python 3.
E.g. in F21 your package fails to build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7811395
3. You should BuildRequire python[3]-flask, otherwise Sphinx fails with
ImportError on building docs.
4. You have this line (likely due to following Python packaging guide):
find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|'
but the guide also states symmetric:
find -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|'
after Python 3 part.
5. %doc html docs/_themes/LICENSE LICENSE
Here one LICENSE file is overwriting another, so only the last is actually
included.
Smaller things:
1. Somewhere your spec is using
%if %{?with_python3}
somewhere
%if 0%{?with_python3}
I guess it should be just
%if 0%{?with_python3}
everywhere, but at least it should be consistent.
2. Just a suggestion: won't it be good to
Provide: Flask-RSTPages
so that people can easily find it?
F20 build for reference:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7811450
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
