[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Fedora Update System changed: What|Removed |Added Fixed In Version|python-XStatic-Bootstrap-SC |python-XStatic-Bootstrap-SC |SS-3.2.0.0-1.el7|SS-3.2.0.0-1.fc21 --- Comment #13 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Fedora Update System changed: What|Removed |Added Fixed In Version|python-XStatic-Bootstrap-SC |python-XStatic-Bootstrap-SC |SS-3.2.0.0-1.fc20 |SS-3.2.0.0-1.el7 --- Comment #12 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-XStatic-Bootstrap-SC ||SS-3.2.0.0-1.fc20 Resolution|--- |ERRATA Last Closed||2014-10-26 23:26:02 --- Comment #11 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 --- Comment #9 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-XStatic-Bootstrap-SCSS-3.2.0.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 --- Comment #8 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-XStatic-Bootstrap-SCSS-3.2.0.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 --- Comment #7 from Fedora Update System --- python-XStatic-Bootstrap-SCSS-3.2.0.0-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-XStatic-Bootstrap-SCSS-3.2.0.0-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 --- Comment #6 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Kevin Fenzi changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Matthias Runge changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Matthias Runge --- New Package SCM Request === Package Name: python-XStatic-Bootstrap-SCSS Short Description: Bootstrap-SCSS (XStatic packaging standard) Upstream URL: http://getbootstrap.com/ Owners: mrunge Branches: epel7 f20 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Alan Pevec changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Alan Pevec --- Ok, strings are not attached, it's just a nag to include a link back :) re-approving -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Matthias Runge changed: What|Removed |Added Flags|needinfo?(mru...@redhat.com | |) | --- Comment #3 from Matthias Runge --- http://glyphicons.com/license/ says: ... License for GLYPHICONS Halflings in Twitter Bootstrap GLYPHICONS Halflings are also a part of Bootstrap from Twitter, and they are released under the same license as Bootstrap. While you are not required to include attribution on your Bootstrap-based projects, I would certainly appreciate a visible link back to GLYPHICONS.com in any place you find appropriate (footer, docs, etc). In my understanding, the author appreciates to include a link, but it's not a requirement. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Alan Pevec changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #2 from Alan Pevec --- > [!]: Avoid bundling fonts in non-fonts packages. > Note: Package contains font files > BUT /usr/share/javascript/bootstrap_scss/fonts/ are not meant to be > used as general purpose fonts, so waiving this. This might be blocking issue after all, http://getbootstrap.com/components/ says: "Includes 200 glyphs in font format from the Glyphicon Halflings set. Glyphicons Halflings are normally not available for free, but their creator has made them available for Bootstrap free of cost. As a thank you, we only ask that you include a link back to Glyphicons whenever possible." This needs to be raised with fedora-legal, exact wording of boostrap/glyphicons agreement is unknown to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956
Alan Pevec changed:
What|Removed |Added
CC||mru...@redhat.com
Flags||fedora-review+
||needinfo?(mru...@redhat.com
||)
--- Comment #1 from Alan Pevec ---
APPROVED
xstatic/pkg ownership will be fixed in python-XStatic update.
As with all xstatic packages, please request that xstatic upstream keeps
license files in the tarball.
Also to be fixed upstream is
Home-page: http://getbootstrap.org/
in PKG-INFO, it's bogus parked domain, correct is getbootstrap.com
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
See above, getbootstrap.com claims MIT.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-packages/xstatic/pkg
TO BE fixed in python-XStatic update
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/xstatic/pkg
TO BE fixed in python-XStatic update
[x]: Package contains no bundled libraries without FPC exception.
Contains javascript files which have exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
BUT /usr/share/javascript/bootstrap_scss/fonts/ are not meant to be
used as general purpose fonts, so waiving this.
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
As noted above, this needs to be fixed for xstatic packages.
[x]: Final provides and requires are
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Alan Pevec changed: What|Removed |Added Status|NEW |ASSIGNED CC||ape...@gmail.com Assignee|nob...@fedoraproject.org|ape...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Matthias Runge changed: What|Removed |Added Blocks||1134565 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1134565 [Bug 1134565] Tracker bug for Horizon Juno release -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
