[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nagios-plugins-fts-3.2.0-1. ||el5 Resolution|--- |ERRATA Last Closed||2014-10-28 06:59:22 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nagios-plugins-fts-3.2.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nagios-plugins-fts-3.2.0-1. |nagios-plugins-fts-3.2.0-1. |el5 |el6 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nagios-plugins-fts-3.2.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nagios-plugins-fts-3.2.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- nagios-plugins-fts-3.2.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nagios-plugins-fts-3.2.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- nagios-plugins-fts-3.2.0-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/nagios-plugins-fts-3.2.0-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 michal.si...@cern.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from michal.si...@cern.ch --- New Package SCM Request === Package Name: nagios-plugins-fts Short Description: This package provides the nagios probes for FTS3. Upstream URL: https://grid-deployment.web.cern.ch/grid-deployment/dms/fts3/epel_release/nagios-plugins-fts-3.2.0-1.el6.src.rpm Owners: simonm Branches: el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch changed: What|Removed |Added Status|NEW |ASSIGNED CC||alejandro.alvarez.ayllon@ce ||rn.ch Assignee|nob...@fedoraproject.org|alejandro.alvarez.ayllon@ce ||rn.ch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178
Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #2 from Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch ---
Hi,
I confirm the builds works
http://koji.fedoraproject.org/koji/taskinfo?taskID=7774935
http://koji.fedoraproject.org/koji/taskinfo?taskID=7774941
http://koji.fedoraproject.org/koji/taskinfo?taskID=7775298
rpmlint output
# rpmlint nagios-plugins-fts-3.2.0-1.el6.src.rpm
nagios-plugins-fts.src: W: malformed-fedora-conditional
nagios-plugins-fts.spec:22
nagios-plugins-fts.src: W: malformed-rhel-conditional
nagios-plugins-fts.spec:22
nagios-plugins-fts.src: W: malformed-rhel-conditional
nagios-plugins-fts.spec:32
nagios-plugins-fts.src: W: malformed-fedora-conditional
nagios-plugins-fts.spec:45
nagios-plugins-fts.src: W: malformed-rhel-conditional
nagios-plugins-fts.spec:45
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
# rpmlint nagios-plugins-fts.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
And checklist
MUST
[OK] The package must be named according to the Package Naming Guidelines.
[OK] Package does not use a name that already exist.
[OK] The spec file name must match the base package %{name}, in the format
%{name}.spec
[OK] Spec file lacks Packager, Vendor, PreReq tags.
[OK] Changelog in prescribed format.
[OK] The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
[OK] The License field in the package spec file must match the actual license.
[OK] The spec file must be written in American English.
[OK] The spec file for the package MUST be legible.
[--] If a rename, provides/obsoletes is specified.
[--] The spec file MUST handle locales properly.
[--] Every binary RPM package which stores shared library files in any of the
dynamic linker's default paths, must call ldconfig in %post and %postun.
[OK] If the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package must be
included in %doc.
[--] -debuginfo package or justification otherwise.
[--] Development files must be in a -devel package.
[--] Static libraries must be in a -static package.
[--] Devel packages must require the base package using a fully versioned
dependency
[--] Large documentation files must go in a -doc subpackage.
[OK] The sources used to build the package must match the upstream source, as
provided in the spec URL.
[OK] The package must contain code, or permissable content.
[ ] Package obeys FHS, except libexecdir and /usr/target.
[OK] Packages must NOT contain any .la libtool archives.
[OK] Packages must not own files or directories already owned by other packages
[--] Packages containing GUI applications must include a %{name}.desktop file.
[--] A Fedora package must not list a file more than once in the spec file's
%files listings.
[OK] A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
[OK] Packages must NOT bundle copies of system libraries
[--] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package.
[OK] All filenames in rpm packages must be valid UTF-8.
[OK] Permissions on files must be set properly.
[OK] Each package must consistently use macros.
[OK] No external kernel modules
[OK] No inclusion of pre-built binaries or libraries
[OK] No need for external bits
[OK] All build dependencies must be listed in BuildRequires.
[--] If a package includes something as %doc, it must not affect the runtime of
the application.
[--] %build honors applicable compiler flags or justifies otherwise.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags
[OK] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[--] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[OK] Package installs properly.
SHOULD
==
[--] All patches have an upstream bug link or comment
[OK] The source package does not include license text(s) as a separate file
from upstream.
[OK] No PreReq
[OK] %makeinstall is not used
[OK] Timestamp is preserved
[OK] Parallel make
[--] Subpackages other than devel should require the base package using a fully
versioned dependency.
[OK] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[--] The placement of pkgconfig(.pc) files should be in
[Bug 1149178] Review Request: nagios-plugins-fts - provides the nagios probes for FTS3
https://bugzilla.redhat.com/show_bug.cgi?id=1149178 --- Comment #1 from michal.si...@cern.ch --- I would appreciate a review so that I can get nagios-plugins-fts into EPEL5 and EPEL6. Koji builds for epel5, epel6 and rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=7755603 http://koji.fedoraproject.org/koji/taskinfo?taskID=7755628 http://koji.fedoraproject.org/koji/taskinfo?taskID=7755640 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
