[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Igor Gnatenko changed: What|Removed |Added Alias|telepathy-qt| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||telepathy-qt-0.9.5-2.fc21 Resolution|--- |ERRATA Last Closed||2014-10-12 09:55:27 --- Comment #10 from Fedora Update System --- telepathy-qt-0.9.5-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- telepathy-qt-0.9.5-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 --- Comment #8 from Fedora Update System --- telepathy-qt-0.9.5-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/telepathy-qt-0.9.5-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Rex Dieter --- imported, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Rex Dieter changed: What|Removed |Added Alias||telepathy-qt Flags||fedora-cvs? --- Comment #4 from Rex Dieter --- thanks. New Package SCM Request === Package Name: telepathy-qt Short Description: High-devel bindings for Telepathy Upstream URL: http://telepathy.freedesktop.org/doc/telepathy-qt/ Owners: jreznik rdieter jgrulich mck182 rnovacek Branches: f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 --- Comment #5 from Rex Dieter --- typo alert, lets try again New Package SCM Request === Package Name: telepathy-qt Short Description: High-level bindings for Telepathy Upstream URL: http://telepathy.freedesktop.org/doc/telepathy-qt/ Owners: jreznik rdieter jgrulich mck182 rnovacek Branches: f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Jan Grulich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jan Grulich --- Looks good to me and I don't see any major issue. Having -doc or -static subpackages is not necessary. Anyway this is just a renamed package extended with a build for Qt5 which means it was already reviewed once so I'm sure it could be approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289
--- Comment #2 from Jan Grulich ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: telepathy-qt4-devel, telepathy-qt5-devel. Does
not provide -static: telepathy-qt4-devel, telepathy-qt5-devel.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
or number of files.
Note: Documentation size is 5079040 bytes in 12 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "Unknown or generated". 166 files have unknown
license. Detailed output of licensecheck in
/home/jgrulich/rpmbuild/1149289-telepathy-qt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib64/cmake(qt5-qtbase-
devel, kdevelop-pg-qt-devel, pulseaudio-libs-devel, phonon-qt5-devel,
phonon-devel, grantlee-devel, cmake)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{nam
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 Jan Grulich changed: What|Removed |Added CC||jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149289] Review Request: telepathy-qt - High-level bindings for Telepathy
https://bugzilla.redhat.com/show_bug.cgi?id=1149289 --- Comment #1 from Rex Dieter --- Improvements over the existing telepathy-qt4 fedpkg module include: %changelog * Fri Oct 03 2014 Rex Dieter 0.9.5-2 - bump deps for newer farstream/gst1 - Qt5 support - rename base pkg to telepathy-qt (to match upstream), but... - keep subpkg names the same (telepathy-qt4), for simple/obvious upgrade path -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
