[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-lazyarray-0.2.7-3.fc ||21 Resolution|--- |ERRATA Last Closed||2014-10-14 00:41:06 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-lazyarray-0.2.7-3.fc21, python-quantities-0.10.1-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-lazyarray-0.2.7-3.fc21, python-quantities-0.10.1-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-lazyarray-0.2.7-3.fc21,python-quantities-0.10.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-lazyarray-0.2.7-3.fc21,python-quantities-0.10.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-lazyarray-0.2.7-3.fc20,python-quantities-0.10.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-lazyarray-0.2.7-3.fc20,python-quantities-0.10.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Blocks||1150099 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1150099 [Bug 1150099] Review Request: python-neo - Represent electrophysiology data in Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090
--- Comment #1 from Antonio Trande anto.tra...@gmail.com ---
- None License file is provided and packaged.
BSD license is just indicated in PKG-INFO file.
- test_squeeze fails, even if it seems a known problem
https://github.com/python-quantities/python-quantities/pull/57
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 136 files have unknown license. Detailed output
of licensecheck in /home/sagitter/1150090-python-
quantities/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.4, /usr/lib/python3.4/site-
packages
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.4/site-packages,
/usr/lib/python3.4
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Python:
[-]: Binary eggs must be removed in %prep
Note: Test run failed
[x]: Python eggs must not download any dependencies during the build process.
Note: Test run failed
[x]: A package which is used by another package via an egg interface should
provide egg info.
Note: Test run failed
[x]: Package meets the Packaging Guidelines::Python
Note: Test run failed
[x]: Package contains BR: python2-devel or python3-devel
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-quantities
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 --- Comment #2 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Antonio, Thank you for the review. I've added a license that upstream has in it's git repo. This will probably be included in the next release. As for the test, I can push an update once upstream fixes it. There isn't much I can do at the moment about it. Updated spec/srpm: https://ankursinha.fedorapeople.org/python-quantities/python-quantities.spec https://ankursinha.fedorapeople.org/python-quantities/python-quantities-0.10.1-1.fc22.src.rpm Thanks, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Antonio Trande anto.tra...@gmail.com --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Thanks for the quick review Antonio :) New Package SCM Request === Package Name: python-quantities Short Description: Support for physical quantities with units, based on numpy Upstream URL: https://pythonhosted.org/quantities/ Owners: ankursinha Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
