[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Fedora Update System changed: What|Removed |Added Fixed In Version|gr-iqbal-0.37.2-3.fc20 |gr-iqbal-0.37.2-3.el7 --- Comment #12 from Fedora Update System --- gr-iqbal-0.37.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Fedora Update System changed: What|Removed |Added Fixed In Version|gr-iqbal-0.37.2-3.fc21 |gr-iqbal-0.37.2-3.fc20 --- Comment #11 from Fedora Update System --- gr-iqbal-0.37.2-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Fedora Update System changed: What|Removed |Added Fixed In Version||gr-iqbal-0.37.2-3.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- gr-iqbal-0.37.2-3.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #9 from Fedora Update System --- gr-iqbal-0.37.2-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/gr-iqbal-0.37.2-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #8 from Fedora Update System --- gr-iqbal-0.37.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gr-iqbal-0.37.2-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #7 from Fedora Update System --- gr-iqbal-0.37.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gr-iqbal-0.37.2-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jaroslav Škarvada changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-10-16 07:58:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jaroslav Škarvada changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jaroslav Škarvada --- New Package SCM Request === Package Name: gr-iqbal Short Description: GNURadio block for suppressing IQ imbalance Upstream URL: http://cgit.osmocom.org/gr-iqbal/ Owners: jskarvad Branches: f20 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jan Synacek changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Jan Synacek --- I don't see any more problems, approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #3 from Jaroslav Škarvada --- Thanks for the review, updated version: Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-iqbal.spec SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-iqbal-0.37.2-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666
--- Comment #2 from Jan Synacek ---
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Swig wrapper libraries, I don't see a problem with that.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gnuradio,
/usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks
These are owned by gnuradio, which is required for this package.
[!]: Reviewer should test that the package builds in mock.
It builds. I've built the package myself, because one of the required
libraries wasn't available in the rawhide build root (it's built
properly though, just not propagated yet).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-iqbal-
devel , gr-iqbal-doc
ACTION REQUIRED: Please, add %{?_isa} to the devel subpackage.
Rpmlint
---
Checking: gr-iqbal-0.37.2-1.fc22.x86_64.rpm
gr-iqbal-devel-0.37.2-1.fc22.x86_64.rpm
gr-iqbal-doc-0.37.2-1.fc22.noarch.rpm
gr-iqbal-0.37.2-1.fc20.src.rpm
gr-iqbal-devel.x86_64: W: only-non-binary-in-usr-lib
gr-iqbal-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
No problem, the first warning is a known bug.
Unversioned so-files
gr-iqbal:
/usr/lib64/python2.7/site-packages/gnuradio/iqbalance/_iqbalance_swig.so
Swig wrappers, no problem.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666
--- Comment #1 from Jan Synacek ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package contains BR: python2-devel or python3-devel
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v3 or later)", "Unknown or generated". 7 files have unknown
license. Detailed output of licensecheck in /home/jsynacek/work/reviews
/gr-iqbal/review-gr-iqbal/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gnuradio,
/usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license t
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jan Synacek changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jsyna...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jan Synacek changed: What|Removed |Added Status|NEW |ASSIGNED CC||jsyna...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Bug 1150666 depends on bug 1150653, which changed state. Bug 1150653 Summary: Review Request: libosmo-dsp - A library with SDR DSP primitives https://bugzilla.redhat.com/show_bug.cgi?id=1150653 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jaroslav Škarvada changed: What|Removed |Added Depends On||1150653 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1150653 [Bug 1150653] Review Request: libosmo-dsp - A library with SDR DSP primitives -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
