[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||drumstick-1.0.0-1.fc21 Resolution|--- |ERRATA Last Closed||2014-12-06 05:18:15 --- Comment #18 from Fedora Update System --- drumstick-1.0.0-1.fc21, rtmidi-2.1.0-1.fc21, kmid2-2.4.0-8.fc21, kmetronome-1.0.0-1.fc21, vmpk-0.6.0-1.fc21, drumstick0-0.5.0-13.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- Package drumstick-1.0.0-1.fc21, rtmidi-2.1.0-1.fc21, kmid2-2.4.0-8.fc21, kmetronome-1.0.0-1.fc21, vmpk-0.6.0-1.fc21, drumstick0-0.5.0-13.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing drumstick-1.0.0-1.fc21 rtmidi-2.1.0-1.fc21 kmid2-2.4.0-8.fc21 kmetronome-1.0.0-1.fc21 vmpk-0.6.0-1.fc21 drumstick0-0.5.0-13.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-13332/rtmidi-2.1.0-1.fc21,kmid2-2.4.0-8.fc21,kmetronome-1.0.0-1.fc21,vmpk-0.6.0-1.fc21,drumstick0-0.5.0-13.fc21,drumstick-1.0.0-1.fc21 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 --- Comment #16 from Fedora Update System --- drumstick-1.0.0-1.fc21, rtmidi-2.1.0-1.fc21, kmid2-2.4.0-8.fc21, kmetronome-1.0.0-1.fc21, vmpk-0.6.0-1.fc21, drumstick0-0.5.0-13.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/FEDORA-2014-13332/rtmidi-2.1.0-1.fc21,kmid2-2.4.0-8.fc21,kmetronome-1.0.0-1.fc21,vmpk-0.6.0-1.fc21,drumstick0-0.5.0-13.fc21,drumstick-1.0.0-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Robin Lee changed: What|Removed |Added Flags||fedora-cvs? --- Comment #14 from Robin Lee --- New Package SCM Request === Package Name: drumstick0 Short Description: C++/Qt4 wrapper around the ALSA library sequencer interface Upstream URL: http://drumstick.sourceforge.net/ Owners: cheeselee Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Thomas Spura changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #13 from Thomas Spura --- Looks fine now. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210
--- Comment #12 from Robin Lee ---
(In reply to Thomas Spura from comment #11)
> Issues:
> - Why is there "Conflicts: %{realname}-devel > 0.5.0"? Doesn't it also
> conflict if it is any other version of the real-devel package?
Fixed.
> - "Large" doc in -devel (this is a should, see below)
I will prefer not to change this for a compat package.
> - Requires is missing an %{?_isa}
Fixed
Spec URL: http://cheeselee.fedorapeople.org/drumstick0.spec
SRPM URL: http://cheeselee.fedorapeople.org/drumstick0-0.5.0-13.fc21.src.rpm
Changes:
- Removed conflicts versioning of devel subpackage
- Specified Requires of devel subpackage
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210
Thomas Spura changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||toms...@fedoraproject.org
Assignee|nob...@fedoraproject.org|toms...@fedoraproject.org
Flags||fedora-review?
--- Comment #11 from Thomas Spura ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
- Why is there "Conflicts: %{realname}-devel > 0.5.0"? Doesn't it also conflict
if it is any other version of the real-devel package?
- "Large" doc in -devel (this is a should, see below)
- Requires is missing an %{?_isa}
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)", "Unknown or generated". 1 files have unknown
license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/mime,
/usr/share/mime/packages
[!x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/include/drumstick
(drumstick-devel)
As this is a compat package for drumstick-devel, this is ignorable.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[!x]: Package does not generate any conflict.
Only expected conflicts
[x]: Package obeys FHS, except libexecdir and /usr/target.
[.]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[!]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
The devel package is ~2MB, because of html files. I'd leave that out as it is
enough to have them in the main drumstick-devel package.
This is a should only.
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 --- Comment #10 from Robin Lee --- Spec URL: http://cheeselee.fedorapeople.org/drumstick0.spec SRPM URL: http://cheeselee.fedorapeople.org/drumstick0-0.5.0-12.fc21.src.rpm Changes: - Update the summary of the devel subpackage - Fix Requires of the devel subpackage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210
--- Comment #9 from Kevin Kofler ---
And the -devel subpackage also has this:
> Requires: %{realname} = %{version}-%{release}
which must be:
Requires: %{name} = %{version}-%{release}
instead. Right now, the package is not installable, so the fedora-review tool
fails. Therefore, I can only proceed with the review if this is fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210
--- Comment #8 from Kevin Kofler ---
> Summary: Developer files for %{realname}
Please change that to either:
Summary: Developer files for %{name}
or:
Summary: Developer files for %{realname} 0.x
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Robin Lee changed: What|Removed |Added Flags|needinfo?(robinlee.sysu@gma | |il.com) | --- Comment #7 from Robin Lee --- Spec URL: http://cheeselee.fedorapeople.org/drumstick0.spec SRPM URL: http://cheeselee.fedorapeople.org/drumstick0-0.5.0-11.fc20.src.rpm Change: - rename to drumstick0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155210] Review Request: drumstick0 - C++/Qt4 wrapper around the ALSA library sequencer interface
https://bugzilla.redhat.com/show_bug.cgi?id=1155210 Kevin Kofler changed: What|Removed |Added CC||robinlee.s...@gmail.com Summary|Review Request: |Review Request: drumstick0 |compat-drumstick - C++/Qt4 |- C++/Qt4 wrapper around |wrapper around the ALSA |the ALSA library sequencer |library sequencer interface |interface Alias|compat-drumstick|drumstick0 Flags||needinfo?(robinlee.sysu@gma ||il.com) --- Comment #6 from Kevin Kofler --- I think drumstick0 is the most logical option, can you please post an updated specfile and SRPM? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
