[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-11-20 12:58:44



--- Comment #11 from Rex Dieter  ---
imported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826



--- Comment #10 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

 Blocks||1157402 (liblxqt)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1157402
[Bug 1157402] Review Request: liblxqt - Core LXQT library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #9 from Rex Dieter  ---
New Package SCM Request
===
Package Name: lxqt-globalkeys
Short Description: Global keys utility for LXQt desktop suite
Upstream URL: http://lxqt.org/
Owners: heliocastro rdieter tieugene
Branches: f20 f21 el6 epel7
InitialCC: heliocastro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826



--- Comment #8 from Helio Chissini de Castro  ---
New Package SCM Request
===
Package Name: lxqt-globalkeys
Short Description: Global keys utility for LXQt desktop suite
Upstream URL: http://lxqt.org/downloads/lxqt/0.8.0/lxqt-globalkeys-0.8.0.tar.xz
Owners: heliocastro rdieter tieugene
Branches: f20 f21 el6 epel7
InitialCC: heliocastro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826



--- Comment #7 from Helio Chissini de Castro  ---
Confirmed, it validates as well.
No need to run a second desktop-file-validte

License will be changed as enter in the SCM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Rex Dieter  ---
looks good, APPROVED.

2 small non-blocking nits:
* I'll have to verify if running desktop-file-edit effectively validates
.desktop files or not, else we ought to add an explicit -validate step
afterward.
* License: tag still says LGPLv2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826



--- Comment #5 from Helio Chissini de Castro  ---
Fixed in
https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys-0.8.0-4.fc21.src.rpm
https://heliocastro.fedorapeople.org/lxqt/lxqt-globalkeys.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?
   |needinfo?(rdie...@math.unl. |
   |edu)|



--- Comment #4 from Rex Dieter  ---
The build failures and directory ownership are liblxqt issues (should be fixed
now), not here

I was blind to this package needing scriptlets though, need to add:
* .desktop file validation
* ldconfig scriptlets

^^ consider those both MUST blockers items (revoking approval), please resubmit
updated .spec/srpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826



--- Comment #3 from Mamoru TASAKA  ---
* Does not build
  http://koji.fedoraproject.org/koji/taskinfo?taskID=8068598

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Mamoru TASAKA  changed:

   What|Removed |Added

 CC||mtas...@fedoraproject.org
  Flags||needinfo?(rdie...@math.unl.
   ||edu)



--- Comment #2 from Mamoru TASAKA  ---
*
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage
*
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries
*
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

 Blocks||1159841 (lxqt-runner)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1159841
[Bug 1159841] Review Request:  lxqt-runner - Application runner agent for
LXQt desktop suite
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Rex Dieter  ---
naming: ok

license: ok, but could be ammended to
Licence: LGPLv2+

sources: ok
884e0a66f978e58fd13401bcacab1dd7  lxqt-globalkeys-0.8.0.tar.xz

macros: ok

scriptlets: n/a, ok


clean, simple again,
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1159826] Review Request: lxqt-globalkeys - Global keys utility for LXQt desktop suite

2014-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1159826

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
Summary|Review Request:  -  |Review Request:
   |lxqt-globalkeys - Global|lxqt-globalkeys - Global
   |keys utility for LXQt   |keys utility for LXQt
   |desktop suite   |desktop suite
  Alias||lxqt-globalkeys
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review