[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sonar-3.2-2.fc21 Resolution|--- |ERRATA Last Closed||2015-01-25 21:35:45 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- sonar-3.2-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Michael Simacek msima...@redhat.com changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- sonar-3.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/sonar-3.2-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- sonar-3.2-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Michael Simacek msima...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Michael Simacek msima...@redhat.com --- Spec URL: https://msimacek.fedorapeople.org/sonar.spec SRPM URL: https://msimacek.fedorapeople.org/sonar-3.2-2.fc20.src.rpm Fixed license tag and installed the file. Removed sources under different licenses to make sure they don't end up in the RPM Split into subpackages Thank you for the review New Package SCM Request === Package Name: sonar Short Description: An open platform to manage code quality Upstream URL: http://www.sonarqube.org Owners: msimacek mizdebsk msrb Branches: f21 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 gil cattaneo punto...@libero.it changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 --- Comment #1 from gil cattaneo punto...@libero.it --- Available new releases, please consider upgrading https://github.com/SonarSource/sonarqube/releases/tag/5.0-M16 https://github.com/SonarSource/sonarqube/releases/tag/4.5.1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 --- Comment #2 from Michael Simacek msima...@redhat.com --- (In reply to gil cattaneo from comment #1) Available new releases, please consider upgrading https://github.com/SonarSource/sonarqube/releases/tag/5.0-M16 https://github.com/SonarSource/sonarqube/releases/tag/4.5.1 I'm aware of that, but we need sonar mainly as a dependency of gradle, which doesn't work with newer versions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814
gil cattaneo punto...@libero.it changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from gil cattaneo punto...@libero.it ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Please install COPYING copyright.txt files
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), MIT/X11 (BSD like), LGPL (v3 or later), GPL (v2 or
later), Unknown or generated. 1051 files have unknown license.
Detailed output of licensecheck in
/home/gil/1163814-sonar/licensecheck.txt
Please, change license tag in LGPLv3
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-metadata, /usr/share/maven-
poms/sonar
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/maven-poms/sonar,
/usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 --- Comment #4 from gil cattaneo punto...@libero.it --- Created attachment 957579 -- https://bugzilla.redhat.com/attachment.cgi?id=957579action=edit licensecheck.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 --- Comment #5 from gil cattaneo punto...@libero.it --- Found NON blocking issues: please, install COPYING copyright.txt files and change license tag in LGPLv3 (see attachment 957579). Fix before import APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Blocks||1163739 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1163739 [Bug 1163739] Review Request: gradle - Build automation tool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163814] Review Request: sonar - An open platform to manage code quality
https://bugzilla.redhat.com/show_bug.cgi?id=1163814 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added CC||mizde...@redhat.com Blocks||1163816 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1163816 [Bug 1163816] Review Request: sonar-runner - Default launcher to analyze a project with SonarQube -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
