[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #26 from Raphael Groner --- Right, the serious way to continue with a package review would be to use the github sources. Please feel free to use this request as base for a new attempt for another review request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Matthias Mailänder changed: What|Removed |Added CC||matth...@mailaender.name --- Comment #25 from Matthias Mailänder --- The OpenRA project received no patch for DotFuzzy so there was nothing to refuse. Dependency licensing issues were also not communicated to us. The problem has been resolved upstream https://github.com/kaluzhny/fuzzynet/blob/master/LICENSE 10 months prior to this post. See also https://github.com/OpenRA/OpenRA/issues/8264#issuecomment-276521734 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Bug 1166916 depends on bug 1220138, which changed state. Bug 1220138 Summary: EPEL's version of Mono is horrendously outdated with lots of vulns. [epel-all] https://bugzilla.redhat.com/show_bug.cgi?id=1220138 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2016-11-05 17:41:58 --- Comment #24 from Raphael Groner --- fuzzynet is nonfree. Upstream of OpenRA refused a patch to use DotFuzzy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #23 from Raphael Groner --- Maybe DotFuzzy is an alternatve, it's clearly licensed with LGPLv3+. https://github.com/MicheleBertoli/DotFuzzy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Whiteboard||NotReady --- Comment #22 from Raphael Groner --- The license issue is a clear blocker. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Bug 1166916 depends on bug 1221559, which changed state. Bug 1221559 Summary: Mono 4 https://bugzilla.redhat.com/show_bug.cgi?id=1221559 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #21 from Raphael Groner --- > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. Patch is to sign assembly. Otherwise gacutil refuses. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #20 from Raphael Groner --- @Matthias, can you please add valid license headers to fuzzynet sources and provide a license text file? Otherwise, we can not validate GPLv2. I guess GPLv3 is also okay - or any other newer version? @Gil, gacutil is intentional pointed to /usr/lib for all platforms. We do so for all mono packages. https://fedoraproject.org/wiki/Packaging:Mono#gacutil_in_a_spec_file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #19 from gil cattaneo --- ISSUES: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Sourceforge.net Please, use: Source0:http://downloads.sourceforge.net/fuzzynet/fuzzynet_1_2_0.zip Source1:http://downloads.sourceforge.net/fuzzynet/fuzzynet_1_2_0.chm [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. Please, ask upstream to add license header in those files where missing (see above c#18) [!]: Package consistently uses macros (instead of hard-coded directory names). gacutil -i %{libname}/bin/Debug/%{libname}.dll -f -package %{name} -root %{buildroot}/usr/lib Please use %{_libdir} [!]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #18 from gil cattaneo --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/gil/1166916-fuzzynet/licensecheck.txt Most of the source code files provides this header, but do not explain what license is applied /* * * fuzzynet: Fuzzy Logic Library for Microsoft .NET * Copyright (C) 2008 Dmitry Kaluzhny (kaluzhny_dmit...@mail.ru) * * */ These files are without license headers fuzzynet-1.2.0/CruiseControlSample/MainForm.Designer.cs fuzzynet-1.2.0/CruiseControlSample/MainForm.cs fuzzynet-1.2.0/CruiseControlSample/Program.cs fuzzynet-1.2.0/CruiseControlSample/Properties/AssemblyInfo.cs fuzzynet-1.2.0/CruiseControlSample/Properties/Resources.Designer.cs fuzzynet-1.2.0/CruiseControlSample/Properties/Settings.Designer.cs fuzzynet-1.2.0/FuzzyLogicLibrary/Properties/AssemblyInfo.cs fuzzynet-1.2.0/TipsSample/MainForm.Designer.cs fuzzynet-1.2.0/TipsSample/MainForm.cs fuzzynet-1.2.0/TipsSample/Program.cs fuzzynet-1.2.0/TipsSample/Properties/AssemblyInfo.cs fuzzynet-1.2.0/TipsSample/Properties/Resources.Designer.cs fuzzynet-1.2.0/TipsSample/Properties/Settings.Designer.cs [-]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. Impossible for me to determine whether the source code under the GPLv2 license as stated in http://sf.net/projects/fuzzynet [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). gacutil -i %{libname}/bin/Debug/%{libname}.dll -f -package %{name} -root %{buildroot}/usr/lib Please use %{_libdir} [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 716800 bytes in 215 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [x]: If the source package does not include license text
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #17 from Raphael Groner --- Right! Sorry for the typo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #16 from gil cattaneo --- ... Spec URL: https://raphgro.fedorapeople.org/review/openra/fuzzynet.spec SRPM URL: https://raphgro.fedorapeople.org/review/openra/fuzzynet-1.2.0-0.5.beta.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #15 from Raphael Groner --- We should set status to ASSIGNED. fedora-review flag does not make any sense without. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #14 from Raphael Groner --- (In reply to gil cattaneo from comment #13) > Hi > Again my apologize. I explained here [1] why i can't review immediately this > package. If, meanwhile, comes forward someone else then I have no problem to > leave review. > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1202231#c4 No problem. Take your time and thanks for your interest. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #13 from gil cattaneo --- Hi Again my apologize. I explained here [1] why i can't review immediately this package. If, meanwhile, comes forward someone else then I have no problem to leave review. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1202231#c4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #12 from Raphael Groner --- Spec URL: https://raphgro.fedorapeople.org/review/openra/fuzzynet.spec SRPM URL: https://raphgro.fedorapeople.org/review/openra/fuzzynet-1.2.0-0.5.beta.fc23.src.rpm %changelog * Sat May 14 2016 Raphael Groner <> - 1.2.0-0.5.beta - fix folder ownership - split pkgconfig into devel subpackage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Keywords|FutureFeature | Priority|low |medium Red Hat Bugzilla changed: What|Removed |Added Doc Type|Enhancement |Bug Fix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Keywords||FutureFeature Red Hat Bugzilla changed: What|Removed |Added Doc Type|Bug Fix |Enhancement -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Bug 1166916 depends on bug 1089426, which changed state. Bug 1089426 Summary: Fedora's version of Mono is horrendously outdated with lots of vulns. [fedora-all] https://bugzilla.redhat.com/show_bug.cgi?id=1089426 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #11 from Upstream Release Monitoring --- raphgro's scratch build of fuzzynet-1.2.0-0.4.beta.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11390816 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Flags|needinfo?(extras-qa@fedorap | |roject.org) | --- Comment #10 from Raphael Groner --- Spec URL: https://raphgro.fedorapeople.org/review/openra/fuzzynet.spec SRPM URL: https://raphgro.fedorapeople.org/review/openra/fuzzynet-1.2.0-0.4.beta.fc23.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=11390816 * Wed Oct 07 2015 Raphael Groner <> - 1.2.0-0.4.beta - rebuild with mono4 - use gacutil - sign assembly - replace dos2unix with iconv - replace b0rken chm2pdf (rhbz#1265419) with chmlib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1265419 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Alias||fuzzynet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Depends On||1221559 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1221559 [Bug 1221559] Mono 4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Bug 1166916 depends on bug 1089278, which changed state. Bug 1089278 Summary: Mono 3.4 https://bugzilla.redhat.com/show_bug.cgi?id=1089278 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Moez Roy changed: What|Removed |Added Depends On||1220138 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1220138 [Bug 1220138] EPEL's version of Mono is horrendously outdated with lots of vulns. [epel-all] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Blocks||1159091 Depends On|1159091 |1089278, 1089426 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089278 [Bug 1089278] Mono 3.4 https://bugzilla.redhat.com/show_bug.cgi?id=1089426 [Bug 1089426] Fedora's version of Mono is horrendously outdated https://bugzilla.redhat.com/show_bug.cgi?id=1159091 [Bug 1159091] Review Request: openra - Libre/Free Real Time Strategy project that recreates the famous Command & Conquer titles -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Assignee|bjoern.es...@gmail.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|NEW CC||extras...@fedoraproject.org Flags|fedora-review? |needinfo?(extras-qa@fedorap |needinfo?(bjoern.esser@gmai |roject.org) |l.com) | --- Comment #9 from Raphael Groner --- No reply since over two weeks, removing assigned reviewer due to I guess it is no interest any more. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added CC||bjoern.es...@gmail.com Flags||needinfo?(bjoern.esser@gmai ||l.com) --- Comment #8 from Raphael Groner --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #7 from Raphael Groner --- https://koji.fedoraproject.org/koji/taskinfo?taskID=8585941 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #6 from Raphael Groner --- Now with all ExclusiveArchs. http://koji.fedoraproject.org/koji/taskinfo?taskID=8585916 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Whiteboard|NotReady| --- Comment #5 from Raphael Groner --- Spec URL: https://raphgro.fedorapeople.org/review/mono/fuzzynet/fuzzynet.spec SRPM URL: https://raphgro.fedorapeople.org/review/mono/fuzzynet/fuzzynet-1.2.0-0.3.beta.fc21.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=8585865 Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Severity|medium |low -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Priority|medium |low Severity|low |medium -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Blocks|1159091 | Depends On||1159091 Whiteboard||NotReady --- Comment #4 from Raphael Groner --- Setting *depends* on openra review cause that library has no other intention currently than to unbundle from openra. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1159091 [Bug 1159091] Review Request: openra - Libre/Free Real Time Strategy project that recreates the famous Command & Conquer titles -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #3 from Björn "besser82" Esser --- from current spec-file: # license https://sf.net/p/%{name}/discussion/793047/thread/c1b1867f/ Source10: http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt dafuq? Thou shall not includeth license-files which are not in tarball! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 --- Comment #2 from Raphael Groner --- Spec URL: https://raphgro.fedorapeople.org/review/mono/fuzzynet/fuzzynet.spec SRPM URL: https://raphgro.fedorapeople.org/review/mono/fuzzynet/fuzzynet-1.2.0-2.beta.fc20.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=8380890 Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Björn "besser82" Esser changed: What|Removed |Added Flags||fedora-review? --- Comment #1 from Björn "besser82" Esser --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. ---> Cannot find any license-info in package, license-file nor sources… [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/review/1166916-fuzzynet/licensecheck.txt ---> Cannot verify license… [-]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. ---> License?!? [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package ---> There are no devel-files but only documentation in -devel-pkg. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). ---> Execption for /usr/lib/ with Mono. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. ---> See remarks below… [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. ---> Empty debuginfo [!]: Package is not known to require an ExcludeArch tag. ---> There are arches known which are not working with Mono… [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 21 files. ---> Move the documentation to the main-pkg and drop the devel-pkg, please. [!]: Package complies to the Packaging Guidelines ---> *SEVERE* issues are present! [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ---> Cannot find any hint about that in upstream's bugtracker >.> [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fuzzynet- devel ---> -devel-pkg is obsolete and NOT useful. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from ups
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166916] Review Request: fuzzynet - Fuzzy Logic Library for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=1166916 Raphael Groner changed: What|Removed |Added Blocks||1159091 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1159091 [Bug 1159091] Review Request: openra - Libre/Free Real Time Strategy project that recreates the famous Command & Conquer titles -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review