[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-08-14 11:49:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005



--- Comment #9 from Upstream Release Monitoring 
 ---
social's scratch build of
openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for
git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6
and rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005



--- Comment #8 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #6 from Haïkel Guémar karlthe...@gmail.com ---
I hereby approve this package into Fedora Packages Collection as it complies
with our guidelines.
Please submit a scm request

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
 8 files have unknown license. Detailed output of licensecheck in
 /home/hguemar/1168005-python-manilaclient-1.0.1-3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
 manilaclient-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005

Pete Zaitcev zait...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #7 from Pete Zaitcev zait...@redhat.com ---
New Package SCM Request
===
Package Name: python-manilaclient
Short Description: Client Library for OpenStack Share API
Upstream URL: https://github.com/openstack/python-manilaclient
Owners: zaitcev
Branches: f20 f21 f22
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005



--- Comment #5 from Pete Zaitcev zait...@redhat.com ---
Spec URL:
http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-3.spec
SRPM URL:
http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-3.fc21.src.rpm
Description:
Client library and command line utility for interacting with Openstack
Share API.
Fedora Account System Username: zaitcev

Build verified using mock(1).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005



--- Comment #4 from Haïkel Guémar karlthe...@gmail.com ---
My apologies Pete, I failed to see your update.
There's still one build failure due to missing BuildRequires:
python-oslo-sphinx.

There should be no other issue remaining.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005



--- Comment #2 from Haïkel Guémar karlthe...@gmail.com ---
Other changes:
* BR: python2-devel
* please use versionned python macros %{__python2} %{python2_sitelib}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005



--- Comment #3 from Pete Zaitcev zait...@redhat.com ---
Spec URL:
http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-2.spec
SRPM URL:
http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-2.fc20.src.rpm
Description:
Client library and command line utility for interacting with Openstack
Share API.
Fedora Account System Username: zaitcev

Haikel's comments are addressed in full. The bumped release should identify
the correct spec and SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168005] Review Request: python-manilaclient - Client Library for OpenStack Share API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1168005

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||karlthe...@gmail.com
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com



--- Comment #1 from Haïkel Guémar karlthe...@gmail.com ---
Few things:
* Requires: python-requests should be versioned or else it will pull the wrong
version on EL7 (fixed yesterday a similar bug with python-glanceclient)
* Group tag is not required anymore

Could you repost links to spec/srpm ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review