[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-PyMySQL-0.6.6-4.fc23 |0.6.6-4.fc22 Resolution|ERRATA |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-PyMySQL-0.6.6-4.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-PyMySQL-0.6.6-4.fc23 Resolution|--- |ERRATA Last Closed||2015-08-18 01:25:28 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-PyMySQL-0.6.6-4.fc23 has been pushed to the Fedora 23 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-PyMySQL-0.6.6-4.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-PyMySQL-0.6.6-4.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-PyMySQL-0.6.6-4.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-PyMySQL-0.6.6-4.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/python-PyMySQL-0.6.6-4.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432
William Moreno williamjmore...@gmail.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #6 from William Moreno williamjmore...@gmail.com ---
PACKAGE APROVED
===
Just note than %py2/3_build and %py2/3_install will not work in Fedora22 and
Epel7
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-compyte , python3-compyte
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 Julien Enselme juj...@jujens.eu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Julien Enselme juj...@jujens.eu --- Thanks for the review. New Package SCM Request === Package Name: python-PyMySQL Short Description: Pure-Python MySQL client library Upstream URL: https://pypi.python.org/pypi/PyMySQL/ Owners: jujens Branches: f22 f23 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #5 from Julien Enselme juj...@jujens.eu --- The spec looks great but you must use the %%license macro in %%files: Forgot to update that, sorry: SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-PyMySQL.spec SRPMS: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-PyMySQL-0.6.6-4.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #3 from Julien Enselme juj...@jujens.eu --- Just updated the SPEC to match the new python packaging guidelines. It builds on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10615412 SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-PyMySQL.spec SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-PyMySQL-0.6.6-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #4 from William Moreno williamjmore...@gmail.com --- The spec looks great but you must use the %%license macro in %%files: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text Please fix this issue and I will run a full review If this package requires a running mariadb server to connect with it I think than will be better to Requires: mariadb-server https://apps.fedoraproject.org/packages/mariadb-server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #2 from Julien Enselme juj...@jujens.eu --- - Add Provides: python2-PyMySQL - Remove usage of %%py3dir SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-PyMySQL.spec SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-PyMySQL-0.6.6-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 William Moreno williamjmore...@gmail.com changed: What|Removed |Added CC||williamjmore...@gmail.com Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #1 from Julien Enselme juj...@jujens.eu --- Update to 0.6.6: - SPECS: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-PyMySQL.spec - SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-PyMySQL-0.6.6-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
