[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-supports-color-1.2.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-supports-color-1.2.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-supports-color-1.2.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2015-03-05 09:40:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-supports-color-1.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-supports-color-1.2.0-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-supports-color-1.2.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-supports-color-1.2.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-supports-color-1.2.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-supports-color-1.2.0-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Swapped EOL f19 for freshly branched f22. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review- |fedora-review+ --- Comment #4 from Piotr Popieluch piotr1...@gmail.com --- looks good, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: nodejs-supports-color Short Description: Detect whether a terminal supports color Upstream URL: https://npmjs.org/package/supports-color Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #3 from Ralph Bean rb...@redhat.com --- Thanks for the review, Piotr! Here's a new release that that addresses your three comments: Spec URL: http://threebean.org/rpm/SPECS/nodejs-supports-color.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-supports-color-1.2.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924
Piotr Popieluch piotr1...@gmail.com changed:
What|Removed |Added
CC||piotr1...@gmail.com
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
Flags||fedora-review-
--- Comment #2 from Piotr Popieluch piotr1...@gmail.com ---
1. Please enable tests:
all BR's are now in Fedora and the tests succeed here.
Source0: http://registry.npmjs.org/%{barename}/-/%{barename}-%{version}.tgz
and in %prep
cp -p %{SOURCE1} .
2. Cli.js executable doesn't work when run:
$ supports-color
module.js:340
throw err;
^
Error: Cannot find module './package.json'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object.anonymous (/usr/bin/supports-color:3:11)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
This can be fixed by installing cli.js into the module directory and making a
symlink in /usr/bin, like this:
%install
mkdir -p %{buildroot}%{nodejs_sitelib}/supports-color
cp -pr package.json index.js cli.js \
%{buildroot}%{nodejs_sitelib}/supports-color
mkdir -p %{buildroot}/%{_bindir}/
ln -s %{nodejs_sitelib}/supports-color/cli.js \
%{buildroot}/%{_bindir}/supports-color
3. Please comment out %nodejs_symlink_deps --build in the %build section. I do
understand that you want to keep this to keep all your node modules the same,
but it gives warnings when running the tests. Commenting out would be a good
compromise?
ARNING: the symlink for dependency require-uncached already exists
This could mean that the dependency exists in both devDependencies and
dependencies, which may cause trouble for people using this module with npm.
Please report this to upstream. For more information, see:
https://github.com/tchollingsworth/nodejs-packaging/pull/1
Looks good for the rest, you *could* add a manpage if you like. Will approve
when you enable test, comment out %nodejs_symlink_deps --build and fix the
cli.js symlink issue.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1169924-nodejs-supports-
color/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 --- Comment #1 from Ralph Bean rb...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8278790 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169924] Review Request: nodejs-supports-color - Detect whether a terminal supports color
https://bugzilla.redhat.com/show_bug.cgi?id=1169924 Ralph Bean rb...@redhat.com changed: What|Removed |Added Blocks||1115680 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1115680 [Bug 1115680] Review Request: nodejs-jscs - JavaScript Code Style -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
